public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: w15303746062@163.com
To: tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org
Cc: hpa@zytor.com, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: [BUG] x86/smpboot: WARN_ON in set_cpu_sibling_map triggered by numa=fake=2
Date: Wed, 29 Apr 2026 11:41:25 +0800	[thread overview]
Message-ID: <20260429034125.37368-1-w15303746062@163.com> (raw)

Hi x86 maintainers,

While fuzzing the v7.0 kernel, I encountered a persistent WARNING in `set_cpu_sibling_map()` during boot when using the `numa=fake=2` command-line parameter.

The issue appears to be a logic gap in the topology consistency check. When `numa=fake=N` is used, it artificially divides a single physical package into multiple software NUMA nodes. However, the existing check in `set_cpu_sibling_map()` does not account for this fake NUMA state:

    if (match_pkg(c, o) && !topology_same_node(c, o))
        WARN_ON_ONCE(topology_num_nodes_per_package() == 1);

Since `numa=fake` forces `!topology_same_node(c, o)` to be true for CPUs on the same package, the WARN_ON_ONCE is falsely triggered. With `panic_on_warn=1` enabled in many fuzzing and testing environments, this leads to an early boot panic.

Here is the relevant part of the crash log:

------------[ cut here ]------------
WARNING: arch/x86/kernel/smpboot.c:698 at set_cpu_sibling_map+0x1206/0x1f20
Modules linked in:
CPU: 1 UID: 0 PID: 0 Comm: swapper/1 Not tainted 7.0.0 #1 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009)
RIP: 0010:set_cpu_sibling_map+0x1206/0x1f20
Call Trace:
 <TASK>
 ap_starting arch/x86/kernel/smpboot.c:196 [inline]
 start_secondary+0xd8/0x2d0 arch/x86/kernel/smpboot.c:280
 common_startup_64+0x13e/0x148
 </TASK>
---[ end trace ]---

I am reporting this to bring it to your attention, as it might require a small adjustment to bypass this strict topology check when `numa=fake` is active.

Best regards,
Mingyu Wang


             reply	other threads:[~2026-04-29  3:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  3:41 w15303746062 [this message]
2026-05-04  7:48 ` [BUG] x86/smpboot: WARN_ON in set_cpu_sibling_map triggered by numa=fake=2 Peter Zijlstra
2026-05-04 13:57   ` w15303746062

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429034125.37368-1-w15303746062@163.com \
    --to=w15303746062@163.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox