From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E78F535A387 for ; Wed, 29 Apr 2026 07:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777446861; cv=none; b=bC0Bl2MBUsZFM76JGgqvKAkqjRBphRC/VZOioAeXa199givUWv5eRlNmN6qkmwyr5bFv3Fhm2ljl+h7sn2WfKTqnzPxvdcGRbiMgJaAy7CnSsIYsWKQi7wbivtUVqS1pGBTd+dXCORXgTMtPG0yJu2JjQTe92uusUxV48lKnii4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777446861; c=relaxed/simple; bh=Ms3QAY077lghlESoMz4cmu/HHhwxOm5OtQ9Q3cVsBZA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=prHLnUqMb22WJCHO59z211qklQB18D8314Dj/3ljbAJzu9HmH+rWbKlHi4Hu34pN9TD8XlIC9VbsRIcyBDNx38pDYZ2fMyfsX4JHH12B5UaCnAv8U3NgoqtSNrTCPjF/7NsH5Gs2sQN+ZYpYtXa0S74g4pqLkCYFk2aHWT415Dw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GXXiujZA; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GXXiujZA" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-392445f11c5so9115571fa.1 for ; Wed, 29 Apr 2026 00:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777446858; x=1778051658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z19nRFaT8/kYHTBgQjxsWY7McT0fpcEner+6VJ01bbE=; b=GXXiujZA6sgGAOLk3UWVkFJ2FnYBhBH88SLArKYKVtErv6uQJxdTJ1jCkNt7e70I1P +yaWVROSYDgAqLFhz2GDxZqjsssFaAL5Sg1LMb3mBXgg6s1ycRDYuEV1ipPmBCybR0Vu LiCakfldgTJdPN+4u4yEnCN+3HvYnh8L7G+tWi+iBiwW9ZVSG36KeVCnAzrs2OzFAcjV dg+blocFeBf57Q91zLCRcJ2p0fBvL4RX0Dc4SxnyNgnV0Lmzu0PBEWHnVPmk7XVehEV6 39YLqCkFO1AS3E6swjT0+XGer/dzRmuhN7bxLcHnK3KOcDGpCLux/Fb1/CxMB84bO6Nq SOWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777446858; x=1778051658; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z19nRFaT8/kYHTBgQjxsWY7McT0fpcEner+6VJ01bbE=; b=gAlrFX3pfEI00kuaHAQmi6IT4jv6D4A8pbWE2P/tZu3OpZ6rXmv65Pl06qBwGZA9qE 9/AtgqAszFit4QCE9NzpI5lbCPS0KZiY/n5w9zfHQmuwlKMBNjVuPUAnU9elCqOZBYrW BpM3W2DnnOPMEODFmIOflpOLZQZRwcU/oPAh6qUjlJHHRpW9gU2GrZHQ0LwI4mQgFiEW rKVV9e9ISNs/SPQbAv/t+na0zAmQfuVy9crYJHx2/DU/2hceYwsRthtLgl43kckNxJou CrUbdABDUVemzurPhNmZY/zDCec0Q5K1gwcXQDpU1rVy1EGSt25nsVv1LMlwv43IfSbF 6Uxw== X-Gm-Message-State: AOJu0YxdE2bh2fhlvD33fzhPwDOsjwJZqU/3bO2bpzyW3j8A4xRQNQ/b x9VlZM2z3GYk1O0mYkwicx06FyQXs7L8rHeE5z4XRczIkOjDgOZEazedinov88Zc X-Gm-Gg: AeBDieuqn9R1zHYo740kL//eVwW7ljRKQXVwXSBCL2QZb9AW78fGxVrvq4UlorJVjYe Hy1UcGdsMGdIt0nYJyHOmp9ZY42U5YMFBgZnfbSGHt2GJ2WLUwaLMLCbE+qjHND2aVik5YR58NQ ImFqLaPnWDJhYq3IL37ftg3piYDq2lf2ILRZpLXU6hNWJU6ZFoSxRXFm2xq4ydoMVzgPj9ClxHr BAocINv35bTKaOCpMz7zl4XNf0yssCAHEx7FdLnNyCrt33UbPTTGCOP455pcfvyzZtnNZHk/6B+ sSIbX/woMDxqfxiqsyrCYjtxkDMcoSlNU6MNlnjaO/aGdfG1IwT48QaezJn5YONSRUxM6J5cWnB aEtnEuC80ulcEIz9oconh35lWb7IAWb7fI8dMOBK2cR4KOgddtaQZskcN9i/BbtVeUli/6kWk/M 3j/+ydekpuQ5KBMAq/EZVrpfvxtat0+Ac= X-Received: by 2002:a2e:9896:0:b0:389:e6e4:3c7d with SMTP id 38308e7fff4ca-3924d716d8amr5232581fa.19.1777446857723; Wed, 29 Apr 2026 00:14:17 -0700 (PDT) Received: from thinkpad ([188.225.109.225]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3924fa7c93bsm2861151fa.23.2026.04.29.00.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 00:14:17 -0700 (PDT) From: Matthew Bystrin To: Lee Jones , Richard Cochran , Min Li Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 0/2] mfd: rsmu: fixes and new IC support Date: Wed, 29 Apr 2026 10:20:45 +0300 Message-ID: <20260429072047.1111427-1-dev.mbstr@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi! First patch fixes Renesas 8A34002 SPI driver. In my setup 8A34002 is connected to VisionFive2 (via SPI or I2C). I've discovered that upstream driver does not work: [ 4.728771] 8a3400x-phc 8a3400x-phc.0.auto: 4.8.7, Id: 0x4002 HW Rev: 5 OTP Config Select: 0 [ 4.737389] 8a3400x-phc 8a3400x-phc.0.auto: requesting firmware 'idtcm.bin' [ 4.744462] 8a3400x-phc 8a3400x-phc.0.auto: Direct firmware load for idtcm.bin failed with error -2 [ 4.753547] 8a3400x-phc 8a3400x-phc.0.auto: Failed at line 1273 in idtcm_load_firmware! [ 4.761576] 8a3400x-phc 8a3400x-phc.0.auto: loading firmware failed with -2 [ 4.769411] 8a3400x-phc 8a3400x-phc.0.auto: No wait state: DPLL_SYS_STATE 0 [ 4.776374] 8a3400x-phc 8a3400x-phc.0.auto: Continuing while SYS APLL/DPLL is not locked [ 4.785206] 8a3400x-phc 8a3400x-phc.0.auto: Unsupported MANUAL_REFERENCE: 0x00 [ 4.796930] 8a3400x-phc 8a3400x-phc.0.auto: PLL2 registered as ptp0 This being caused by a piece of code in rsmu_write_page_register() function: if (reg < RSMU_CM_SCSR_BASE) return 0; All addresses in include/linux/mfd/idt8a340_reg.h are less than RSMU_CM_SCSR_BASE so functions was returning early, before any modifications to the page register. Valid read of versions - is just a coincidence, because default value of the page register is zero. There were 2 separate patch series which had to be merged in one time: mfd and ptp. The latter have been merged, the former [1] have not. As result we've got a broken driver. This patch can be reverted later when the second part will be ready (of course if it is planned to do so). Any comments, Min? I could support with testing. Second patch just adds support for 8A34002, which is compatible with 8A34001. As I can see there is no need to update bindings, everything is already being done. Link [2] to v1. Changes in v2: - Fix page register issue in rsmu_i2c - Add support for 8a34002 in rsmu_i2c Link [1]: https://lore.kernel.org/netdev/LV3P220MB1202F8E2FCCFBA2519B4966EA0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM/ Link [2]: https://lore.kernel.org/netdev/20260421090710.395591-1-dev.mbstr@gmail.com/ Signed-off-by: Matthew Bystrin Matthew Bystrin (2): mfd: rsmu: fix page register setup mfd: rsmu: add 8a34002 support drivers/mfd/rsmu_i2c.c | 8 +++----- drivers/mfd/rsmu_spi.c | 7 +++---- 2 files changed, 6 insertions(+), 9 deletions(-) -- 2.53.0