From: Johan Hovold <johan@kernel.org>
To: Radu Pirea <radu_nicolae.pirea@upb.ro>, Mark Brown <broonie@kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH] spi: at91-usart: drop dead runtime pm support
Date: Wed, 29 Apr 2026 11:20:05 +0200 [thread overview]
Message-ID: <20260429092005.166128-1-johan@kernel.org> (raw)
Drop the dead runtime PM support which has never been enabled.
Fixes: 96ed3ecde2c0 ("spi: at91-usart: add power management support")
Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/spi/spi-at91-usart.c | 39 ++++++++----------------------------
1 file changed, 8 insertions(+), 31 deletions(-)
diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
index 32fee5a7ffdf..77cad4118202 100644
--- a/drivers/spi/spi-at91-usart.c
+++ b/drivers/spi/spi-at91-usart.c
@@ -16,7 +16,6 @@
#include <linux/gpio/consumer.h>
#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
#include <linux/spi/spi.h>
@@ -572,38 +571,18 @@ static int at91_usart_spi_probe(struct platform_device *pdev)
return ret;
}
-__maybe_unused static int at91_usart_spi_runtime_suspend(struct device *dev)
-{
- struct spi_controller *ctlr = dev_get_drvdata(dev);
- struct at91_usart_spi *aus = spi_controller_get_devdata(ctlr);
-
- clk_disable_unprepare(aus->clk);
- pinctrl_pm_select_sleep_state(dev);
-
- return 0;
-}
-
-__maybe_unused static int at91_usart_spi_runtime_resume(struct device *dev)
-{
- struct spi_controller *ctrl = dev_get_drvdata(dev);
- struct at91_usart_spi *aus = spi_controller_get_devdata(ctrl);
-
- pinctrl_pm_select_default_state(dev);
-
- return clk_prepare_enable(aus->clk);
-}
-
__maybe_unused static int at91_usart_spi_suspend(struct device *dev)
{
struct spi_controller *ctrl = dev_get_drvdata(dev);
+ struct at91_usart_spi *aus = spi_controller_get_devdata(ctrl);
int ret;
ret = spi_controller_suspend(ctrl);
if (ret)
return ret;
- if (!pm_runtime_suspended(dev))
- at91_usart_spi_runtime_suspend(dev);
+ clk_disable_unprepare(aus->clk);
+ pinctrl_pm_select_sleep_state(dev);
return 0;
}
@@ -614,11 +593,11 @@ __maybe_unused static int at91_usart_spi_resume(struct device *dev)
struct at91_usart_spi *aus = spi_controller_get_devdata(ctrl);
int ret;
- if (!pm_runtime_suspended(dev)) {
- ret = at91_usart_spi_runtime_resume(dev);
- if (ret)
- return ret;
- }
+ pinctrl_pm_select_default_state(dev);
+
+ ret = clk_prepare_enable(aus->clk);
+ if (ret)
+ return ret;
at91_usart_spi_init(aus);
@@ -638,8 +617,6 @@ static void at91_usart_spi_remove(struct platform_device *pdev)
static const struct dev_pm_ops at91_usart_spi_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(at91_usart_spi_suspend, at91_usart_spi_resume)
- SET_RUNTIME_PM_OPS(at91_usart_spi_runtime_suspend,
- at91_usart_spi_runtime_resume, NULL)
};
static struct platform_driver at91_usart_spi_driver = {
--
2.53.0
next reply other threads:[~2026-04-29 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 9:20 Johan Hovold [this message]
2026-05-04 13:04 ` [PATCH] spi: at91-usart: drop dead runtime pm support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429092005.166128-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox