From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B38FA2F99B8 for ; Wed, 29 Apr 2026 10:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777457886; cv=none; b=A7EGSsZ3Ex3gtfEwikNGDMbxYN6Dx/DkJ4X3wC5Ey5USTyBza5sx6v/0JY7I8JtFTAr0h6anuTfQLdyjfvCgX0Lusn2HDTCqCAhtEkI1JYTQJcRWp798Nmoad8sr8m6LZx4JafCkAkeyrYC66Gw7ZvxFpKphaFxL+FRI+xud83w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777457886; c=relaxed/simple; bh=XyG3lcjviMEH7DQLex3BNoJvAoXZ8iidtMQVfqbQmsk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rEgIqS6U7cu5Y2IFopXi7Ozk9Y8P70UVEBICVuVMJJMbJyg0eQFv0mv4bN7Gd9FhzQ7ZW12YEvxgg6NxJGuOChGDUVvvywiD3H0hyqd/F1y+tLf37+Yn4FjvQfcFlcstiargF6xvcKZ7OpTWNT7RWXrcXQ/7wzPBE8LdL6XgSyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fbmQS/pr; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fbmQS/pr" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777457882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BqncJV4IIuNl74OcpLfIEX+6S93xCToyEZcxwBxmSJs=; b=fbmQS/przK+Olv5yhVDdsfuT9416r9664wMln06RM15nNab7x6hpS8AtBEbKqWPxUoQFv3 3+Ip3/QVnJm0b6NEE8vlRie3d1MYEUFxWOssRiaRxV0blBtkMbkBEanQAxJH6yaNEOt/Mf p3GIykMdgjafBcdSW8w2FjHOleDCkVI= From: Thorsten Blum To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH] x86/boot: remove commented out code in getchar() Date: Wed, 29 Apr 2026 12:17:09 +0200 Message-ID: <20260429101709.110970-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=590; i=thorsten.blum@linux.dev; h=from:subject; bh=XyG3lcjviMEH7DQLex3BNoJvAoXZ8iidtMQVfqbQmsk=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJkfby1l21hW++7No4OJxrP5tUyYCjRcRQ2uprQHJH2J/ ugwqetPRykLgxgXg6yYIsuDWT9m+JbWVG4yidgJM4eVCWQIAxenAEwk04Thf71e0lbvFbftvpV8 2XDQWaLPK09Cs2nfk1mMfSG8FT0TjzEybPY19XJ8zXDf87XFvRdsNxr373z3oZs388SymeqdpyL mcQIA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The code has been commented out ever since commit df7699c56421 ("x86, setup: "glove box" BIOS interrupts in the core boot code") - remove it. Signed-off-by: Thorsten Blum --- arch/x86/boot/tty.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c index f7eb976b0a4b..3ca8115ef5eb 100644 --- a/arch/x86/boot/tty.c +++ b/arch/x86/boot/tty.c @@ -88,7 +88,6 @@ int getchar(void) struct biosregs ireg, oreg; initregs(&ireg); - /* ireg.ah = 0x00; */ intcall(0x16, &ireg, &oreg); return oreg.al;