public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	=Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] net: Unify user-visible "Qualcomm" name
Date: Wed, 29 Apr 2026 11:27:03 +0100	[thread overview]
Message-ID: <20260429102703.GX900403@horms.kernel.org> (raw)
In-Reply-To: <ac91a635-4aeb-4fa2-a00a-0e3425caaea4@oss.qualcomm.com>

On Tue, Apr 28, 2026 at 06:28:24PM +0200, Krzysztof Kozlowski wrote:
> On 28/04/2026 18:14, Simon Horman wrote:
> > On Mon, Apr 27, 2026 at 09:01:27AM +0200, Krzysztof Kozlowski wrote:
> >> Various names for Qualcomm as a company are used in user-visible config
> >> options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
> >> "Qualcomm" so it will be easier for users to identify the options when
> >> for example running menuconfig.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > 
> > ...
> > 
> >> diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
> >> index 88df55d78d90..958dbc7347fa 100644
> >> --- a/drivers/net/wwan/Kconfig
> >> +++ b/drivers/net/wwan/Kconfig
> >> @@ -38,7 +38,7 @@ config WWAN_HWSIM
> >>  	  called wwan_hwsim.  If unsure, say N.
> >>  
> >>  config MHI_WWAN_CTRL
> >> -	tristate "MHI WWAN control driver for QCOM-based PCIe modems"
> >> +	tristate "MHI WWAN control driver for Qualcomm-based PCIe modems"
> >>  	depends on MHI_BUS
> >>  	help
> >>  	  MHI WWAN CTRL allows QCOM-based PCIe modems to expose different modem
> > 
> > Hi Krzysztof,
> > 
> > Sashiko points out that QCOM is still used on the line above.
> > 
> >> @@ -51,7 +51,7 @@ config MHI_WWAN_CTRL
> >>  	  called mhi_wwan_ctrl.
> >>  
> >>  config MHI_WWAN_MBIM
> >> -        tristate "MHI WWAN MBIM network driver for QCOM-based PCIe modems"
> >> +        tristate "MHI WWAN MBIM network driver for Qualcomm-based PCIe modems"
> >>          depends on MHI_BUS
> >>          help
> >>            MHI WWAN MBIM is a WWAN network driver for QCOM-based PCIe modems.
> > 
> > And here too.
> 
> Yes, I did not unify every single text because I believe that might be
> more churn and not that much benefit. I think it is more important to
> have a list of drivers in xconfig or menuconfig nicely organized and the
> help message matters less.
> 
> But if you wish, I can replace it there as well.

Thanks for clarifying.

I have no strong preference and am happy with this patch as-is.

Reviewed-by: Simon Horman <horms@kernel.org>

I see this was marked as changes requested.
Presumably due to my previous email.
Let's see if this helps.

pw-bot: under-review


  reply	other threads:[~2026-04-29 10:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  7:01 [PATCH] net: Unify user-visible "Qualcomm" name Krzysztof Kozlowski
2026-04-27  7:05 ` Krzysztof Kozlowski
2026-04-28 16:14 ` Simon Horman
2026-04-28 16:28   ` Krzysztof Kozlowski
2026-04-29 10:27     ` Simon Horman [this message]
2026-04-29 23:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429102703.GX900403@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=konradybcio@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox