From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F8ED3FFAB9; Wed, 29 Apr 2026 13:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777470213; cv=none; b=bkLzk4QXmaydqViVT0I2EV55FohxUyc+nkuEmisNXBsI8XTxFfJ/ztZ3O+smJ2LGOyP4/Wv/TPsfndhM6n90HQeM1H4+1uVqwGnfoDvyRPDTqsEggOGt5zEmyBweQ+hkYAO452swYgfOCSExGDEeB1kWxzkKO+gug94fSFy0Mac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777470213; c=relaxed/simple; bh=6CmdSRqBgcDMnEg7Iw4AGlEjRqglThA579jeLaWJJ6Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bl+PKtY6ufzot5XJ34YXZSTJthBJ2b7EO1vnBpXXoyn3Ga7AwtvpPqCEXBkabLZoeXxJFSGi82vyroAEK1qUPAN2VMCt6LoYkdgfepIEnG/WUUwzqeeUjUuoPw2c6yq1Kzf6qPkI5G8aPQRZ4vake+K+H3w60mDIHavj7RJByYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=FH+21a+v; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="FH+21a+v" Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id C70971FB70; Wed, 29 Apr 2026 15:43:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1777470201; bh=WoLY0VfrRS2QQCo2S5G6Qe5l+XRLfteiRAzVDZloMAY=; h=From:To:Subject; b=FH+21a+vlYMYyfVlq8SHvfYJSWJZ0Sez8wvlGLqzHnrQIDQ8m70j5dKq+E1Pq0s2F nPCU3N3/xsgOD8KVY63eDKR+TTAH6eW9V1J5tK8fTFn0x4chH3pJL4XzxHJVhVBdzs 37K7PDY8G06OC7grV45QghiBnqDH/ORMfGa0GJfqQ2wDYjU5NRgFeWinVfApqnlk0m iXZVWi4eXWGqSuIeeScNXW98rF+rESdiHHB6N2DT98Z8gO9z1YOXGEJif72aARhtAF oeTBJUAmPwrTpLunwKyptIj78GUEYXXcUo59xQK6xnMO4IMwQPAItFvd5nzVtDaoE1 nZGX0wAZO1Q0Q== Date: Wed, 29 Apr 2026 15:43:17 +0200 From: Francesco Dolcini To: Vitor Soares , Dmitry Baryshkov , Luca Ceresoli Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vitor Soares , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tomi Valkeinen Subject: Re: [PATCH v4] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Message-ID: <20260429134317.GA74339@francesco-nb> References: <20260407144142.1420354-2-ivitro@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260407144142.1420354-2-ivitro@gmail.com> +Dmitry, Luca Hello, On Tue, Apr 07, 2026 at 03:41:41PM +0100, Vitor Soares wrote: > From: Vitor Soares > > The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks > for both runtime PM and system sleep. This causes the DSI clocks to be > disabled twice: once during runtime suspend and again during system > suspend, resulting in a WARN message from the clock framework when > attempting to disable already-disabled clocks. > > [ 84.384540] clk:231:5 already disabled > [ 84.388314] WARNING: CPU: 2 PID: 531 at /drivers/clk/clk.c:1181 clk_core_disable+0xa4/0xac > ... > [ 84.579183] Call trace: > [ 84.581624] clk_core_disable+0xa4/0xac > [ 84.585457] clk_disable+0x30/0x4c > [ 84.588857] cdns_dsi_suspend+0x20/0x58 [cdns_dsi] > [ 84.593651] pm_generic_suspend+0x2c/0x44 > [ 84.597661] ti_sci_pd_suspend+0xbc/0x15c > [ 84.601670] dpm_run_callback+0x8c/0x14c > [ 84.605588] __device_suspend+0x1a0/0x56c > [ 84.609594] dpm_suspend+0x17c/0x21c > [ 84.613165] dpm_suspend_start+0xa0/0xa8 > [ 84.617083] suspend_devices_and_enter+0x12c/0x634 > [ 84.621872] pm_suspend+0x1fc/0x368 > > To address this issue, replace UNIVERSAL_DEV_PM_OPS() with > SET_RUNTIME_PM_OPS(), enabling suspend/resume handling through the > _enable()/_disable() hooks managed by the DRM framework for both > runtime and system-wide PM. > > Cc: stable@vger.kernel.org # 6.1.x > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > Reviewed-by: Tomi Valkeinen > Signed-off-by: Vitor Soares Luca, Dmitry: any chance you can help with this patch? Thanks, Francesco