[PATCH v7 5/9] iio: ssp_sensors: use local struct device

Sanjay Chitroda
2026-04-26T09:17:41Z

From: Sanjay Chitroda <sanjayembeddedse@gmail.com>

Introduce a struct device *dev derived from &spi->dev to improve
readability and reorder variable(s) to follow reversed xmas tree style.

Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/common/ssp_sensors/ssp_dev.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 9b8642193176..fa47282b39c0 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -492,27 +492,28 @@ EXPORT_SYMBOL_NS(ssp_register_consumer, "IIO_SSP_SENSORS");

static int ssp_probe(struct spi_device *spi)
{
- int ret, i;
+ struct device *dev = &spi->dev;
struct ssp_data *data;
+ int ret, i;

- data = ssp_parse_dt(&spi->dev);
+ data = ssp_parse_dt(dev);
if (!data) {
- dev_err(&spi->dev, "Failed to find platform data\n");
+ dev_err(dev, "Failed to find platform data\n");
return -ENODEV;
}

- ret = mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE,
+ ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE,
sensorhub_sensor_devs,
ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
if (ret < 0) {
- dev_err(&spi->dev, "mfd add devices fail\n");
+ dev_err(dev, "mfd add devices fail\n");
return ret;
}

spi->mode = SPI_MODE_1;
ret = spi_setup(spi);
if (ret < 0) {
- dev_err(&spi->dev, "Failed to setup spi\n");
+ dev_err(dev, "Failed to setup spi\n");
goto err_setup_spi;
}

@@ -548,7 +549,7 @@ static int ssp_probe(struct spi_device *spi)
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"SSP_Int", data);
if (ret < 0) {
- dev_err(&spi->dev, "Irq request fail\n");
+ dev_err(dev, "Irq request fail\n");
goto err_setup_irq;
}

@@ -562,11 +563,11 @@ static int ssp_probe(struct spi_device *spi)
if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) {
ret = ssp_initialize_mcu(data);
if (ret < 0) {
- dev_err(&spi->dev, "Initialize_mcu failed\n");
+ dev_err(dev, "Initialize_mcu failed\n");
goto err_read_reg;
}
} else {
- dev_err(&spi->dev, "Firmware version not supported\n");
+ dev_err(dev, "Firmware version not supported\n");
ret = -EPERM;
goto err_read_reg;
}
@@ -579,9 +580,9 @@ static int ssp_probe(struct spi_device *spi)
mutex_destroy(&data->pending_lock);
mutex_destroy(&data->comm_lock);
err_setup_spi:
- mfd_remove_devices(&spi->dev);
+ mfd_remove_devices(dev);

- dev_err(&spi->dev, "Probe failed!\n");
+ dev_err(dev, "Probe failed!\n");

return ret;
}
--
2.34.1