Re: [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe

Jonathan Cameron
2026-04-26T14:25:01Z

On Sun, 26 Apr 2026 14:47:09 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>
> dev_err_probe() makes error code handling simpler and handle
> deferred probe nicely (avoid spamming logs).
>
> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> ---
> changes in v7:
> - Drop redundant else with refactor as guided by Andy
> - Add new change in series for local dev variable with input from Andy
> - v6 change: https://lore.kernel.org/all/20260415050749.3858046-7-sanjayembedded@gmail.com/
> ---
> drivers/iio/common/ssp_sensors/ssp_dev.c | 38 +++++++++---------------
> 1 file changed, 14 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index 5415efc7bf48..22d26980baa2 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -517,25 +517,19 @@ static int ssp_probe(struct spi_device *spi)
> int ret, i;
>
> data = ssp_parse_dt(dev);
> - if (!data) {
> - dev_err(dev, "Failed to find platform data\n");
> - return -ENODEV;
> - }
> + if (!data)
> + return dev_err_probe(dev, -ENODEV, "Failed to find platform data\n");
>
> - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> - sensorhub_sensor_devs,
> + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, sensorhub_sensor_devs,

Unrelated change. Should not be in this patch.

> ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
> - if (ret < 0) {
> - dev_err(dev, "mfd add devices fail\n");
> - return ret;
> - }
> +

Normal to not have a blank line between call and error check, so why one here?

> + if (ret < 0)
> + return dev_err_probe(dev, ret, "mfd add devices fail\n");
>