Re: [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe

Andy Shevchenko
2026-04-27T08:20:33Z

On Sun, Apr 26, 2026 at 03:24:51PM +0100, Jonathan Cameron wrote:
> On Sun, 26 Apr 2026 14:47:09 +0530
> Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

...

> > - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
> > - sensorhub_sensor_devs,
> > + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, sensorhub_sensor_devs,
>
> Unrelated change. Should not be in this patch.
>
> > ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
> > - if (ret < 0) {
> > - dev_err(dev, "mfd add devices fail\n");
> > - return ret;
> > - }
> > +
>
> Normal to not have a blank line between call and error check, so why one here?
>
> > + if (ret < 0)
> > + return dev_err_probe(dev, ret, "mfd add devices fail\n");
> >

Ah, just replied with very same comments!

--
With Best Regards,
Andy Shevchenko