From: Cheng-Yang Chou <yphbchou0911@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Changwoo Min <changwoo@igalia.com>,
void@manifault.com, arighi@nvidia.com, kernel-dev@igalia.com,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
Chia-Ping Tsai <chia7712@gmail.com>
Subject: Re: [PATCH v3 0/3] sched_ext: Improve exit-time diagnostics
Date: Wed, 29 Apr 2026 19:29:30 +0800 [thread overview]
Message-ID: <20260429192218.G59fd@cchengyang.duckdns.org> (raw)
In-Reply-To: <e7cbfc99b52b4b7059267bb81498179f@kernel.org>
Hi Tejun,
On Tue, Apr 28, 2026 at 10:57:27PM -1000, Tejun Heo wrote:
> A few things I noticed that might be worth a follow-up:
>
> 1. scx_rcu_cpu_stall() takes no cpu, so the captured exit_cpu ends
> up being the detector rather than the stalled one. We could
> probably plumb it through from print_other_cpu_stall(), where
> the stalled cpu is known.
Do you mean we should change the function signatures to pass the stalled
CPU through, e.g. panic_on_rcu_stall(int stalled_cpu) and
scx_rcu_cpu_stall(int stalled_cpu)?
>
> 2. scx_hardlockup_irq_workfn() already has the hung cpu locally, so
> passing it via __scx_exit() might be a bit more robust than
> relying on irq_work routing.
>
> 3. Minor: "on cpu N" (kernel) vs "on CPU N" (UEI) - the casing
> could probably match.
>
I have a draft patch and can send it out. If Changwoo or anyone else is
already working on this, pls let me know!
--
Cheers,
Cheng-Yang
next prev parent reply other threads:[~2026-04-29 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 8:23 [PATCH v3 0/3] sched_ext: Improve exit-time diagnostics Changwoo Min
2026-04-29 8:23 ` [PATCH v3 1/3] sched_ext: Extract scx_dump_cpu() from scx_dump_state() Changwoo Min
2026-04-29 8:23 ` [PATCH v3 2/3] sched_ext: Dump the exit CPU first Changwoo Min
2026-04-29 8:23 ` [PATCH v3 3/3] sched_ext: Expose exit_cpu to BPF and userspace Changwoo Min
2026-04-29 8:57 ` [PATCH v3 0/3] sched_ext: Improve exit-time diagnostics Tejun Heo
2026-04-29 11:29 ` Cheng-Yang Chou [this message]
2026-04-29 12:51 ` Changwoo Min
2026-04-29 15:16 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429192218.G59fd@cchengyang.duckdns.org \
--to=yphbchou0911@gmail.com \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=chia7712@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox