From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2F739F166 for ; Wed, 29 Apr 2026 23:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777506083; cv=none; b=pkUrh4YmHygY6GcLF/rj3d8AB15X4ybQU0JFrrRVtppp7stBZHysyBplS81/IuO+mVqXbptXvFmGd7cR0qLMRioe9XpKkHEUWtfms2wVweOhMx9LNzwSEcsO9QbZVsULrq5OfBMDCMqcrOKrX2jjyc2B3KsQGYIj5U9meM65TRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777506083; c=relaxed/simple; bh=SENc4XzcXhXZH4RQPf5YBtAV9F2SAEGP6vKTlctEGbQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nKAozMgln/H/m4yclYav9eLW/EaO14JPHC6kRNBv3/JwEDv3kUlwmZACCNwS3vqdMXVHtTjhlzPH76mWcdZFEeILXt4CfhB4e2KRZhWCczL0o4FJhuqf2JRB09wi6FoFrMRSYTbpdIp+lhY23FumiUqmzTAWAKjuXlUj13aTCOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sinbNTJI; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sinbNTJI" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-358e3cc5e7eso159085a91.0 for ; Wed, 29 Apr 2026 16:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777506082; x=1778110882; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=DEbN0PRYPELCXuCsVB1AGme2es0zOz+5Jz+a4L5FzlI=; b=sinbNTJI2cD9GD1p3GkN83m5uDZaScn5pJrZfNfFyJdzcFzorap3bbfrZxgQUq8DZN w9sBG2Tk/EBx4bnkYLemDBpsWhL0EiCeybhf+9y2//m2eCpg5SWH6HsasrIhC144zZ4r EC00MKbaqgZ6Gr9gmvr8IcqRp5p/t2EtBSM1hZRKMsTPkFVPlGngrIBbTSAZacBN+eJh kS+IUxjOnX7R5waIXDbgLarehqj1abqXBzZRD2nQwCrWsgUMHFBf60cPquSBvL0RxfBF sgTUsv3MboJ93sE4qzW/MrWw6TWOiW4zBmRDD6k9sqDJSB6rU2D6GaNSF44W2ISFUvuw mJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777506082; x=1778110882; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DEbN0PRYPELCXuCsVB1AGme2es0zOz+5Jz+a4L5FzlI=; b=gFAVouTD3frL2/geRU+N6Ve8tbZR/ov+9i3nK4uhIgsEyWjt4Pqsv05PNaFMSXqBxA +S7O/AWbwFImE48qT58rWl9X2tTR4whvrEKgJO0MC8tRPgfPYN6wtX/j+IZbaPu7DuHD WrnF/l9l75hvYpvaigVWWR1tY/3NwP0EOSJ7sAirnQGgdd/pyXEbxcwdGNRQx8SZRh9T qKkx3hZfu7KAA56DxM+nzC6acKh4M2fOyUnLdFeETHngUyXbPuTCW+8VClPd0k8zbbmh tbA/yDesODwf9yD8imwHbS6FMdUPxGG5JLs2ZtbBg93HzETDbU0cosyx2WR66CB3uAMK rfmw== X-Forwarded-Encrypted: i=1; AFNElJ8VEIqL2qUQOK95TWKz3p8aaU9HXn/kzW6vFizeVdhdmFmf+RuhJnMV6e6gdNFqmkDXMtWWhj5a+8SIUNw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+vo3LCOfvozphR+/azZFbbLjlz+/bNXZvMQgEVBQo80xVR97m zyFH09NXpfo1FwSq63vo9GuRk5mHqKot178vYDkISqDFPc5sXj7h7aW3apB3JGzS X-Gm-Gg: AeBDieu3eNJGSu6Gn5mtwPNHfsd+/AeTM+iEGZo6d+65zvtKUBKSgJ3JH/czL25x0sw It+dDmBexA1YEn7KRpLlffoe4/0O9otdHWE2r0B5JzZG3c8WMcP30I3K4djBMXXII+bjy/iXsVk xkzjVxzClXRs9fUOcaAn6ElULH0UxjFQwvdt88OjnGRdIqoUbsjXbwhyLqjy2Xc5k0hJLUHWPiR NwcxPd3pE+YBi7JBO+jiWhDN2/NeW69EPF8Pfa/2t5IfmZjEx8gtR9ADQJtgs9X+4QXPzwxb8L0 hn+THv1y0Pk7VH1mNCOH7sLWbsGJpXF/4kDRST0/XSP74AX0P0jBVLl4xTf2zy1XnQB1sZLznNB speBKXF7j9/QfnzkCdDcQVoSFwJPE6fSccM9ZuIsMYHe1VPOIhZnTx7XGyhm+S80BS+yURL/OcN +5SN/E+tRh6ANDfrD30Ydqk2/5GhAAqNNmHBDRqOQasKaGRMUUck9zItQ8uyr1T2XM3KGqsFT7N trpVXVQNacVr9QEe4Y29pvoRy0= X-Received: by 2002:a17:90b:2fc8:b0:364:87dd:b2c4 with SMTP id 98e67ed59e1d1-364c32aa4bdmr345691a91.25.1777506081799; Wed, 29 Apr 2026 16:41:21 -0700 (PDT) Received: from archlinux (S010680dac2bce256.cg.shawcable.net. [174.0.186.197]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364be02940dsm702390a91.15.2026.04.29.16.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:41:21 -0700 (PDT) From: Jack Lee To: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Jack Lee , Josh Poimboeuf , Kees Cook , Ingo Molnar , linux-media@vger.kernel.org (open list:STAGING - ATOMISP DRIVER), linux-kernel@vger.kernel.org (open list:INTEL MID (Mobile Internet Device) PLATFORM), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM) Subject: [PATCH] staging: media: atomisp: ov2722: clean up ov2722_startup() Date: Wed, 29 Apr 2026 17:41:06 -0600 Message-ID: <20260429234110.7879-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove stale TODO comment that has been present since the file was first added to staging in 2017 and was never really acted on. Also replace return ret with return 0 since ret is guaranteed to be zero at that point, both write calls return early on failure. Signed-off-by: Jack Lee --- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c index 2c41c496daa6..fcd71cc55731 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c @@ -599,7 +599,6 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on) return ret; } -/* TODO: remove it. */ static int ov2722_startup(struct v4l2_subdev *sd) { struct ov2722_device *dev = to_ov2722_sensor(sd); @@ -619,7 +618,7 @@ static int ov2722_startup(struct v4l2_subdev *sd) return ret; } - return ret; + return 0; } static int ov2722_set_fmt(struct v4l2_subdev *sd, -- 2.54.0