From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC7E2C235E for ; Thu, 30 Apr 2026 19:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777576442; cv=none; b=axU8qltfdeONtveFgSdDgMSYx5jRbTjAtgJebd4Qj5yHCj1PV1Evoh59AFEixSgBuvIBV8tMbBZOBaNM+mwvszfIQbk+0zjt1E9E/vpzeEirLULELAvpQn03AD4FBeqzpvPCxG0OP7k4eOHTUKwbZsOQ7ndKW9zQJqnl+qWphe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777576442; c=relaxed/simple; bh=tO9222P2XCcdDssvF5Leobc2AmmtM1cHlctc/r09V6o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mnH8dC0kg3qIECQkXhCIaScrn68tx1uDjuVQzdDU0SUSGExyteDZU9Bg6XbntImd10MHMJGw8dyKd0W58xbdW60AatnKQLks7F6C+dA91h8B5x92vG35xGpVosbhyd+g3onW+djyWI+XJBmA6vaSr0em7gNkQhvWlsGDkIZHDAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p0fDgqkf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p0fDgqkf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04470C2BCB3; Thu, 30 Apr 2026 19:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777576441; bh=tO9222P2XCcdDssvF5Leobc2AmmtM1cHlctc/r09V6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p0fDgqkfnobv3nu5Y7xU42v5a9/Xps5sd6i7oNHF3UbA9MNz4w3rZVwsPev/XCEaO MjVlJTXe2P0y/BfhTXW+IatFci3q8ZphaKBg8t0Xjx4KK8ZmOWusritwKUrkRgvwLm y6yj/XxgMioVD0AlD/zjoAXFsLxqwxjD6YzmQ272Wo0OzXcV5PIR50+i3Ce6OXkdOv u3nz5au0/8JIZUBhxtf7Lnv5PuLWm43bzxF3FxH3ckMw81uyh8mDzlqxUsC8I+iuHU q9gnoWRyA3fEuv53A6gotTAqerAvFdFatepUydSb3mKa8frq9MLX3mgCwFbfUZCKLh XKplszh3hKA6Q== Date: Thu, 30 Apr 2026 20:13:57 +0100 From: Conor Dooley To: Dominique Belhachemi Cc: Jonathan Cameron , Paul Walmsley , Samuel Holland , Emil Renner Berthing , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cache: sifive_ccache: Add StarFive JH7110 SoC support Message-ID: <20260430-celibacy-semifinal-db18fc2fe553@spud> References: <20260430035259.3402954-1-domibel@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XDlUZPfitVSZRGpY" Content-Disposition: inline In-Reply-To: <20260430035259.3402954-1-domibel@debian.org> --XDlUZPfitVSZRGpY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 30, 2026 at 03:52:59AM +0000, Dominique Belhachemi wrote: > This cache controller is also used on the StarFive JH7110 SoC. It does > not have the data-uncorrectable ECC quirk that JH7100 has, so only > QUIRK_NONSTANDARD_CACHE_OPS is set. What's the motivation for enabling the nonstandard cache ops here? The driver already binds with the generic sifive compatible on this platform, and there's no peripherals currently supported on this platform that need non-coherent DMA. >=20 > Signed-off-by: Dominique Belhachemi > --- > drivers/cache/sifive_ccache.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/cache/sifive_ccache.c b/drivers/cache/sifive_ccache.c > index a86800b123b9..2acb8bdf06d5 100644 > --- a/drivers/cache/sifive_ccache.c > +++ b/drivers/cache/sifive_ccache.c > @@ -124,6 +124,8 @@ static const struct of_device_id sifive_ccache_ids[] = =3D { > { .compatible =3D "sifive,fu740-c000-ccache" }, > { .compatible =3D "starfive,jh7100-ccache", > .data =3D (void *)(QUIRK_NONSTANDARD_CACHE_OPS | QUIRK_BROKEN_DATA_UN= CORR) }, > + { .compatible =3D "starfive,jh7110-ccache", > + .data =3D (void *)(QUIRK_NONSTANDARD_CACHE_OPS) }, > { .compatible =3D "sifive,ccache0" }, > { /* end of table */ } > }; > --=20 > 2.53.0 >=20 --XDlUZPfitVSZRGpY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCafOp9QAKCRB4tDGHoIJi 0qMnAP4oqhfACHixRWZZQs+LKjPTc/Bj+NO4iynB0vEmvOAm+wEAsLlB7LLO4r1o MPzkWxGek1jevcKe3HA6PYlZgZs8LQE= =DH2q -----END PGP SIGNATURE----- --XDlUZPfitVSZRGpY--