From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f68.google.com (mail-yx1-f68.google.com [74.125.224.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC91BE573 for ; Thu, 30 Apr 2026 00:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777508546; cv=none; b=qcT5PpAjTPoLF+dagBW12XpL22vopt2DHeWEtdU2TSzrLFIfuZR1n9/9ddryWWR/2IHHRpPkRVx3C8xznRABmYEOQnxipR1EySsfVCDEOau3HFzz7nj0csmBKBqHNwHBJD81ewBjnodR4SHPz1bbe+Ij+/c/76CcynrwjrPp+GQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777508546; c=relaxed/simple; bh=Ei+yusGr1waT5D5MmKA+mppSGTTxd9CTBPqJxfbgUtg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=I8SUuwWc6SaVNS8s0bfXMk9gjNpsaFs40DJaW0l4jK7t6/jtDMMmu3P9O59d+R6qxfzzo56DSMFUPDX/cg+g3/dBTD/1KrmDobPdgiDuXM6Tu0wzhyUyPmXQB60+d1eM+Xr5HtMr96i1/en6YmtJekkRlok7e3+YN255UvdnMzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rmIIkEuL; arc=none smtp.client-ip=74.125.224.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rmIIkEuL" Received: by mail-yx1-f68.google.com with SMTP id 956f58d0204a3-6530287803cso353097d50.1 for ; Wed, 29 Apr 2026 17:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777508544; x=1778113344; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZCJerECtiCXIBCz7zgU9qCjidNXdZcf6eEV/QCLYq+A=; b=rmIIkEuLlfTkxgf0+6AQRgK/Usx7A5eqeGrecYt40N03NcBVquh3kXDINXitokRbmG KQ0QJVDdvxXVn/9SIcZBkvgvPiyqOflMEoirjU+j4k9LajIyZZ3s5+EyrtIqfISUE5oQ VDTvtUAfwtj68/4atpapALjX8Ro+18ILugNQWqW1bIIvEkICI2tIpU6TVpYP7kbDk7nP pSvUzkoHhth3z7VIjTeMndD9gfwIdpIYRze1wha8x9OPgIP4td+xyOIwyYV4q3TiMZJd 1mAoZcYTFw88cLcq9HRrgoDbgtGJKl8pnn8dmP1rjeGgNy+PBYP5i5wLmvH4uwcqQwtw /6lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777508544; x=1778113344; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZCJerECtiCXIBCz7zgU9qCjidNXdZcf6eEV/QCLYq+A=; b=gSpLuMY4d7JzSHBFaKSiooUTjwXIlAauhtdvOvyalyRAJnmG8q88c6PHtKPPT+DCKB l6EQXSp38V+x/tKYWgecZS7MBEhR8IR4JVPHHq9WqHkYAu+am3GPF6x2XI2vglHCgeGc mYxNsIGWQtCrtWjoHYFAFkREJOkI4YB39OYRZeljLqvCOxvoPenI/jg9qrX7p+jhE8/6 36cur1H7yqb/hw/KtE8+G8DtWZDIMwMitaAI4fGIXIBAR0x+7dBJ7OE+VNDxA1WocZ+N UlEBBEt7M12eXF0sidqRlE4WXbItUGdtZWpIyUVps+fVZe4m6yeP+KFbctDXbTatwmu0 GWLw== X-Forwarded-Encrypted: i=1; AFNElJ8DPf8zWZO2ufbuksNJ0BTRgFL6biSUGnrQMATGbagnQKzK/OBLuCL0+YTAwdtBq4/uuFUAVlpUV1kQJKc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg06uuxCnK7Z5/ldQHMSZI2RuhX7To4nB07ZTh8wBPDRCMLXC5 27bTQo64ad5WILSRgghTfV2eGymZ02KrrTURTdQfoXs4OvYPtOXD00R4 X-Gm-Gg: AeBDieu1VZ0HZtF9U1FX2xMTzyYpmxogatVFL1oKvpgdahvPRQjav7PeW3V6/geIbVo 1ZH9zq+5q9qYaN3znrIpj0cY2qeiWEa1kzT2QAaqJn6tgDcTzmu5vyvNFuKuw/0pAgr5WV0oJUm VC/X7JUNGVgSg88AY9KYGoGu3pHc9k+4hoSEUIPBocaLFeI7J1DjM8CXu0eJ4cGFLOGaWnw73Xm DDAFCUhSyX4IdeXPG1QrB41ZmpD8w0L4ciM/49A2rzEjTtWmzxCV8ZYPbH6EK/Lq/tUU6C5voYX 1nGeqkebi9Uz5UB4mcqzFNSqMeTgVg3GEdvwWr8568L7TLgYI4BKkorQoMJVQj+2zuKJDnbYMtX 9j/u4FsYStIVsyIZzTsPuVTfv4hu7EmzdD6pofykRBBnH62X/MqxevbKa/95h0SnHTfmdAxf8zF Hp46UgO03OQ/K00GdL+X250YJWhty1fa0qN34RVm6x0seGzUMu63tpRBY39pKJtfnyi8S+FE5/w A== X-Received: by 2002:a05:690e:128a:b0:65c:1a0f:d89e with SMTP id 956f58d0204a3-65c1a0fe0bamr296688d50.23.1777508543896; Wed, 29 Apr 2026 17:22:23 -0700 (PDT) Received: from localhost ([2600:1700:3420:b5d0::d]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65bff71d4c1sm1940136d50.14.2026.04.29.17.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 17:22:23 -0700 (PDT) From: kernelcoredev To: gregkh@linuxfoundation.org Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernelcoredev Subject: [PATCH v2] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name Date: Wed, 29 Apr 2026 20:22:20 -0400 Message-ID: <20260430002220.3665-1-sonionwhat@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed. Remove the FIXME comment and downgrade to dev_dbg as originally intended. Tested via code inspection only, as Project Ara hardware is no longer available. Signed-off-by: Bentley Blacketer --- drivers/staging/greybus/bootrom.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c..058044ba7 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -163,18 +163,13 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) * * XXX Name it properly.. */ - snprintf(firmware_name, sizeof(firmware_name), +snprintf(firmware_name, sizeof(firmware_name), FW_NAME_PREFIX "%08x_%08x_%08x_%08x_s2l.tftf", intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id); - // FIXME: - // Turn to dev_dbg later after everyone has valid bootloaders with good - // ids, but leave this as dev_info for now to make it easier to track - // down "empty" vid/pid modules. - dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n", + dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n", firmware_name); - rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev); if (rc) { -- 2.54.0