From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91080279917 for ; Thu, 30 Apr 2026 04:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777521747; cv=none; b=e5Ycy8p0/S208WkSQuc6YLrdJpUfnM3UM4tZrb8ElFYY0H/ZXb6L8cJurR6PvNnc5fCyXCeS4iyfwSjt5us/Df8OfUPebk2BA6AVv/9wW5LJxrTdrOMM064OzzM3w+wrlB72v2Gr8mgYgxgjMG/Hh62AmduBPdC6CU8AcBexc2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777521747; c=relaxed/simple; bh=S9qKw++DwaSQqM9CRZbugJWSsqmeGsHl7EmLAtvoLb0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=TKfYPm/bBtjaQBkjtaJEs11Lyey7nIB9JXRC0R6jfzczWc5d59iWYPtL8T5ewdPYqTdnWvGj9GthwYuyTqss2D39yR7TepTmvZY6WvsCz21SVknXkZ3jEZfZhYtoMbiJNWH9eHdzdXTFIZ5GFk8YpGxmLwuVXL6lRImWtYR/mVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j7HbN0wC; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j7HbN0wC" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c79467f11abso248028a12.2 for ; Wed, 29 Apr 2026 21:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777521746; x=1778126546; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fNAWw4AuVFxwgv1L7Dwy/JL7WXpBrh4g95GEue5eO0Y=; b=j7HbN0wCpv2lrFWCi10zdBuXJ/9p/36ODxjPdPE2sPZsn0K6zcsp9q9vBtzgduyZ55 11XmVqQuljwHHCuNRKT0oG3T1mwSk64CIzw8uMRRtiOr2I4saTiKcbll56da47sWhjLh Vmy0Xra+4KMC58OcMQxDbKrV4CW9Jo1a7eZVMiE06Jrqz9j0Si8kb4+Rf+CddAIedz3Q 7t6f2jhf05OrC0pa8x7ubK6R5i2yfz7A3NqQJJYbwqy1loQkhPhrSQCfchBP7/6lfbKb eJaCYUPBp8RyrPY/IBNZb0ftbO3CfN7vP3HEihCrdQBQ3JI7JgXOYoNOAk0CJfflbGWf tWEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777521746; x=1778126546; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fNAWw4AuVFxwgv1L7Dwy/JL7WXpBrh4g95GEue5eO0Y=; b=a85MmHsjyTMcA+eAAJrGKl1hQAx/MQ8StG9eiJHNf01HyS50oNupWJKBr4kQq0+YZ1 Sa8jpMn8P3GRbnnBovhfnAxLzM3zTHAMpvImVrnmelMrtoT+vdvH6uB4gLTs17ZI3Y2s Zw13yhoEw6cviHoK0u9EndOw88vWwHv9lHP6XyUrdUtZLD05y0Vp3J+23FG85I6s+JLV sx9xsFUgRadKWGtEJCPwwNa/IK97ASaQ977JoyykkUwrzdTTcan6fVJb/hmoq+ZYRlpK BSkLCCe7TwXNrjPq1n6A8fym8OOgifkBaxF8MNtMppfCXonpIigreRcMaxVY9a8dT+E5 Z0YQ== X-Forwarded-Encrypted: i=1; AFNElJ+D/xhc5N1PQTKSItRffKAm1DDfiaWdW1MjCzJvhNyxosG11O0w/4M5Cxb3iE+S0Qi/5v+Ru387HZwlnjU=@vger.kernel.org X-Gm-Message-State: AOJu0YwYTMHPActkYusDX8OPOdFZKxnVeNwFzEcwF1f6rwTPaXa9jSFY sSv80H+UdczqDdwxzFj0Xry1ZT/h+qzBYC2+fsZHl8zPh17UvMWjs2elrOJWYha7 X-Gm-Gg: AeBDieuKGs4yWzCIdng4vVSyeTv5Ga1aZMvEnqkMGcM6ZRCc/FEVU4EjIIrzFs7QNXW al6m5tt6VTFU1fLVK/YnjU87R3trxaP77yzRZ84Vrz3PRbQ4/8VtdRbsA1ixkgMFvFdUPUvpEX0 YCU9S3+aOZQicQe6KSfgSi9s/O0Jh+pMDLDWxEPqNdSfgl/kVPWjjacXbPI2Ka6TR2ctH8BV/M4 LyMnSTdUZqCvgFsSrahnsplFM55WyhsyutJpBq1dTDCImoSWz4xEcc1OaxTexr6zQgk6OH7eopb jNDzcapKLrCYBwVRShS2yQgoTAMq9kjg6ATr/ZqRvU3Nk0dBM+cPfPLNVH2UttuDt7/vnuRIdVL 6xlTMWcEnPbjmv865ls5WJ+sKTMIx9YdMPUBBHnYpimS0HUuKnBg7csCwqWGqVpwmGNowonW3dC JffspQTr6hcrT3k7ppBMQmsNiVWRvIVN79UUEn4tpwOJ1O4N6hqbQjSJ64SznS2mbSNjpL0qGvx 9PcG1uv7wC3EBXChpeUUYra7fi+WssyuQ+6 X-Received: by 2002:a05:6a21:6da3:b0:3a2:dd7d:b8aa with SMTP id adf61e73a8af0-3a3cf600db2mr1294744637.20.1777521745925; Wed, 29 Apr 2026 21:02:25 -0700 (PDT) Received: from localhost.localdomain ([117.71.53.159]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fd6514ec6sm3185142a12.31.2026.04.29.21.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 21:02:25 -0700 (PDT) From: Sun Jian To: shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, kees@kernel.org, linux-kernel@vger.kernel.org, linux@weissschuh.net, Sun Jian , Bjoern Doebel Subject: [PATCH v3] selftests/harness: harness-selftest: cover XFAIL_ADD ctor ordering Date: Thu, 30 Apr 2026 12:02:07 +0800 Message-ID: <20260430040207.296136-1-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add a fixture-based test with a single variant and mark it with XFAIL_ADD(). The test intentionally fails and is expected to be accounted as XFAIL, covering the constructor ordering dependency between TEST_F() registration and XFAIL_ADD() registration. Suggested-by: Thomas Weißschuh Tested-by: Bjoern Doebel Signed-off-by: Sun Jian --- v3: - Rebase on kselftest/fixes. - Refresh harness-selftest.expected after commit 465b05bae5ac ("selftests: harness: Restore order of test functions"). - Add Tested-by from Bjoern Doebel. v2: - update Suggested-by address - update harness-selftest.expected - verify with 'make run_tests' .../kselftest_harness/harness-selftest.c | 23 +++++++++++++++++++ .../harness-selftest.expected | 13 +++++++---- 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/kselftest_harness/harness-selftest.c b/tools/testing/selftests/kselftest_harness/harness-selftest.c index 3e3033d2745a..93b5a5bbf10a 100644 --- a/tools/testing/selftests/kselftest_harness/harness-selftest.c +++ b/tools/testing/selftests/kselftest_harness/harness-selftest.c @@ -158,6 +158,29 @@ TEST(test_result_skip) { ksft_test_result_skip(""); } +FIXTURE(xfail_ctor_ordering) { +}; + +FIXTURE_SETUP(xfail_ctor_ordering) { +} + +FIXTURE_TEARDOWN(xfail_ctor_ordering) { +} + +FIXTURE_VARIANT(xfail_ctor_ordering) { + int dummy; +}; + +FIXTURE_VARIANT_ADD(xfail_ctor_ordering, only) { + .dummy = 0, +}; + +TEST_F(xfail_ctor_ordering, expected_fail) { + ASSERT_EQ(1, 0); +} + +XFAIL_ADD(xfail_ctor_ordering, only, expected_fail); + int main(int argc, char **argv) { /* diff --git a/tools/testing/selftests/kselftest_harness/harness-selftest.expected b/tools/testing/selftests/kselftest_harness/harness-selftest.expected index c0a68ec124f8..f8b7cb2812b6 100644 --- a/tools/testing/selftests/kselftest_harness/harness-selftest.expected +++ b/tools/testing/selftests/kselftest_harness/harness-selftest.expected @@ -1,6 +1,6 @@ TAP version 13 -1..19 -# Starting 19 tests from 4 test cases. +1..20 +# Starting 20 tests from 5 test cases. # RUN global.standalone_pass ... # harness-selftest.c:19:standalone_pass:before # harness-selftest.c:23:standalone_pass:after @@ -93,6 +93,11 @@ ok 18 fixture_parent.pass # pass: Test terminated by assertion # FAIL fixture_setup_failure.pass not ok 19 fixture_setup_failure.pass -# FAILED: 12 / 19 tests passed. +# RUN xfail_ctor_ordering.only.expected_fail ... +# harness-selftest.c:179:expected_fail:Expected 1 (1) == 0 (0) +# expected_fail: Test terminated by assertion +# FAIL xfail_ctor_ordering.only.expected_fail +ok 20 xfail_ctor_ordering.only.expected_fail # XFAIL unknown +# FAILED: 13 / 20 tests passed. # 1 skipped test(s) detected. Consider enabling relevant config options to improve coverage. -# Totals: pass:9 fail:7 xfail:1 xpass:1 skip:1 error:0 +# Totals: pass:9 fail:7 xfail:2 xpass:1 skip:1 error:0 -- 2.43.0