From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5C6344D99 for ; Thu, 30 Apr 2026 04:05:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777521925; cv=none; b=NAonSa8ygG9mt8SEmqxaH9WiKO+IcMLIGw1HG2B281q9/ZVxJYHeU9WuXH14AtvN+i+EZNoGITM4W9dUBxdih+b1FmrV6u1r5RgA/XOQExrDjB+hX3H26XCR6S+O5auKFEea5jRPX+8YazLKnaz3SRJsK5WScp13a8Wu0IKpJ2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777521925; c=relaxed/simple; bh=Pz1lBBVHgNHxzgHQuvaf765l8g2Vci0J0xiHJ7n510c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QQwfmR0drITDX7vYpVeW3m/e3N9z3MAyScaJ4/NlYT/CWHgD1uIeXV05pykGXxgKgLyFImYkulU77JlwfAM4G0ggS/NEmuD6cvVPSFO8JA6hUty4tp0eyoCIK6YyFHNkaY2KSS5sIvOuxzUy9y0thaUFAKMu7n7RNTTPosuFEck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SXqxaDvL; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SXqxaDvL" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-12c726f46baso732878c88.1 for ; Wed, 29 Apr 2026 21:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777521924; x=1778126724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kL/durcApuyyvG/J8kYo2FRmpv1/5uzdjUy9U58qkLw=; b=SXqxaDvLLwrLmCAsAdSmWSXiMhIoGEB/AoTNtn6RyPN5JZuR/u3O5epvESfeo0eqAp GJtmXMgt6D2YeP+FpS/hy9zEc3z+FDNoU5VpksEg8gcgr+1wla7Ta/47xyaloBYKg2K/ IyJX0UZY49mnFqHMb1R0h3Hnsvmz8M25KHn6r2b5IOqpLZwUc4E+6vfW2mdOzXVlmcFL xPn5r1KqMoIb+3kC7KJWfZ+RYQFdRARqjS3tqJ5J35zS212vTiDxKyPWMRCOivdGFthN sYU8cWhW8/H0qjr8V5MI/WQNyXrrIqHFSmPyyd+e0qjuA2LzmoWbsy1sTLsWgcxgcRVP bUWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777521924; x=1778126724; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kL/durcApuyyvG/J8kYo2FRmpv1/5uzdjUy9U58qkLw=; b=V0vzfop/Wr+UmHw1/R8LKqpOS5G23ThbEV6QyUff24RiKuofegUooxH6tHiPyi/b2I 4EMHSFyYiiZPDsgK9vkN2xLG2yf4P73MpzfNSVeRkcE9yDJDoXFMLmzbUaE21NkYKMfi 2/t9zhH1BPYsiH73rLTmVT4s3kCLcgvhNmM88LIJ6U+FChs9Rnb2jL4c1JPmpsu88iZd JdUDZb+rq2rCnhpn946H4DxcziEIcIsQY48gjPPlgs0sEJx7eXrbg6RNS3JzNBHawM2f gaOPKpo4UUgQbJeBlaSiNFQ4qPJN0GO7xlQcC6cKeeHKEFl9gaKA2Hi6DhQGTCUMRfBC Hh5Q== X-Forwarded-Encrypted: i=1; AFNElJ+PDTrwgMYWujEnEZSRlLz8TJvjTN6y3zK0Vqdaz6Mz/N++zXGlfzaIlK9hOew+cazR3WNhKPKhSZiD8Tc=@vger.kernel.org X-Gm-Message-State: AOJu0YyP0OzSgVubov9GMpdSSM05jyrIfoK5brLThWljH1e8RTC9eYPC /Pxr1fqpC06VWrObKthMjRnUnnlU4VR5K66cPo//u5wgtr4SuB5XE0pqMPWCfyHR X-Gm-Gg: AeBDievhk44uuCX5UW3TTgfMWF6OZW9oW0z52/Mfe+0njcrquOHTFTCn9w4KWyDyA4B iYwE0cIbxsb7BERqtqWVpW1VmEii9/RDdgC442AKkfUX7DXXCuUraHOEXFviYmMTV8E02i07rtq rh6b7RG3k8iYGfkl6PDEZexdbhuErtZQ5QJRQV1dhgXKFmYo9+yX5CIDRjJU5ehugIKkDOZqRxK lFT7jZ+A5U8s3kUnL5HRttiy2/PbmCD7qlIU+OQ7YT6vH5IPf5HKHLJ9UKIY7dpvvEfXVbpyw3Z mk8g2OS3IBehBtfw9fxi9gLOnhHE2/vIt5p4oztq0Kqh9HnsEBUmdcDE+00Hcg3uV/7TNNYI9rQ YlxYhkCLKXnmkQeIwppIkHMx+a//5TNpLm51dIC9IVI4lNw+Oo6SE8+trQnG2lyz0a9rHUlakmJ GBwZpPwKVBkwh2gkiSnzZXNGuGpyYqugg9AWV5 X-Received: by 2002:a05:7300:fd03:b0:2ed:27a3:eae3 with SMTP id 5a478bee46e88-2ed3dea5710mr479771eec.26.1777521923549; Wed, 29 Apr 2026 21:05:23 -0700 (PDT) Received: from soyboi ([2402:8780:1073:993:9321:304a:9347:5e0e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ed1c0e9a89sm7474669eec.31.2026.04.29.21.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 21:05:23 -0700 (PDT) From: Robertus Diawan Chris To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH] Bluetooth: btintel_pcie: Remove unused ret in btintel_pcie_submit_rx_work() Date: Thu, 30 Apr 2026 11:05:18 +0700 Message-ID: <20260430040518.163212-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable ret assigned to -EINVAL, however, this value is never read and re-assigned a new value when the code jumps to label resubmit. The assignment is redundant and can be removed. This is reported by Coverity Scan with CID 1598882 as UNUSED_VALUE. Signed-off-by: Robertus Diawan Chris --- drivers/bluetooth/btintel_pcie.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c index 2f59c0d6f9ec..ac4f5b45a6af 100644 --- a/drivers/bluetooth/btintel_pcie.c +++ b/drivers/bluetooth/btintel_pcie.c @@ -1376,10 +1376,8 @@ static int btintel_pcie_submit_rx_work(struct btintel_pcie_data *data, u8 status rfh_hdr = buf; len = rfh_hdr->packet_len; - if (len <= 0) { - ret = -EINVAL; + if (len <= 0) goto resubmit; - } /* Remove RFH header */ buf += sizeof(*rfh_hdr); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 -- 2.54.0