From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51B5823AB88 for ; Thu, 30 Apr 2026 10:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777545537; cv=none; b=KGgG7SftdI4zdbZrA63w9QxNcVmM0gP5x71I2S4QG5MhTTJRHFk55V9quvFAmQh9iir52isgv5BgSYMWpAekljnffmO6nTAw9vhNzVuGVzmJ5qo7r1OCX6fd5xI30Bv7Ba5BvAwtHes6L7t4+DUn3eiZjbbP6m7PxtMvFwJNZhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777545537; c=relaxed/simple; bh=edj1vQfHdZh/dQCJki2Vkoqqtj1Bq5iFNVI6Sude1PA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CtICssrgC9YVVLLyAFvXKxIPREsbwWzVBQwHJNF4QOUIqqnHW6Zumh+ILntukOtMVDG2gzzOeDSogI6tQzPN7Bdz5hpp13812FDy9WH6eAnNlpTWwsKn9nAhz1yDhetALuLzEUen0NDKDvoX4SkyGDR3QNdPNgP6ghHpf2HqXYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Z/cGE1WT; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Z/cGE1WT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1777545534; bh=edj1vQfHdZh/dQCJki2Vkoqqtj1Bq5iFNVI6Sude1PA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z/cGE1WTHHtI8p3dsjKI7Mym9K89i06+i2hYEg0BfiwExnImG/3QF1V0IWqEcCDoE JZVvb9lic+0VNCg1yXoW3oetDymeI0ppwQWfGNUSOXcM68GgCljdrsYU5de2iGzb7h 6D1Cd6rvz517UW8MH9R+xb1ckTfsetUapEv0t0mgnnZnFNEn5inyGP1dm5Nf1DwwIK BYINQGB+54+h+FvFKZYFOrhXNvSeJhAjv65U15f6WRkqe/rtOWET3cAgAYdt13wvmW mAyJNH7o9s7JDtiaEsXRdFyJLEMZEMFoPgwp+4kLC04TVOGieWbu532y6yI2D9BQ8p /Mb6ZzKwBcObA== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 18A7D17E0610; Thu, 30 Apr 2026 12:38:54 +0200 (CEST) Date: Thu, 30 Apr 2026 12:38:49 +0200 From: Boris Brezillon To: Karunika Choo Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/10] drm/panthor: Replace the panthor_irq macro machinery by inline helpers Message-ID: <20260430123849.2a9cefa8@fedora> In-Reply-To: <5d6f4531-7359-4d58-9c00-4d6bbc4b739a@arm.com> References: <20260429-panthor-signal-from-irq-v1-0-4b92ae4142d2@collabora.com> <20260429-panthor-signal-from-irq-v1-3-4b92ae4142d2@collabora.com> <5d6f4531-7359-4d58-9c00-4d6bbc4b739a@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Apr 2026 10:40:32 +0100 Karunika Choo wrote: > > + > > +static irqreturn_t panthor_job_irq_threaded_handler(int irq, void *data) > > +{ > > + return panthor_irq_default_threaded_handler(data, panthor_job_irq_handler); > > +} > > > > Hello, > > Maybe we can consider embedding the slow_handler into struct panthor_irq? > You can then always use a default threaded IRQ handler here and call > pirq->slow_handler when needed. The idea here was that the compiler can basically inline panthor_irq_default_threaded_handler() and turn panthor_job_irq_handler() into a direct call. If we make it a true function pointer stored in panthor_irq level this optimization can't happen.