From: Tycho Andersen <tycho@kernel.org>
To: Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Sean Christopherson <seanjc@google.com>,
Kim Phillips <kim.phillips@amd.com>,
Alexey Kardashevskiy <aik@amd.com>,
"Tycho Andersen (AMD)" <tycho@kernel.org>,
Nikunj A Dadhania <nikunj@amd.com>,
"Pratik R. Sampat" <prsampat@amd.com>,
Michael Roth <michael.roth@amd.com>
Subject: [RFC v1 5/6] crypto/ccp: Register with fw_uploader and always fail
Date: Thu, 30 Apr 2026 10:07:15 -0600 [thread overview]
Message-ID: <20260430160716.1120553-6-tycho@kernel.org> (raw)
In-Reply-To: <20260430160716.1120553-1-tycho@kernel.org>
From: "Tycho Andersen (AMD)" <tycho@kernel.org>
In preparation for SNP live firmware downloading support, add an 'sev'
firmware loader that always fails with EBUSY.
Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
---
drivers/crypto/ccp/sev-dev.c | 51 ++++++++++++++++++++++++++++++++++++
drivers/crypto/ccp/sev-dev.h | 3 +++
2 files changed, 54 insertions(+)
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 2df621b9f6e2..b4711bf823e8 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -2040,6 +2040,53 @@ static int sev_update_firmware(struct device *dev)
return ret;
}
+static enum fw_upload_err sev_fw_upload_prepare(struct fw_upload *fw_upload,
+ const u8 *data, u32 size)
+{
+ return FW_UPLOAD_ERR_NONE;
+}
+
+static enum fw_upload_err sev_fw_upload_write(struct fw_upload *fw_upload,
+ const u8 *data, u32 offset,
+ u32 size, u32 *written)
+{
+ return FW_UPLOAD_ERR_BUSY;
+}
+
+static enum fw_upload_err sev_fw_upload_poll_complete(struct fw_upload *fw_upload)
+{
+ return FW_UPLOAD_ERR_NONE;
+}
+
+static void sev_fw_upload_cancel(struct fw_upload *fw_upload)
+{
+ /* intentional no-op */
+}
+
+static const struct fw_upload_ops sev_fw_upload_ops = {
+ .prepare = sev_fw_upload_prepare,
+ .write = sev_fw_upload_write,
+ .poll_complete = sev_fw_upload_poll_complete,
+ .cancel = sev_fw_upload_cancel,
+};
+
+static void register_sev_fw_uploader(struct sev_device *sev)
+{
+ struct fw_upload *fwl;
+
+ if (!IS_ENABLED(CONFIG_FW_UPLOAD))
+ return;
+
+ fwl = firmware_upload_register(THIS_MODULE, sev->dev, "sev",
+ &sev_fw_upload_ops, sev);
+ if (IS_ERR(fwl)) {
+ dev_err(sev->dev, "SEV firmware upload registration failure: %ld\n", PTR_ERR(fwl));
+ return;
+ }
+
+ sev->fwl = fwl;
+}
+
static int __sev_snp_shutdown_locked(int *error, bool panic)
{
struct psp_device *psp = psp_master;
@@ -2953,6 +3000,7 @@ void sev_pci_init(void)
api_major, api_minor, build,
sev->api_major, sev->api_minor, sev->build);
+ register_sev_fw_uploader(sev);
return;
err:
@@ -2969,4 +3017,7 @@ void sev_pci_exit(void)
return;
sev_firmware_shutdown(sev);
+
+ if (sev->fwl)
+ firmware_upload_unregister(sev->fwl);
}
diff --git a/drivers/crypto/ccp/sev-dev.h b/drivers/crypto/ccp/sev-dev.h
index b1cd556bbbf6..2f5781cb7bb1 100644
--- a/drivers/crypto/ccp/sev-dev.h
+++ b/drivers/crypto/ccp/sev-dev.h
@@ -24,6 +24,7 @@
#include <linux/psp-sev.h>
#include <linux/miscdevice.h>
#include <linux/capability.h>
+#include <linux/firmware.h>
#define SEV_CMDRESP_CMD GENMASK(26, 16)
#define SEV_CMD_COMPLETE BIT(1)
@@ -66,6 +67,8 @@ struct sev_device {
struct tsm_dev *tsmdev;
struct sev_tio_status *tio_status;
+
+ struct fw_upload *fwl;
};
int sev_dev_init(struct psp_device *psp);
--
2.54.0
next prev parent reply other threads:[~2026-04-30 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 16:07 [RFC v1 0/6] Implement SNP DOWNLOAD_FIRMWARE_EX support Tycho Andersen
2026-04-30 16:07 ` [RFC v1 1/6] crypto/ccp: Hoist kernel part of SNP_PLATFORM_STATUS Tycho Andersen
2026-04-30 16:07 ` [RFC v1 2/6] crypto/ccp: Allow snp_get_platform_data() after SNP init Tycho Andersen
2026-04-30 16:07 ` [RFC v1 3/6] crypto/ccp: Add DOWNLOAD_FIRMWARE_EX message struct Tycho Andersen
2026-04-30 16:07 ` [RFC v1 4/6] crypto/ccp: Reclaim command buffer when the PSP dies Tycho Andersen
2026-04-30 16:07 ` Tycho Andersen [this message]
2026-04-30 16:07 ` [RFC v1 6/6] crypto/ccp: Implement SNP firmware live update Tycho Andersen
2026-05-03 3:18 ` Maxwell Doose
2026-05-03 3:25 ` Maxwell Doose
2026-05-04 13:57 ` Tycho Andersen
2026-05-04 18:43 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430160716.1120553-6-tycho@kernel.org \
--to=tycho@kernel.org \
--cc=aik@amd.com \
--cc=ashish.kalra@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=kim.phillips@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=nikunj@amd.com \
--cc=prsampat@amd.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox