public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: wit_yuan <yuanzhaoming901030@126.com>, jk@codeconstruct.com.au
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	yuanzhaoming901030@126.com, yuanzm2@lenovo.com,
	matt@codeconstruct.com.au, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net:mctp: split mctp hdr version to ver and rsvd
Date: Thu, 30 Apr 2026 18:04:13 +0800	[thread overview]
Message-ID: <202604301714.OQSuNMur-lkp@intel.com> (raw)
In-Reply-To: <20260409125129.9210-1-yuanzhaoming901030@126.com>

Hi wit_yuan,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v7.1-rc1 next-20260429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/wit_yuan/net-mctp-split-mctp-hdr-version-to-ver-and-rsvd/20260414-044431
base:   linus/master
patch link:    https://lore.kernel.org/r/20260409125129.9210-1-yuanzhaoming901030%40126.com
patch subject: [PATCH] net:mctp: split mctp hdr version to ver and rsvd
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260430/202604301714.OQSuNMur-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260430/202604301714.OQSuNMur-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604301714.OQSuNMur-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from net/mctp/route.c:1793:
>> net/mctp/test/route-test.c:70:3: error: invalid application of 'typeof' to bit-field
                   KUNIT_EXPECT_EQ(test, hdr2->ver, hdr.ver);
                   ^
   include/kunit/test.h:1033:2: note: expanded from macro 'KUNIT_EXPECT_EQ'
           KUNIT_EXPECT_EQ_MSG(test, left, right, NULL)
           ^
   include/kunit/test.h:1036:2: note: expanded from macro 'KUNIT_EXPECT_EQ_MSG'
           KUNIT_BINARY_INT_ASSERTION(test,                                       \
           ^
   include/kunit/test.h:869:2: note: expanded from macro 'KUNIT_BINARY_INT_ASSERTION'
           KUNIT_BASE_BINARY_ASSERTION(test,                                      \
           ^
   include/kunit/test.h:839:14: note: expanded from macro 'KUNIT_BASE_BINARY_ASSERTION'
           const typeof(left) __left = (left);                                    \
                       ^
   In file included from net/mctp/route.c:1793:
>> net/mctp/test/route-test.c:70:3: error: invalid application of 'typeof' to bit-field
   include/kunit/test.h:1033:2: note: expanded from macro 'KUNIT_EXPECT_EQ'
           KUNIT_EXPECT_EQ_MSG(test, left, right, NULL)
           ^
   include/kunit/test.h:1036:2: note: expanded from macro 'KUNIT_EXPECT_EQ_MSG'
           KUNIT_BINARY_INT_ASSERTION(test,                                       \
           ^
   include/kunit/test.h:869:2: note: expanded from macro 'KUNIT_BINARY_INT_ASSERTION'
           KUNIT_BASE_BINARY_ASSERTION(test,                                      \
           ^
   include/kunit/test.h:840:14: note: expanded from macro 'KUNIT_BASE_BINARY_ASSERTION'
           const typeof(right) __right = (right);                                 \
                       ^
   2 errors generated.


vim +/typeof +70 net/mctp/test/route-test.c

161eba50e183ed4 Jeremy Kerr 2021-10-03   19  
161eba50e183ed4 Jeremy Kerr 2021-10-03   20  static void mctp_test_fragment(struct kunit *test)
161eba50e183ed4 Jeremy Kerr 2021-10-03   21  {
161eba50e183ed4 Jeremy Kerr 2021-10-03   22  	const struct mctp_frag_test *params;
161eba50e183ed4 Jeremy Kerr 2021-10-03   23  	int rc, i, n, mtu, msgsize;
269936db5eb3962 Jeremy Kerr 2025-07-02   24  	struct mctp_test_dev *dev;
269936db5eb3962 Jeremy Kerr 2025-07-02   25  	struct mctp_dst dst;
161eba50e183ed4 Jeremy Kerr 2021-10-03   26  	struct sk_buff *skb;
161eba50e183ed4 Jeremy Kerr 2021-10-03   27  	struct mctp_hdr hdr;
161eba50e183ed4 Jeremy Kerr 2021-10-03   28  	u8 seq;
161eba50e183ed4 Jeremy Kerr 2021-10-03   29  
161eba50e183ed4 Jeremy Kerr 2021-10-03   30  	params = test->param_value;
161eba50e183ed4 Jeremy Kerr 2021-10-03   31  	mtu = params->mtu;
161eba50e183ed4 Jeremy Kerr 2021-10-03   32  	msgsize = params->msgsize;
161eba50e183ed4 Jeremy Kerr 2021-10-03   33  
161eba50e183ed4 Jeremy Kerr 2021-10-03   34  	hdr.ver = 1;
161eba50e183ed4 Jeremy Kerr 2021-10-03   35  	hdr.src = 8;
161eba50e183ed4 Jeremy Kerr 2021-10-03   36  	hdr.dest = 10;
161eba50e183ed4 Jeremy Kerr 2021-10-03   37  	hdr.flags_seq_tag = MCTP_HDR_FLAG_TO;
161eba50e183ed4 Jeremy Kerr 2021-10-03   38  
161eba50e183ed4 Jeremy Kerr 2021-10-03   39  	skb = mctp_test_create_skb(&hdr, msgsize);
161eba50e183ed4 Jeremy Kerr 2021-10-03   40  	KUNIT_ASSERT_TRUE(test, skb);
161eba50e183ed4 Jeremy Kerr 2021-10-03   41  
269936db5eb3962 Jeremy Kerr 2025-07-02   42  	dev = mctp_test_create_dev();
269936db5eb3962 Jeremy Kerr 2025-07-02   43  	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
269936db5eb3962 Jeremy Kerr 2025-07-02   44  
6ab578739a4c1f5 Jeremy Kerr 2025-11-26   45  	mctp_test_dst_setup(test, &dst, dev, mtu);
161eba50e183ed4 Jeremy Kerr 2021-10-03   46  
269936db5eb3962 Jeremy Kerr 2025-07-02   47  	rc = mctp_do_fragment_route(&dst, skb, mtu, MCTP_TAG_OWNER);
161eba50e183ed4 Jeremy Kerr 2021-10-03   48  	KUNIT_EXPECT_FALSE(test, rc);
161eba50e183ed4 Jeremy Kerr 2021-10-03   49  
6ab578739a4c1f5 Jeremy Kerr 2025-11-26   50  	n = dev->pkts.qlen;
161eba50e183ed4 Jeremy Kerr 2021-10-03   51  	KUNIT_EXPECT_EQ(test, n, params->n_frags);
161eba50e183ed4 Jeremy Kerr 2021-10-03   52  
161eba50e183ed4 Jeremy Kerr 2021-10-03   53  	for (i = 0;; i++) {
161eba50e183ed4 Jeremy Kerr 2021-10-03   54  		struct mctp_hdr *hdr2;
161eba50e183ed4 Jeremy Kerr 2021-10-03   55  		struct sk_buff *skb2;
161eba50e183ed4 Jeremy Kerr 2021-10-03   56  		u8 tag_mask, seq2;
161eba50e183ed4 Jeremy Kerr 2021-10-03   57  		bool first, last;
161eba50e183ed4 Jeremy Kerr 2021-10-03   58  
161eba50e183ed4 Jeremy Kerr 2021-10-03   59  		first = i == 0;
161eba50e183ed4 Jeremy Kerr 2021-10-03   60  		last = i == (n - 1);
161eba50e183ed4 Jeremy Kerr 2021-10-03   61  
6ab578739a4c1f5 Jeremy Kerr 2025-11-26   62  		skb2 = skb_dequeue(&dev->pkts);
161eba50e183ed4 Jeremy Kerr 2021-10-03   63  		if (!skb2)
161eba50e183ed4 Jeremy Kerr 2021-10-03   64  			break;
161eba50e183ed4 Jeremy Kerr 2021-10-03   65  
161eba50e183ed4 Jeremy Kerr 2021-10-03   66  		hdr2 = mctp_hdr(skb2);
161eba50e183ed4 Jeremy Kerr 2021-10-03   67  
161eba50e183ed4 Jeremy Kerr 2021-10-03   68  		tag_mask = MCTP_HDR_TAG_MASK | MCTP_HDR_FLAG_TO;
161eba50e183ed4 Jeremy Kerr 2021-10-03   69  
161eba50e183ed4 Jeremy Kerr 2021-10-03  @70  		KUNIT_EXPECT_EQ(test, hdr2->ver, hdr.ver);
161eba50e183ed4 Jeremy Kerr 2021-10-03   71  		KUNIT_EXPECT_EQ(test, hdr2->src, hdr.src);
161eba50e183ed4 Jeremy Kerr 2021-10-03   72  		KUNIT_EXPECT_EQ(test, hdr2->dest, hdr.dest);
161eba50e183ed4 Jeremy Kerr 2021-10-03   73  		KUNIT_EXPECT_EQ(test, hdr2->flags_seq_tag & tag_mask,
161eba50e183ed4 Jeremy Kerr 2021-10-03   74  				hdr.flags_seq_tag & tag_mask);
161eba50e183ed4 Jeremy Kerr 2021-10-03   75  
161eba50e183ed4 Jeremy Kerr 2021-10-03   76  		KUNIT_EXPECT_EQ(test,
161eba50e183ed4 Jeremy Kerr 2021-10-03   77  				!!(hdr2->flags_seq_tag & MCTP_HDR_FLAG_SOM), first);
161eba50e183ed4 Jeremy Kerr 2021-10-03   78  		KUNIT_EXPECT_EQ(test,
161eba50e183ed4 Jeremy Kerr 2021-10-03   79  				!!(hdr2->flags_seq_tag & MCTP_HDR_FLAG_EOM), last);
161eba50e183ed4 Jeremy Kerr 2021-10-03   80  
161eba50e183ed4 Jeremy Kerr 2021-10-03   81  		seq2 = (hdr2->flags_seq_tag >> MCTP_HDR_SEQ_SHIFT) &
161eba50e183ed4 Jeremy Kerr 2021-10-03   82  			MCTP_HDR_SEQ_MASK;
161eba50e183ed4 Jeremy Kerr 2021-10-03   83  
161eba50e183ed4 Jeremy Kerr 2021-10-03   84  		if (first) {
161eba50e183ed4 Jeremy Kerr 2021-10-03   85  			seq = seq2;
161eba50e183ed4 Jeremy Kerr 2021-10-03   86  		} else {
161eba50e183ed4 Jeremy Kerr 2021-10-03   87  			seq++;
161eba50e183ed4 Jeremy Kerr 2021-10-03   88  			KUNIT_EXPECT_EQ(test, seq2, seq & MCTP_HDR_SEQ_MASK);
161eba50e183ed4 Jeremy Kerr 2021-10-03   89  		}
161eba50e183ed4 Jeremy Kerr 2021-10-03   90  
161eba50e183ed4 Jeremy Kerr 2021-10-03   91  		if (!last)
161eba50e183ed4 Jeremy Kerr 2021-10-03   92  			KUNIT_EXPECT_EQ(test, skb2->len, mtu);
161eba50e183ed4 Jeremy Kerr 2021-10-03   93  		else
161eba50e183ed4 Jeremy Kerr 2021-10-03   94  			KUNIT_EXPECT_LE(test, skb2->len, mtu);
161eba50e183ed4 Jeremy Kerr 2021-10-03   95  
161eba50e183ed4 Jeremy Kerr 2021-10-03   96  		kfree_skb(skb2);
161eba50e183ed4 Jeremy Kerr 2021-10-03   97  	}
161eba50e183ed4 Jeremy Kerr 2021-10-03   98  
6ab578739a4c1f5 Jeremy Kerr 2025-11-26   99  	mctp_dst_release(&dst);
269936db5eb3962 Jeremy Kerr 2025-07-02  100  	mctp_test_destroy_dev(dev);
161eba50e183ed4 Jeremy Kerr 2021-10-03  101  }
161eba50e183ed4 Jeremy Kerr 2021-10-03  102  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2026-04-30 10:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 12:51 [PATCH] net:mctp: split mctp hdr version to ver and rsvd wit_yuan
2026-04-10  0:13 ` Jeremy Kerr
2026-04-10  6:17   ` wit_yuan
2026-04-10  6:17     ` [PATCH next-next v2] net:mctp: fix setting mctp hdr ver reserved field cause data dropped wit_yuan
2026-04-10  7:05       ` Jeremy Kerr
2026-04-29 22:40 ` [PATCH] net:mctp: split mctp hdr version to ver and rsvd kernel test robot
2026-04-30 10:04 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202604301714.OQSuNMur-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jk@codeconstruct.com.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=yuanzhaoming901030@126.com \
    --cc=yuanzm2@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox