From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f196.google.com (mail-yw1-f196.google.com [209.85.128.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A04232470A for ; Thu, 30 Apr 2026 17:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777570288; cv=none; b=teeYRoF90Wh+z/jzLDM/+hL0QSU8p/OQTSRyGXEqEOMSJFTISWBWcc2V/M3s4adIlN655yYNXITNeNd7WZSCJtp7nemTaRHYqHW+3k1GdACHEqOyEyihP7HVanslT18nC91k+xpnSxWtvd86ds4JUUCJmPHsUzDMVfvcSjonk6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777570288; c=relaxed/simple; bh=kT8WjgFzbTexEXPtbHhIR2nfSRA1FicUqaOCOvqjDds=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o2r0djKiWJ0120uaJ8aN36P3e3g4qsz1YQaIE0ce/a2TLnpxmeIGVvCBzrZl+jfvDzx210RF4OK7B8Chpo5GtbXfZQ2UfWjIg1+N+T6PNOwcWFujnL/nDD5B8vecR+BWUYtjVvDkA84msb4QbtGrVvmNB/x+3n1nGIUb2yVcGbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cqmoY2FL; arc=none smtp.client-ip=209.85.128.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cqmoY2FL" Received: by mail-yw1-f196.google.com with SMTP id 00721157ae682-7b4ee3a88e1so17534137b3.1 for ; Thu, 30 Apr 2026 10:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777570286; x=1778175086; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N/+4Wu+sU1O8P+03F6I8GHbXafqNDqKJAi0ynLG9Wx4=; b=cqmoY2FL/sTYnyzJPYfKeXhGwlFc0Zdt2HYcueGyhVl92ZjVG35JCCg6jh9bnipkdw aR7MEG+ZAvdT+hLhNEhwabipi3vEDdtlX6rnEdlpJ5DavkD4TuOx6Xc+y0J6j1zn56DI lRpUZibIKZlhn516vW3dVE7Vm9p9//AbkjZBP5Fd5P32gxaqemxDa6VUZNEDBwwmr3w9 /CHUtjRER95xL5X03NeAh0HkCbvu94hI+2IDQXUUeVULlnrn0oQQLBAYSCsKle07aRXg Oz/S8E+cfYN4wQKLaUMa3ta3I7ZuAOGf54p0DdslMr6dLnxfulEf7k2yBrkLpCr+Z2uI OyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777570286; x=1778175086; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N/+4Wu+sU1O8P+03F6I8GHbXafqNDqKJAi0ynLG9Wx4=; b=k283iMoXCVytLMgG3g+7G9HsXa+cq6PBn8HEro0m8TuU0BFcP3C/XENiBsqUw4Fs25 oEiOMtDr71uKKNHnBlTh0S9yjX2lLAfJcOx8ghi5K5LCbnoFLwJ5x2HIagoGsw/wjUbi Dri9qtu6MqPNRUmqtKtTmb4D5VeMaOtAw45tJBFTcCJ+fEObig3XNgC7Ns24MyeEHGGx 5bX+X1A2bdi/HgG0XnlXiFZQx93g9v7NbHTcZrrajCm3BQ1qO3GyrgoSuh+MPXS5CMUa YTHSWMyDBO8p7HjkGycCGT0THmagP/62iMNGJH3SLZU3pP8/+lGFB7US5VuodF79nSAl 7syw== X-Forwarded-Encrypted: i=1; AFNElJ9doLIGgzSwUQeXNMsR+UduVMJdk1RaT/VLlFKFjlX47lejWWA+gksbvYR0Cgst5tYn0OI1kiF9sXzUVyA=@vger.kernel.org X-Gm-Message-State: AOJu0YwpzE2VSXY1iCuOx+VALukTIiN6OoQ1Z4w6Jf0BAmYHiOm97hQH frSu4LnKzvfiPY6mt7SDCOghV5mU/CVimYLpuqgeLBtdE5JWYxyzEbYj X-Gm-Gg: AeBDiev2ESZXA7ywVTvlOI/XZDUavbkSHBkcKRWdoPFyzeqtRZjNA0Vu/gSJXuaH3Or GHupLtkls/cZzHSrTlCj2nUMRu+je20828TmzZhSCjXrHarPjQ7PW2BCiJ43t3Pjxn/YbEjTioU 5TJ7gX9Hf3NlD7CObaITfGJTHmz3PdNy8N9Fqhf2uUE6JDITyOQXDJStiT/8alDwwBoxf7mj/Qt gYeIdWStG7jYxQ4/8TxyC8squy3g0xmf52ycPUxCwoZKgrd4CC6309d8OdApP8KpJVpXC0xDScB TyCd8jvCLuA52ly7pBzNY76MY7mSG+o8b+FywDgYfjh1ILRciOw0Y2wwZIzatBY1R1SFMroaplz 3beFRLvSGTTCSrVxg63Xs3c5XsMFai5NCb7uszxEbT4bhm2IFHpwBgwlJpPAfc3YNXZsJNF8CdM LqyihyJ7YVf/1Y08LazL7H2kAqdnav+MEvDtel1iTgSn6Dpf2GoAPvaj5QEutzUO/ss10GY3aBr A== X-Received: by 2002:a05:690c:67c8:b0:79e:9cc1:ede3 with SMTP id 00721157ae682-7bd52825839mr41518467b3.2.1777570286417; Thu, 30 Apr 2026 10:31:26 -0700 (PDT) Received: from localhost ([2600:1700:3420:b5d0::b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd66888cc7sm68137b3.44.2026.04.30.10.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 10:31:25 -0700 (PDT) From: Bentley Blacketer To: gregkh@linuxfoundation.org Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Bentley Blacketer Subject: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name Date: Thu, 30 Apr 2026 13:30:45 -0400 Message-ID: <20260430173045.4619-1-sonionwhat@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed. Remove the FIXME comment and downgrade to dev_dbg as originally intended. Tested via code inspection only, as Project Ara hardware is no longer available. Signed-off-by: Bentley Blacketer Signed-off-by: Bentley Blacketer --- drivers/staging/greybus/bootrom.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c..058044ba7 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -163,18 +163,13 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) * * XXX Name it properly.. */ - snprintf(firmware_name, sizeof(firmware_name), +snprintf(firmware_name, sizeof(firmware_name), FW_NAME_PREFIX "%08x_%08x_%08x_%08x_s2l.tftf", intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id); - // FIXME: - // Turn to dev_dbg later after everyone has valid bootloaders with good - // ids, but leave this as dev_info for now to make it easier to track - // down "empty" vid/pid modules. - dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n", + dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n", firmware_name); - rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev); if (rc) { -- 2.54.0