From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f194.google.com (mail-yw1-f194.google.com [209.85.128.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1D79406297 for ; Thu, 30 Apr 2026 17:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777571685; cv=none; b=LzCrBe4XMXv0gitaO/pcOhCy28QfaOGYc2o1LOIVQ60n3hTE25Fk2EciSa6a+i/u96Zag922V+iTM2Sdg53wCAPuAZzsbCkbEZmf6jW9tSMc2WmPnC5yLgOms70RKGqES33uJe3PyEr9o+PBCdYJCMBrNgK2SmKmA313hUHWBKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777571685; c=relaxed/simple; bh=lzOKV1O/Glw/MWZw3ivd9kB27DNT2OB+FZ9DhMAdVMw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JGZtJj5ARpnl1XKpaQZq/k8lmEY4cQ22cXMedCgA3619I00kdykVp+2p1bia4RKwBJwLKIMiIK2IWio5onMKuCkJtI5TjquRXfJEi6z/QSfST6EOZnlVfmpxj3KFgmMiEALKELlu5mt3Pml9zf/lZ8Zh67pSvZpbZcFKByH2qK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l7M3HA+D; arc=none smtp.client-ip=209.85.128.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l7M3HA+D" Received: by mail-yw1-f194.google.com with SMTP id 00721157ae682-7bd5c582c6cso7245297b3.1 for ; Thu, 30 Apr 2026 10:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777571684; x=1778176484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y3dimdmnPw7p7h4vp2Fv8tAEKCuPapstxfNs8Fmggzg=; b=l7M3HA+DjWo4VwKinJYZLrM9fHkWKnrvB8ovqpTyaJ0SP5OoadclAOfOuV3L7Fuqrt qW82eaACV3ZfO/5IeMHiLw9I3jDaRhTCtCvaFxn+TV4KpPHodmGOGkrCi3W9FsduU5YU YvbesGhhM3sbFeHN5VNan1UoSO+TTqI9OOE7YtE3Ieeotn5TdAenfAb27rtHRuaIBJ+q vwCMJqHPwwIeGOnkS4bmth2KEtij98LYbIXqnnLtcW5guenE+lzFmBFEQ0p8jk2qsBUf y6vhXEYhAZoEwoUkgE0zLDi4dPBraNP5Uq/T28goh0MF++oz6XnfsEiARo3qtHXbR3ZV SRFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777571684; x=1778176484; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y3dimdmnPw7p7h4vp2Fv8tAEKCuPapstxfNs8Fmggzg=; b=lju/eKLFjulcBkGDZLxy2OITgGYoi+24MDhQjF+tywaRnGLROTOmweOts2puKfSifb pdQWTr5H26UBqNv52pM0DYev3y0zoFIkaGeuV1KRCXsFjsRc0hnMKbH3CXJYbBAUF6X8 +ija+MiJfweS0IcrMhsse0cmgPaXsws3mtXP86L6D7zTTjVjrE8HSHWbK78ZuuLRuy9j XCBvvpJXSqAp8V8/hWF3igqBxAAc9RnaC7tfcn5y5ALtmEp3Ca7NSwiBklPWMSCP1gZt h1i2ZoWyhhnWT3pOrIb71dBNAJ+3XyPb5PPu0dkk6AJzW+2EW0pw7L20RnkhM4Ik23TV +8tg== X-Forwarded-Encrypted: i=1; AFNElJ9Otu3eevUiJr1RMTnU7p7kgf6ic+E3FXJ85J20UITV2gDYqVnKNV/eiNDHmUYACLUvE/AGHIwG6l5wasQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwyIyragyW8LGjod05mYIPSuSYm8TEaSetGzvmOAE1A3h70xh/s X0UrkADcaboWKkzDuJJTe+KXMr4oxOmz/lRVEyrlS8o8lC82SO/1+qeq X-Gm-Gg: AeBDieviedTNruXE7so7veKltiG6XMhX7IgP9r4J/URvy8Z74th+EiMBabLzXstryRC jv8YgyGZRVHIqIMKwKXwNPAT9uIVspU3XDTT134uWOa0f8e56CegfeM5Ml8+t9YuZh5glF0WOCV AK9d0gOKV9quYu1VqCgAxDuiQM3DdIq3g49rlEVLyskmSsfXSjogbdPqpsmvN2lTxaDNWMH4UQX tfIS7JpDUpk/UbKlrIPPctrGzintiFrhYOjOATocEcDKOOavCYtbKuOAiR05xDPnNmVraHTHcld cuwmPbg0cVHEZtqsAPjoHV8gCCsXug30KAVR6ZhVh/ZclN2hXBKBdotGpBQ7dX88Mi3W1vwrVdS dD3QDM0vmFOSrMJ+i5NpubfxqWBnTewC/IlTgiPDmho4jPmqfL8xvO2JIU7e28RPWq0dPlwugAe qfi+ToGj/GAnIL9z6DVwu9ES6xzS1fvp3YwI3sW0aqJrgO9feAvkCVrKMIl0e7fkLayt4oaA5d2 g== X-Received: by 2002:a05:690c:97:b0:7bd:6129:f245 with SMTP id 00721157ae682-7bd6129f547mr15443587b3.14.1777571683712; Thu, 30 Apr 2026 10:54:43 -0700 (PDT) Received: from localhost ([2600:1700:3420:b5d0::b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd6686ead7sm327347b3.39.2026.04.30.10.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 10:54:43 -0700 (PDT) From: Bentley Blacketer To: gregkh@linuxfoundation.org Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Bentley Blacketer Subject: [PATCH v4] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name Date: Thu, 30 Apr 2026 13:54:36 -0400 Message-ID: <20260430175437.3699-1-sonionwhat@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed. Remove the FIXME comment and downgrade to dev_dbg as originally intended. Tested via code inspection only, as Project Ara hardware is no longer available. Signed-off-by: Bentley Blacketer --- Changes in v4: - Fixed duplicate Signed-off-by - Fixed missing tab on snprintf line Changes in v3: - Fixed author name mismatch Changes in v2: - Fixed whitespace issues - Moved testing note below --- line drivers/staging/greybus/bootrom.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c..9e0f24d6d 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -168,13 +168,8 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id); - // FIXME: - // Turn to dev_dbg later after everyone has valid bootloaders with good - // ids, but leave this as dev_info for now to make it easier to track - // down "empty" vid/pid modules. - dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n", + dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n", firmware_name); - rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev); if (rc) { -- 2.54.0