Re: [PATCH v4 02/11] PCI: liveupdate: Track outgoing preserved PCI devices

David Matlack
2026-04-27T18:57:21Z

On Mon, Apr 27, 2026 at 8:57 AM Jacob Pan <jacob.pan@linux.microsoft.com> wrote:

> > +int pci_liveupdate_preserve(struct pci_dev *dev)
> > +{
> > + struct pci_ser *ser;
> > + int i, ret;
> > +
> > + guard(mutex)(&pci_flb_outgoing_lock);
> > +
> > + ret = liveupdate_flb_get_outgoing(&pci_liveupdate_flb, (void
> > **)&ser);
> > + if (ret)
> > + return ret;
> > +
> > + if (!ser)
> > + return -ENOENT;
> > +
> > + if (dev->is_virtfn)
> > + return -EINVAL;
> This can be left outside the mutex?

Yes indeed. I will move it out in v5. Thanks!