From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69C4933F58E for ; Thu, 30 Apr 2026 19:50:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777578626; cv=none; b=V399x3q2HcXQ6m8p3lzOw7036JHubX/F9RFD95pscpHWIlmmx2ZJ+95zuDy/lG8UtdHzEB0SINql8YHNGGhf9lj3NJoWEuQibMfxFkgNOwxALeYutb6HDdUcLsycFW/BZkK/5p5ng0bNTO99y1B4NwvD9pYolLkIP6slgg2zvGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777578626; c=relaxed/simple; bh=lVj9l+0N1jtYsqvEBiLnFZ2/3v1EchPWkJh38hXrag4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EDpbr1HPdDdZ/VpEtWOkdUc9oXyEudN6BlRxW7HdjkMSJfDCwPE51SDZkI0e7LLDwEHjfotX+J8jnCX1y4tqPNC5ClBK/B72bNBS5DIqaOEaQwTFLiHT6kbE3HB0XQGqSpih9JnOK4JGxrXQuXb31YUZPXVt5yse7EaUzLJbtNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C5FavkWM; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C5FavkWM" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488ff90d6c7so12670985e9.2 for ; Thu, 30 Apr 2026 12:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777578624; x=1778183424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xV2RUgdcgAI6HubmbhhtbLRAwJ2b8LARLx9dBYFOMRs=; b=C5FavkWMYAKh0TWNMMWZDqV8Erp3ztkDV+Fb7wWNdiG52UXVulTg5d/qfCNRXYmP+z ihDj32IX37nWolccCfKK77FFjHtpkVMPo5ZmGubg3j6HqflIwnpEV9ZNYcHvxeZAc5+S L35o2dfB6urA2o/R3yaQT8hGfXlTMLbBYhNA3nlMG7CB/nKQ4KX5iD56mdYlioRDibpC 5rPozV+orgp6tU9DiwNc7DwRWoTA6z4QZA/lDH9CnjKtxN16hwaEf2w+CmZTdYvWTjGs mjCzSXEGCcioVT+jo/Fc9xuVd42FwwO9D+js9lMoqDsKd693l3OOeZwdUDK8NQvaJlnh tPnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777578624; x=1778183424; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xV2RUgdcgAI6HubmbhhtbLRAwJ2b8LARLx9dBYFOMRs=; b=Uw1m3WjY2jDnE6HQV752Acu8oDOeKEbU5G0pXcaSQUuxdsA7GyneP4YGRhIOSeAfLi 1UV/frogwsdU80pSa7Sh+4MTySTnfuHXrtJKzRYxWUa8FJEcK+jTjnkqhN3dZ5OD94PZ Jlw550ofZmre1BBgIZsRN/fw2SFbrT9bmKsb4Q8CON+EYdA74b9Ly9iZXosYXUgoCecy XaHCHku9Qe7EUEUVY9ucNW3B9n/lw/REOYuZ6eLqkQProe2POL1zODrZQhCIxSHLFFK3 3yuvdrHQwmF4TcSpphYCmV6/1C5vX0W+GzfVM7GdUlFDcT9rKlmFBCWPr0CeDciI5QsV B+tA== X-Forwarded-Encrypted: i=1; AFNElJ+g6HNFkmnD0fqlmgnkKZiXQQ7O3ABAe8LSartkaqlWcGv+GVeUEDbJCaXKYNr+7GLjHN9nAtJOwIrvz6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yycr38XtMd/P0oRlUJLbfJHRg29iTiMdjtyhAM7kN++uvHMLYGA mQ1ciKKBuH3aV9WdkJulM4HlPliRpq3sv6hHgz40fwjgpWs822+tVZAt X-Gm-Gg: AeBDies3slU21nO1cFrSLfgEIgb6ow9W7qCP12UAIG2qBNcTzql629gQuyUmfcmdddM YSixR2M4iiHnrMnJJf1nAoym5ZlOZYUQIebbUxtpZcZgXyx9CQoaJJ0JwxtYGbOYHx0ykS2+CXO 9XwoWijW20yzSTxyqk8GYNsE7/IUACtC6gfwm+bLg738P2xIPqtK9Q54ae+9BezMu9DF97YL9aa YRFHqBKUgLRYLjohnoSdmwYclge9PzipeeOXCmQxcaKLBbWTVcz8Ma1ZtsT/OkeBma2fkdntoS0 OQfUSvIfhDpFycRDzALa8mfFycynyJhnOKoUV7c4usaC9hLWTBbOtaXF/yGCJ1vsdyXyoe1fZXB Y6P/0w588BaJg7xYgqBIfgSf6Z5QJ/QcYBf3NALRYwf1RooRZHCkH8hs3ryukcu/LMCaLzjADFL 31HzJoMHZ4XWDYgcEPH/3DyL3nbE8zMpBbhoW/k9sSlkKuq2FvtKNVminA5hnFeqVXRD7hjmQ= X-Received: by 2002:a05:600c:a14:b0:486:f634:ef1 with SMTP id 5b1f17b1804b1-48a844525c5mr68630135e9.17.1777578623521; Thu, 30 Apr 2026 12:50:23 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:55a4:d495:8d6f:1416]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb75fc1sm3109615e9.7.2026.04.30.12.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 12:50:22 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Marek Vasut , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader , stable@vger.kernel.org Subject: [PATCH v4 1/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in i2c probe Date: Thu, 30 Apr 2026 21:49:42 +0200 Message-ID: <20260430194944.78119-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_drm_bridge_add() so the bridge is released if probe fails after registration, and drop drm_bridge_remove() in chipone_i2c_probe. Signed-off-by: Osama Abdelkader Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support") Cc: stable@vger.kernel.org --- v4: refresh the patch v3: split the patch into two, one for i2c probe (bugfix) and one for dsi probe, and add Fixes and Cc tags v2: devm_drm_bridge_add instead of drm_bridge_add --- drivers/gpu/drm/bridge/chipone-icn6211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 814713c5bea9..553a1df4688d 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -758,7 +758,9 @@ static int chipone_i2c_probe(struct i2c_client *client) dev_set_drvdata(dev, icn); i2c_set_clientdata(client, icn); - drm_bridge_add(&icn->bridge); + ret = devm_drm_bridge_add(dev, &icn->bridge); + if (ret) + return ret; return chipone_dsi_host_attach(icn); } -- 2.43.0