From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6F5A28851C for ; Thu, 30 Apr 2026 21:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777585441; cv=none; b=cuBOTliFh6xN8dcUUTUU1harVO1LXtWd2dGDx0QiIZzLd72YWGDigh5twGvC05/0F0/xjRjcxZMiAQ6f1Efl7riADZefuVV7UI0IemD/yf1/CC4dsAD3uu2HUNHrSJbvTJCQsK+EuvVDETF2lhEjyF6r/b1p3aiKatgJgxuS9Gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777585441; c=relaxed/simple; bh=M26zyhA5t24GPKGYCTGb/aogmGLpzeEa8q2aXPKEQas=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iT7MMADNFiJNNrQ35GtQbrCGOTInfw3vQ/FSKIiqlx8N7Gap7Qs5kXzfwqFLxDax4CoXXrYrMDGC71HHpS8cPHq9wrNgferAKWJ9WdxGPHIszBljYxIU/KXOxNlgKZ1tf7YsfDd1vlwgyCHZKDEQwwHLtLyN+pEarTB4xjlzwsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LVPiMVoy; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LVPiMVoy" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-362ddc1de56so894874a91.1 for ; Thu, 30 Apr 2026 14:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777585438; x=1778190238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XX7iQVHvtl0B67D8W3qVofrAFP/lX8Hl1A01uIMYbIQ=; b=LVPiMVoybTWmuGgEgSqt0ivJb+2mRKP3k03gQwKxTJRnNopjmpe2E8RQVzHYv2qJVK Kd0rOey3DIq95uR15GjkbYQQ5CLS174T4cRz4Ru8Kx4iXtUzz3HBT1HZH+vE7sQbZg/d xaSOcQffcZ6exgFjccxa6E38VwTx2PKOHe3L8iQVIy6lI3OCZzfT/b9hjBQvjEbXU2t0 NzdcDe51bpUVXf7C+zSV7CBs+7Iy1/Mkto2WAh4GY0wu9quryHXmmPz8er0kBKWtefay sLu0s88FptH6ihX0Vdi00Vy0onquvYhVyGuXa6MaOkqOPC2/m6G8eVwieq4kSaaT/LFX z5Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777585438; x=1778190238; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XX7iQVHvtl0B67D8W3qVofrAFP/lX8Hl1A01uIMYbIQ=; b=qzfBIIP1Jbmmt/XLGYuOkKXdg1QbGrSS7XEssmMDrRXWmo9XX8t9pz5u18fnfPNz49 rnPIrWZb3QQUuGD8GC5/3L0j6O4NKobGrB6NaVRwLsC96HFRMNV8KegWqUfydRvzqSMX zULi2+zjmvTk+Zblht0uzS1301GNlqgbLbp5gUf1kXtQKym11YQZekiQOQlhiWUEjbpR 5XSKvxBvl77GMu7xxSwjlK8bjXjHVDJ/IrqtU2xND8iYDzkryhngZXDxT8ec2Q7Duy53 CUEKeu4HxMUF/6RD0cUnYGdnXfEcadGyD1hDS0Drj6pR+T/8KmSBk3odGJON79m01rmJ Mi/A== X-Forwarded-Encrypted: i=1; AFNElJ8ma/6DYNm7PKOjsx+nq4z5BUs2rnHDNI7Nt1v9+rhgY8HMv7U2O64rsV4sRIiv+7RSFXuWjwWcvNVEnYM=@vger.kernel.org X-Gm-Message-State: AOJu0YxoidmJXQTMXxxZjPcLWV5qpcDOVxlQBRechct63V5laG5lNsDv ObooUxwEe8NfJv51PV+uB7cqxPaLmkhtScWSTZxXdLt5r+M0//cRqxHC X-Gm-Gg: AeBDiesfqQHoN6yBet1qyzWJcOA52sR9J4OpMCbnAQniAwKOJc4DyXt4yMRJiFNtL26 4hsHI5K/gBaEk62cdi2wQrmGOaK3kialkrHBP8MKU1ZN+BIAv+9KkBhP2SGLOE5sEaurLH9hgkK 1uIn4gn+/PTnSg397kR7PYMaPbXZqKP8J2XCHru+Ng2sqAiA/+iR48tx4kCBr17U6OXRLALjAYV Ue7c0eSXzeyRYnWwiGvRDISV4lohUY/7sHyn0nMxeMWwyTP1i/wTvbW0FTMehCgIRmZOrWI5vUN w14sNOEM/7xG30Un+bcHZAsK9KlC8FTWN8r+D6H0zyK9+zwo8QRwqz/CLhjCI6o1w9QW2N4bQoz M4Xnl7x90YaP9GYDpny9ahltY5MWl8WBMrLVWgzEB4//uO0mGxrGhl+jlDQdII8SOJFunx2pUEv GAMWwD2rve8/JAAtX9LgaGKUNs/rlzDFNHg1wfBSZxilUGqZdHC7E7eaaWjOmHdZK+ytJaZm9PA P/sdWr+fV/2FN/INrpLWRvvJQmlxWL/2xsrVqgzcmcTJA== X-Received: by 2002:a17:90b:5252:b0:35e:3e86:e2d1 with SMTP id 98e67ed59e1d1-364ef3a2290mr304651a91.7.1777585438238; Thu, 30 Apr 2026 14:43:58 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364bdf2a71bsm3945592a91.1.2026.04.30.14.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 14:43:57 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , Kees Cook , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org (open list), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCH] talitos: allocate channels with main struct Date: Thu, 30 Apr 2026 14:43:40 -0700 Message-ID: <20260430214340.59588-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use a flexible array member to combine allocations. Add __counted_by for extra runtime analysis. Signed-off-by: Rosen Penev --- drivers/crypto/talitos.c | 17 +++++------------ drivers/crypto/talitos.h | 5 +++-- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index bc61d0fe3514..98323c154031 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -3409,14 +3409,18 @@ static int talitos_probe(struct platform_device *ofdev) struct device *dev = &ofdev->dev; struct device_node *np = ofdev->dev.of_node; struct talitos_private *priv; + unsigned int num_channels; int i, err; int stride; struct resource *res; - priv = devm_kzalloc(dev, sizeof(struct talitos_private), GFP_KERNEL); + of_property_read_u32(np, "fsl,num-channels", &num_channels); + priv = devm_kzalloc(dev, struct_size(priv, chan, num_channels), GFP_KERNEL); if (!priv) return -ENOMEM; + priv->num_channels = num_channels; + INIT_LIST_HEAD(&priv->alg_list); dev_set_drvdata(dev, priv); @@ -3436,7 +3440,6 @@ static int talitos_probe(struct platform_device *ofdev) } /* get SEC version capabilities from device tree */ - of_property_read_u32(np, "fsl,num-channels", &priv->num_channels); of_property_read_u32(np, "fsl,channel-fifo-len", &priv->chfifo_len); of_property_read_u32(np, "fsl,exec-units-mask", &priv->exec_units); of_property_read_u32(np, "fsl,descriptor-types-mask", @@ -3511,16 +3514,6 @@ static int talitos_probe(struct platform_device *ofdev) } } - priv->chan = devm_kcalloc(dev, - priv->num_channels, - sizeof(struct talitos_channel), - GFP_KERNEL); - if (!priv->chan) { - dev_err(dev, "failed to allocate channel management space\n"); - err = -ENOMEM; - goto err_out; - } - priv->fifo_len = roundup_pow_of_two(priv->chfifo_len); for (i = 0; i < priv->num_channels; i++) { diff --git a/drivers/crypto/talitos.h b/drivers/crypto/talitos.h index 1a93ee355929..34b0b5fab7e7 100644 --- a/drivers/crypto/talitos.h +++ b/drivers/crypto/talitos.h @@ -139,8 +139,6 @@ struct talitos_private { */ unsigned int fifo_len; - struct talitos_channel *chan; - /* next channel to be assigned next incoming descriptor */ atomic_t last_chan ____cacheline_aligned; @@ -153,6 +151,9 @@ struct talitos_private { /* hwrng device */ struct hwrng rng; bool rng_registered; + + struct talitos_channel chan[] __counted_by(num_channels); + }; /* .features flag */ -- 2.54.0