From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD042DEA90 for ; Thu, 30 Apr 2026 21:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777583071; cv=none; b=jF0XX5TkwH2q4QAemqMaH8Kj5ByPMUskbkcmslCtGDPWCDUGIGis1gelk7nyvmjk5SyOCasOXAUhSXJr1TjBsXiZbCLRhEFyE6SBZSV1+B1ENpKxaSBkLgCaNTCrCxFda9HNdz6sIl9lwssDW7q2xMGNPIoCz02ET50oCHhb/Bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777583071; c=relaxed/simple; bh=AXaBC6uLtMLMx0KLblAysy0w4TxdkHZ2WrZg8Y0ErqE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eMMhe3hG0jYHlOPQowodI8zBJMH5xNqKG5WEyrLcup5E65zucDDUlpCSxgDU7wd6xyTQRI1gVTQ0CIF0aE4vgDLKFl1vaf9Oobh0702tTmxCgOqIx2HAkHSj9pDku/eY4daC1XQZMvONqOTK/yEBV0ZY3+FLDIu3XWc+nPFDeL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E39r32m+; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E39r32m+" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5a3be187ffbso2264407e87.0 for ; Thu, 30 Apr 2026 14:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777583068; x=1778187868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AXaBC6uLtMLMx0KLblAysy0w4TxdkHZ2WrZg8Y0ErqE=; b=E39r32m+mmKJTYFuiu0pH55I2RdKHBlWtpnQmfk/XT0OJPzB3/r8Plx84lfdZSa1HP Ql2kTX85gnfGWfH2mfIUEt4kkxn8UtDykl4e5Ul9VbGTIf5ljAsCt0NoOL/KK3qg+VYw yIRuL2M17WStxGi/iTnqCvoDrQThYbnQyon4RZe2oNkNhL5DC7e+Lt/sAywKO6f/8G6x 9smuCn8OyJbTmYyreZq4BZm2M/NXX9k6UYKeL/qQEytNhenCK0ImhVdvJZkirV1vA+xI PJDIpp+EpoIy6yYJz1JqIDtvWX/J7PJSTC7eeZfiAEJQm15NdeSupPlf4Iyr1zZCKmoq +DAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777583068; x=1778187868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AXaBC6uLtMLMx0KLblAysy0w4TxdkHZ2WrZg8Y0ErqE=; b=Q6PoK/4TNkCv6R1v0jE3fCKdDXNdzcGSMJuySTjQYZTtOhMAlTxKZsSfJWi8k/LOik Cm0D5S12G4eEcmLudqEEaLWMfX/7DZE913+FVTJuV4P3PDAQYQnY1hjU1G+XRmByhxxB i6vgckw9QNFiZBmMd9N/to7sqSy5gObRA1QKOOs+XzbMGQORf/oTd8HyK5KhcURZVHw8 MEWy3G7AyNpDw6NFjEQfpVkm5jqSh7lNoLgbdZEgN7P4+Q4MoSaWEfk4YDDnT6bIYT1L SH6G5LPwul2JCnDgPdOM1TAqlsAEMzlQcxF5yHkc/D2EU/FxtWc95oiAPxClYZfXQ0Bz Da4A== X-Forwarded-Encrypted: i=1; AFNElJ8lQBdKtQb1m2KnavLy6lBj0SKykI4dPjvBK4liXajOTFYqRrSv/UUOA+xp6IYsL6Xf+V38kVoH63HZI4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzWuwOHw2jGEFBVSAQxRg5wR4LoJWn7owoycVLTDviYMugYvC4P zNYERwaxCmBnsEH+hvF0wXizyq1x3UFWYKIuC657WAJdkFLkXMyq88Dx X-Gm-Gg: AeBDietJjnPLfZ22aQEc5wS9r512dTiJqVOXJVAoi4hflOxARmgtNCT/XTOSloJcutP PFLXsUc64Kq6AnFBbX7e5hx0RZEsrjZB1Hs2HGt9hucwXs1wHnsMhVtkrb5Z6Xst3XVU2GwKJrm jfVGMwu+DIs2diu+Gap9f43wp+npUs4mqU2Obkm+g6CZjB/1Jbp7u6A/GT6AxaeEPtypEJkFKv9 dQLtKxOcew5qNC350/dBvTM66aXeuDt9vyFCDOhGY2beK7q7vg9Yc9ImWxRdCjQwfsbg7vAjqcB 7JYpM+5ymq2A5fw96x95sT5OGbreysihCwME7FOtvQTb2VS98aeNpp0vxuOJ0936HB+1Uwt49Md SgvtXN4HXH9TTowm/MzqKjYBcaAmhO+85RPYdbSH8TzomgxER9v4uYCLCCiZYmdxhnsWnUOv/TT q0Nm7dPqxzkmanCU8UaMAD2w2C4MUO13i/ERyZLHB9q6U= X-Received: by 2002:a05:6512:3b2c:b0:5a3:e7f1:5946 with SMTP id 2adb3069b0e04-5a85272126cmr1431698e87.9.1777583067906; Thu, 30 Apr 2026 14:04:27 -0700 (PDT) Received: from foxbook (bfh75.neoplus.adsl.tpnet.pl. [83.28.45.75]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85af54d72sm38841e87.7.2026.04.30.14.04.25 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 30 Apr 2026 14:04:26 -0700 (PDT) Date: Thu, 30 Apr 2026 23:04:22 +0200 From: Michal Pecio To: "Heitor Alves de Siqueira" Cc: "Greg Kroah-Hartman" , , , , , Subject: Re: [PATCH v2] usb: usbtmc: reject invalid interrupt endpoints Message-ID: <20260430230300.5a67c1dd.michal.pecio@gmail.com> In-Reply-To: <20260430224849.3322afb0.michal.pecio@gmail.com> References: <20260423-usbtmc-iin-size-v2-1-31afa4874f71@igalia.com> <20260424002839.5ad25517.michal.pecio@gmail.com> <20260429001626.2f08b991.michal.pecio@gmail.com> <20260430224849.3322afb0.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Apr 2026 22:48:49 +0200, Michal Pecio wrote: > The only change to support USB488 devices with wMaxPacketSize == 1 > should be increasing URB size to at least 2 bytes. But I wouldn't > bother when no such HW is known to exist, and surely not as part of > a barely related bugfix patch. Correction: I noticed that USB488 spec Table 22 requires wMaxPacketSize to be exactly 0x02, unless the device sends vendor notifications. One could argue that 0x01 is covered by this exception, but that's obviously against the intent. So for bInterfaceProtocol 1 devices, requiring wMaxPacketSize >= 2 should be OK, but bInterfaceProtocol 0 devices are unclear. Regards, Michal