Re: [PATCH 1/4] dt-bindings: display: panel: Add Novatek NT37705

Conor Dooley
2026-05-01T15:51:11Z

[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]

On Fri, May 01, 2026 at 03:52:45PM +0200, Luca Weiss wrote:
> Novatek NT37705 is a display driver IC used to drive AMOLED DSI panels.
>
> Describe it and the panel in the Fairphone (Gen. 6) (BJ631JHM-T71-D900
> from BOE) using it.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> .../bindings/display/panel/novatek,nt37705.yaml | 72 ++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml
> new file mode 100644
> index 000000000000..1c796599f6fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt37705.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek,nt37705.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT37705-based DSI display panels
> +
> +maintainers:
> + - Luca Weiss <luca.weiss@fairphone.com>
> +
> +description:
> + The Novatek NT37705 is a generic DSI Panel IC used to control AMOLED panels.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + contains:
> + const: boe,bj631jhm-t71-d900

Compatible doesn't match the filename, nor does the commit message match
what you've got here. Sounds like you're missing a fallback to
$filename.

pw-bot: changes-requested

Cheers,
Conor.

> +
> + reg:
> + maxItems: 1
> +
> + vddio-supply:
> + description: I/O voltage rail
> +
> + dvdd-supply:
> + description: Digital voltage rail
> +
> + vci-supply:
> + description: Analog voltage rail
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - vddio-supply
> + - dvdd-supply
> + - vci-supply
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "boe,bj631jhm-t71-d900";
> + reg = <0>;
> +
> + reset-gpios = <&tlmm 12 GPIO_ACTIVE_LOW>;
> +
> + vci-supply = <&vreg_l19b>;
> + vddio-supply = <&vreg_l9b>;
> + dvdd-supply = <&vreg_oled_dvdd_1p2>;
> +
> + port {
> + panel_in_0: endpoint {
> + remote-endpoint = <&dsi0_out>;
> + };
> + };
> + };
> + };
> +
> +...
>
> --
> 2.54.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]