From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3BB018FC97 for ; Fri, 1 May 2026 02:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602943; cv=none; b=MPrGntCIwyglEGo5GUW5zx0qTS9aWyqHFsDgvxLE0A/LIkYQmsKFADBFFq01TzD1hBnDQy8b00NoK5JSiqQs3mPh9iTONyBZ+SS4Ipzo+viY2nfS80ufX0nF522bopa+gkHVq1H3xFXalxsoxBQUnMXBVUyMzRldhtvDt1z3AHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602943; c=relaxed/simple; bh=2y2/y0G4xKegMxAeB9N6LvOQxHely/EGyWUZnJ3S/bo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UkwyMA45JEEneKPoPdwGyAaHrKp/YR3WKn0Gmd2sZBbjP32QPo9tfx6vqdNdp/RY0lvTIXNHMk26RivgUl/y/j0LMJ4dapUfp/vxBiICwD4pebwU9WMXiX5ZJco+mUtvq9O6UQ8h3hxu+vYtPPn19eFHibb5jsWBnLcM79m6kPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ke8d60ap; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ke8d60ap" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2b4650d5f5cso6297615ad.0 for ; Thu, 30 Apr 2026 19:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777602938; x=1778207738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZxEZzG7nuqjedaY2huiV2Gx6afd+VeNrKDvHH9D11HM=; b=Ke8d60ap51WMEsIiQPLNw+VcH1P2f87agFuPn5puZl/zm3lG/A6KrBak/jXurdHn3X oNMEqDToJzxX8+nbZGYH7W7gWw7QruTpMyQWqJZ2w/BdAMGo2MaK4WOTHJzVEhyuChmz SoM7aTYRlI/yhS7sRejQc7q+fvqx6SlrnVWBOwI6SwGUjYu09uEuB7VnmvT//rj9+RA4 yeFe69bmXESXstuxF9DJ/bKvu99F3DItf9suwU2bn3CjRraG7jXdHq6iSWebtJpW1Ms8 eaQvT/Ym/sJNHVJ552Is9CXcXvMoWk6nxLsUFAtRu/F+RE1vuCau1XiIuXZnEvlTlwfS Fybg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777602938; x=1778207738; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZxEZzG7nuqjedaY2huiV2Gx6afd+VeNrKDvHH9D11HM=; b=IvNSEkwAPBS/ZR5vCmgHNgPeLSPSZboYYk78tXe83Hdq8y8/QTNDLgPwkoaTVHaJUU j4fo1rZsvmOk//SMDwMP8+y5r2Uwh7FJy5SLPU867uTqAO+GaFJF0Y5NXBliN0V5prlN TeoMQZBQmf4SpT4dJji3ZNXxB4xOTdDxTUUxZ43fdITX4zeK5DppqRiPnFENSTk4SQyE x3voXmjrqQL9qVMEEej4NtDK98IUdd4GzXUybwqD+NkdQfNV4X514n1ZEml5JPdaa7fA +7aMZcEohusLMATe8U2EVPx15k5RBWWln9wRv4gIZyxYW8Al9XZMvhuHKHOSJy6DivEF i80g== X-Forwarded-Encrypted: i=1; AFNElJ/JxmED8LaBJ+QtG9UHy8m34qsnKPyNDIMCyckssuEIRw5OWsBl6VINacXUmX3f+mw6d7uNv+KlVUtaaxw=@vger.kernel.org X-Gm-Message-State: AOJu0YxeBWlSyNdQbocoKbEjNmpLGygsTEQrFjZiicdKuwFirSWC+sOT a2vjawEwU0Yolud5PzGceDrPawlyI2yFlJZA9ZyaHUjaKu6mYG0JW15r X-Gm-Gg: AeBDiesAc3qdeCh0HO9qTJ2oLTQEbqneSdO0ZcTCa37KXv77R+2mC175WHneNm/q047 LiNHjqsDwgv9TT4pS5gxmmBY7sfkwgkITKVI1OhXlyAqkkd3KCOpLHRztZfMIqQZX8KqTGrpJJL evei8nJr8IZPKVaJ7iQ5+OiTkE0XW5PjXOYpFT6zOhE1qpkAq9nFSUoao+M9Fjulu6cN0bryp2L U3xl8glbynyl6XzpNBu+sw4P7/loHb9efinoNUwRQvpzwi1wUOy6khnniJOebC63awPoXwN9u7P gnO+F/ZcLvOC466VXKDjP+rPEHzVlk3sBInZCubXsczTb6aTEkxFnc87kiCbjlx+gWWpw0RaH8R ticmc2WcoyrnVL+Nt+NP8BCqY43/KDwkpsa4aJb/3TteHKnN4eIUU1FvRKc0ubVeworSq0wDs1i ZAzRDz65kNIX+4hXwraTljhXn7i4cE5d4Rq3tslj8Ted56lndOqddaoTsF4FcZaIGvi6IOMmNxT k3/c8aUJSd2UGGS X-Received: by 2002:a17:902:b48f:b0:2b2:5203:acd3 with SMTP id d9443c01a7336-2b9a24b8916mr39052195ad.26.1777602938124; Thu, 30 Apr 2026 19:35:38 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([116.72.73.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caa7e791sm9341385ad.7.2026.04.30.19.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 19:35:37 -0700 (PDT) From: Tabrez Ahmed To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed Subject: [PATCH v5 0/3] hwmon: (ads7871) Fix endianness and modernize driver Date: Fri, 1 May 2026 08:05:27 +0530 Message-ID: <20260501023530.31160-1-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series addresses several issues in the ads7871 driver. It fixes an architecture-dependent endianness bug in the 16-bit register read logic, migrates the driver to the modern hwmon_device_register_with_info() API, and moves the SPI transfer buffer into the driver's private data structure to ensure DMA safety. Note: I do not have access to the physical ADS7871 hardware. This series has been compile-tested only. Changes in v5: - Fixed a bisectability issue where the include modernization was accidentally squashed into Patch 3 instead of Patch 1. - Ensured the 1-byte SPI command write in ads7871_read_reg16() uses a strictly typed 'u8' variable to prevent a Big-Endian pointer hazard. Changes in v4: - Patch 1: Refactored 16-bit register reads to use a dedicated 'u8' transmit variable, eliminating a 32-bit pointer endianness hazard. Changes in v3: - Added Patch 1 to fix the pre-existing endianness bug in 16-bit reads. - Fixed multiple formatting and alignment issues caught by checkpatch --strict, as requested by Guenter Roeck. - Added "While at it, fix checkpatch violations" to Patch 2 commit message. Tabrez Ahmed (3): hwmon: (ads7871) Fix endianness bug in 16-bit register reads hwmon: (ads7871) Convert to hwmon_device_register_with_info hwmon: (ads7871) Use DMA-safe buffer for SPI writes drivers/hwmon/ads7871.c | 122 +++++++++++++++++++++++----------------- 1 file changed, 71 insertions(+), 51 deletions(-) -- 2.43.0