From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318553A4F5C
	for <linux-kernel@vger.kernel.org>; Fri,  1 May 2026 12:44:17 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1777639458; cv=none; b=q9TpSAUcBxsWfNd343M8cD4NMDa41bNwDs7tJU/lU1x1mioVXtrjJwBG/PYbzeS/LMWDTAALK+uGIvs/FBWCTFfVS8xAQ62BngQyVHGfyQsJeldDMcE6Ui0yr8KK/Bc892+S/X68jzU2L/bBsGG9JiGMi2Tz6VAGDhdGlbwPEIg=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1777639458; c=relaxed/simple;
	bh=xTzYlDIqwIv4dqw3qIFMC64OF2XOl9jQzRn9UnXJSNw=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=IetLHiMmeml9LWHW5qfQv+hpx18hQt/nkPBNPQ01nF7QnQDvBf/g1h5MbKZKhI7kdkxyo57yowjaIo04AveK/e3cJWAc2ZudloVuPT5L9XgBzUHzC7Xu9Ffo1kKQ3YDWUnVKA525RWCmdT+83nFRWfpCdYKujvSsVHo91zICd4Y=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=RjmgYGCa; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="RjmgYGCa"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A8ACC2BCB4;
	Fri,  1 May 2026 12:44:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1777639457;
	bh=xTzYlDIqwIv4dqw3qIFMC64OF2XOl9jQzRn9UnXJSNw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=RjmgYGCa7UyCJ7lx7/0EfhK/J16gKr8IRsSrwRPcnbaD0PR32D/q9aPfI79+dW5ZT
	 ulVSkAUGrvA4wE9sbWn4LJ5en3nhaP9ATzj+xJs2SRYlw/UTo32LN3yLmQjl0J7WzS
	 RetG4K4helpFwjzenIuCqTsW3wTwnlWRlkBUigi4=
Date: Fri, 1 May 2026 05:44:16 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Sunny Patel <nueralspacetech@gmail.com>
Cc: David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>, Matthew
 Brost <matthew.brost@intel.com>, Joshua Hahn <joshua.hahnjy@gmail.com>,
 Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>, Gregory
 Price <gourry@gourry.net>, Ying Huang <ying.huang@linux.alibaba.com>,
 Alistair Popple <apopple@nvidia.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, Balbir Singh <balbirs@nvidia.com>
Subject: Re: [PATCH v3] mm/migrate_device: fix pgtable leak in
 migrate_vma_insert_huge_pmd_page
Message-Id: <20260501054416.af0ed62d635c3eb01d425e61@linux-foundation.org>
In-Reply-To: <20260501115122.23288-1-nueralspacetech@gmail.com>
References: <20260501115122.23288-1-nueralspacetech@gmail.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri,  1 May 2026 17:21:16 +0530 Sunny Patel <nueralspacetech@gmail.com> wrote:

> When migrate_vma_insert_huge_pmd_page() jumps to unlock_abort due
> to a PMD check failure, the pgtable allocated earlier via
> pte_alloc_one() is never freed, causing a memory leak.
> 
> Added free_abort label to release the pgtable in error path.
> 
> ...
>
> --- a/mm/migrate_device.c
> +++ b/mm/migrate_device.c
> @@ -840,7 +840,7 @@ static int migrate_vma_insert_huge_pmd_page(struct migrate_vma *migrate,
>  	} else {
>  		if (folio_is_zone_device(folio) &&
>  		    !folio_is_device_coherent(folio)) {
> -			goto abort;
> +			goto free_abort;
>  		}
>  		entry = folio_mk_pmd(folio, vma->vm_page_prot);
>  		if (vma->vm_flags & VM_WRITE)
> @@ -893,6 +893,8 @@ static int migrate_vma_insert_huge_pmd_page(struct migrate_vma *migrate,
>  
>  unlock_abort:
>  	spin_unlock(ptl);
> +free_abort:
> +	pte_free(vma->vm_mm, pgtable);
>  abort:
>  	for (i = 0; i < HPAGE_PMD_NR; i++)
>  		src[i] &= ~MIGRATE_PFN_MIGRATE;

Yikes, we leak that page on several error paths.

Thanks, I'll retain David's ack from the v2 patch.

Balbir, please review?