From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5030A34FF74 for ; Fri, 1 May 2026 09:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777628977; cv=none; b=U5/VzF8m7fTpSfzDhwCaatpO7lJ2HTpp0KAZO/AWbTAcoynr6h8kGs/Aui8l/pX3u9RxvNyM7BH4vdWqLGxTUCeffhtqCZ3A4/NmFm1J6NN+01zQxsryrWd88GYuOMXkLIffQ3IR6/+eZHH6kBW69ypvmJcTNda0UdL3SlbxCy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777628977; c=relaxed/simple; bh=hhqamoszcDNnFzvHXcuW8hko1Ngi3U4ZaHT1aqRrmPs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ScHPgv8YnC9Za2Mip3tAF9y0eK7l0EVYWOZXDI10fcl7W7oydl2dbHirMd/N27xFW39DHUbYda2ku/xrgaP7F/iK+G1kIgk/VmaUNvvm0gY9Jp2SG3zhEIznaS18CBPW+80NJFagCDEUYvFZoFLNGQUVsb4nfrShjMFYc2G7Rxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qM6GQIth; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qM6GQIth" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82f33d28c1dso1033274b3a.3 for ; Fri, 01 May 2026 02:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777628974; x=1778233774; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cQtRFGksInkULS0m8GB/jr8IDzzr0ObA1EgynOw28RQ=; b=qM6GQIthMAvhVRzKSh149tfNGDS1d8jguXr4Fx4H+AqsSC/5qWv5vfBoHkqqCChXru LedBJEShKu43gTmH8oxr95EmMAxgEWQXvvuKB3CcOHwbts15Ukb2FUvUQPgVXek3ImLM jUXrkmopyrnHsElCh9p4KgA4IjrMGyBgBRhJeQsVs0U4Nw6HDKsNw7+jPvXesmfbRcAu ihGnjuuUp1adejnbsBXZCcZUN4VYvmeII51b4xgUz0d3uk7W+dUMnCTL+YU/j6Ps7Gbj BaPhEYmJFk8i5wkiZyRwLVCJdr0EBYO1axKJq0wa5+JZ4xroZ5BAFJU4fNx8lpxeOUhl O7Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777628974; x=1778233774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cQtRFGksInkULS0m8GB/jr8IDzzr0ObA1EgynOw28RQ=; b=q+TLAf/2VsbIn2oijb5yHrtATBhkZf3Hk0S/FHyVVFc24Rc7XoqqUQF/UdWoJxo87F 15KwOVVOq2hKG19GBJrikCE7hiyq61BfF1YG7/UFrYZJnNCuCVd4+XYMgnmysYok1Eve SS65MVBXHRFERSHnNgvoXd+Cq67eBW0YpCGza208omuv972tHNHvnyGuy3PpHfoFLqzT OvuYw6cz3YxcNz34Ew7YSg6OpbYRu8vbNX2yDV8SQYDfFwTtL7kjvonNfz2K+NVlWwEa 7LnCnZW2UM/U4KFaxSGRJrgRyedaXgkrsZj1qOSjjFf2TIMl9101uXibeX3gcs8kyvfS P6eg== X-Forwarded-Encrypted: i=1; AFNElJ+puFg6awt01kvskgI5IaRY20+IBHMLzT65ut/l0DUsLq5Y/mbSWP9Qo/HGrqj3/VNf1dvyAWO1Xt8cc4E=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ9/DPcuOM5DksJ3FzzkNYT/lvF/974KwYHVAcnG5wDMxZ7DXY wVNKFNR2+XIXkF+t/8VGDayRDzkXdmh/CfEoK7OXNDsnvHi/pkSCt4HH X-Gm-Gg: AeBDievnZfBXprconNe4vRl08PxsSqX5cZAKXEoMy70B08/+YYNUavN0jOHt5h2RYlx SoGOZu9X8o5ZGhK2oeBihaZAnUHdhvwlelcw+4D0WtYl/E2BTJkn0OWvR04vKOT9OdNZzU7lTi5 RgLtXWmCikADEMUbZkpUy1fH6c/LiOwIZbc8udyV10kDu3CWAj6F8s4VuE+e/MurtE87WKy9Utp rYLo/Jd1HZJ726yyMy3i0cYVBYzLFE8nomTIgGgC8NPRioKVSV5o4CDFtt+zUSgAXWKbGsdZKFZ t5eYPXzO6UMfPPa/EnqAM8NEDWzizFyXGcQnp7HRwyD+dqCjy38YGj5TrHD5V6z/c1KFh/fWUK+ UoXNaQLKJYYiwKoajRybYC1nk7+HGkNXmd2lVp1ZoCy1vTogUPY9AJOEp06nRL6az9eiefgcRfH QyPXGO/t4WsGhQTBKf7fBu4gxqxaP+h0o5MCDWdg== X-Received: by 2002:a05:6a00:4b54:b0:82f:37e3:ae82 with SMTP id d2e1a72fcca58-8351a63b46emr2481911b3a.44.1777628974533; Fri, 01 May 2026 02:49:34 -0700 (PDT) Received: from laptop ([2001:4455:8025:be00:eebe:247e:613c:24d7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8351582dd55sm2042729b3a.1.2026.05.01.02.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:49:34 -0700 (PDT) From: Cris Jacob Maamor To: Mike Rapoport , Pasha Tatashin , Pratyush Yadav Cc: Alexander Graf , Andrew Morton , Dan Carpenter , Greg Kroah-Hartman , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC 2/5] liveupdate: validate restored LUO FDT before use Date: Fri, 1 May 2026 17:46:34 +0800 Message-ID: <20260501094637.38650-3-crisjacobmaamor@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260501094637.38650-1-crisjacobmaamor@gmail.com> References: <20260501094637.38650-1-crisjacobmaamor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Cris Jacob Maamor --- kernel/liveupdate/luo_core.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/liveupdate/luo_core.c b/kernel/liveupdate/luo_core.c index 803f51c84275..633a16434164 100644 --- a/kernel/liveupdate/luo_core.c +++ b/kernel/liveupdate/luo_core.c @@ -82,6 +82,7 @@ early_param("liveupdate", early_liveupdate_param); static int __init luo_early_startup(void) { + size_t fdt_size; phys_addr_t fdt_phys; int err, ln_size; const void *ptr; @@ -94,7 +95,8 @@ static int __init luo_early_startup(void) } /* Retrieve LUO subtree, and verify its format. */ - err = kho_retrieve_subtree(LUO_FDT_KHO_ENTRY_NAME, &fdt_phys, NULL); + err = kho_retrieve_subtree(LUO_FDT_KHO_ENTRY_NAME, &fdt_phys, + &fdt_size); if (err) { if (err != -ENOENT) { pr_err("failed to retrieve FDT '%s' from KHO: %pe\n", @@ -105,6 +107,12 @@ static int __init luo_early_startup(void) return 0; } + if (!fdt_size || fdt_size > LUO_FDT_SIZE || + !kho_is_preserved(fdt_phys, DIV_ROUND_UP(fdt_size, PAGE_SIZE))) { + pr_err("Invalid LUO FDT from KHO\n"); + return -EINVAL; + } + luo_global.fdt_in = phys_to_virt(fdt_phys); err = fdt_node_check_compatible(luo_global.fdt_in, 0, LUO_FDT_COMPATIBLE); -- 2.53.0