From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18E8345CCE for ; Fri, 1 May 2026 09:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777628990; cv=none; b=iq5di1MhXUqsQEetWNunli+jKDW4ACkettYjbNehDPJoF5SV65JXZuGuBuRIU4sM/zFEjMSy48gl1CIXn+4otiZxwvjk5zpstRRlnLV/G23O/Kg1vxLz3ZrfH0jLI9aoztAmOjRnS9py7loAX/dwb3JezRd24jQqjn2QlcJyFtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777628990; c=relaxed/simple; bh=eD7OqJpTKSjDHbpdCfhWW1Ydk9sx3+0eBxZw9GujDD0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mHWzwCo8gPf/99pKdMBRz6kUG4MXu6RpDVcSQPPNfdr3DQT7OmdajFIzjcopuSkcUs7ydGgcgFgHLLl5JDzrGMyCaf1SrjU3bIF/edVrcvZe4DIsYS4efZzCFPqVKqtG6iybuCHZeIX4Fscl5a/Q56k4R/BPvuHAbehgoYOYmWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FBO+R22s; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FBO+R22s" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-824c9da9928so869754b3a.3 for ; Fri, 01 May 2026 02:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777628988; x=1778233788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=byHariOe/418DnHhAYKU/dMJ4rRms9bwPBY0UESk+2U=; b=FBO+R22sIeQKFaidvE7uTzyFlKdllZBQSIDGQHY1/pDWKBu3wB2vXkpHf/EyeKSlWN uzcISwNs9QlUD3OSfM2YM3ZNsMbcKmM8oY/gWQZgRVa3Dra+qhywZEzBr5CpEY475jmI Cg79bvohvFCBTOLtYVjxKD6UMGa3bvWCNPrTpZjo8Aip/DnK8lKVE7fGsPbYkSvvxL2Z T6Bvx9OxHQpdrqe4mnA7EAiC4VFt2sJs3qqjqLDHKJpRiHAPN7UnXB+P9ibWl6Ga0DSY 0yK+hP5ktoe6FLZhudlDCj64DRLmXUyUoeNWeyjysFYoqaQ3cYyRBfMTYJoE0ny3PWJW YisQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777628988; x=1778233788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=byHariOe/418DnHhAYKU/dMJ4rRms9bwPBY0UESk+2U=; b=Zv3qr+c3I/btaJr2F4ATT2zz+0W6KitGTRuCZ9BZ3uZXtHv0rslOhMONt73qPTuKoB INMQvd6avayCTnh12wooTIsBZhd0AxwngtVt3pNDLywXtGfUssTCdikpJR6wYKkMsBk6 F+qXBniSOmX81NQhlLDNVfeKysN3tAF91B67sBR+C03lbgv69OWzRyNqDTlZFEcLxYK1 pQ/9kqTGbF5R73zS6cozKAGRpxF/2r9E+Tu+1rUNvLDquWKF441FLBnjHc9dk+Y2z7Q9 B/CXu9pavhws91Mt5iKi9ayZMkw3G0VyAfOkVSQtsij3X/BShqWOvXGCiUm8Uwc82+nP xKkg== X-Forwarded-Encrypted: i=1; AFNElJ/CHRwbktSarFWkwgtnfj+Idl0YhWTWBMjbv6jsXfwfkTYTT7mNPPNhHLL03dvvEN1AwLozNqyc9LNA9Qc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa2454LJwLio5PQUrBGtFWKI67QwM5mF2U23vzjs30bDPkR1fh njBUfzWHrqg28mwJ4kwJmdkZXDzYtyz2lFrzr1XRuZ2Alje7vJSwFz7LQ9h0q/ogJDc= X-Gm-Gg: AeBDieuY355TfDCD+t3AXaCkOvN+p4EBdY+E6KtFjiLwQHj6vXWRKeF0CgokqioJ78K 2mHiGY5AcVMjy8Ne5h7ExduVrgBGg3Pv1Im34/OLeJHangvn5siJAMy5OAmXj2Wqij8V+S/Idti FZ+QrgntWlfXeF4ehh6D/vuSRiotm5jXEw1dsVU2lCiFJBqvuvSelFSs996qahLb1XmS7cEKnua Jmz8kp5WG7G6JrtLDB50hw72kQdBMyTzsbywhacNuItOlAH7HCyFw3LXYQt8xDg8KwDErLP81sN 1AqeAWy6JJxa8NWnjH2biXs9+OLFBOhhTIldlEyKau6iEmMOsOQKB9r8DFArOBUsa0LV+CM+YHi 0OcH/aeT/qSc9I5vvOMwPkDAE/NUOqOXVru64Fh9DHZeu6/7DW0Av6DCwWUdvHS//fu9FwEkRv1 Ybh6LBBng+tm0V9f5cVF+lykGOeGtz3bb4KpqOAA== X-Received: by 2002:a05:6a00:3cc5:b0:82c:9c47:fef9 with SMTP id d2e1a72fcca58-834fe05cc9bmr8047701b3a.2.1777628987950; Fri, 01 May 2026 02:49:47 -0700 (PDT) Received: from laptop ([2001:4455:8025:be00:eebe:247e:613c:24d7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8351582dd55sm2042729b3a.1.2026.05.01.02.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:49:47 -0700 (PDT) From: Cris Jacob Maamor To: Mike Rapoport , Pasha Tatashin , Pratyush Yadav Cc: Alexander Graf , Andrew Morton , Dan Carpenter , Greg Kroah-Hartman , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC 5/5] liveupdate: validate restored LUO FLB metadata Date: Fri, 1 May 2026 17:46:37 +0800 Message-ID: <20260501094637.38650-6-crisjacobmaamor@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260501094637.38650-1-crisjacobmaamor@gmail.com> References: <20260501094637.38650-1-crisjacobmaamor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Cris Jacob Maamor --- kernel/liveupdate/luo_flb.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/kernel/liveupdate/luo_flb.c b/kernel/liveupdate/luo_flb.c index 00f5494812c4..e80032669cea 100644 --- a/kernel/liveupdate/luo_flb.c +++ b/kernel/liveupdate/luo_flb.c @@ -162,6 +162,7 @@ static int luo_flb_retrieve_one(struct liveupdate_flb *flb) struct luo_flb_header *fh = &luo_flb_global.incoming; struct liveupdate_flb_op_args args = {0}; bool found = false; + u64 count; int err; guard(mutex)(&private->incoming.lock); @@ -175,7 +176,14 @@ static int luo_flb_retrieve_one(struct liveupdate_flb *flb) if (!fh->active) return -ENODATA; - for (int i = 0; i < fh->header_ser->count; i++) { + count = fh->header_ser->count; + if (count > LUO_FLB_MAX) { + pr_err("Invalid FLB count: %llu\n", + (unsigned long long)count); + return -EINVAL; + } + + for (u64 i = 0; i < count; i++) { if (!strcmp(fh->ser[i].name, flb->compatible)) { private->incoming.data = fh->ser[i].data; private->incoming.count = fh->ser[i].count; @@ -620,7 +628,20 @@ int __init luo_flb_setup_incoming(void *fdt_in) } header_ser_pa = get_unaligned((u64 *)ptr); + if (!kho_is_preserved(header_ser_pa, LUO_FLB_PGCNT)) { + pr_err("FLB header is not KHO preserved: %#llx\n", + (unsigned long long)header_ser_pa); + return -EINVAL; + } + header_ser = phys_to_virt(header_ser_pa); + if (header_ser->pgcnt != LUO_FLB_PGCNT || + header_ser->count > LUO_FLB_MAX) { + pr_err("Invalid FLB header: pgcnt %llu count %llu\n", + (unsigned long long)header_ser->pgcnt, + (unsigned long long)header_ser->count); + return -EINVAL; + } luo_flb_global.incoming.header_ser = header_ser; luo_flb_global.incoming.ser = (void *)(header_ser + 1); -- 2.53.0