From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCF00383C78 for ; Fri, 1 May 2026 09:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777629449; cv=none; b=oH4vmNrWxr6LEzU4Kc7e6Eu+Oynv4i9mt8nxRzlVxWy/Vf4jcr8v2NkO5lpdBwHBYOk8+5LvR54krVVc17nKG2vWWnkQm+vl6+mtm/LbtTFJ0MvVGngM7XeDfT0gnO6/Gma72oqpDEE8Juy5e4fcljPDU+REoehl317M8wqkX/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777629449; c=relaxed/simple; bh=G/XFuwWSYegiGjSYZM0aXjfEM9ASQLOuSIcX/VLpzm4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QWfBS2PHfBfNrD0t/5Lwq6Nkd0H0lWjFuxzFG6GHYtNIyJTFTDHaj/Z8aAuas/tha5RxqW38rDYsEbliT7fkQs5XJfb5S0MZC+RzWDpHYlUcypRgNnBcw4W4rmAdee6ri1yXw2WaOhTOunT4Vx/Weq5V3ZZ4lXQtGOydWbVz8rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=wBDXD0uV; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="wBDXD0uV" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso12953275e9.0 for ; Fri, 01 May 2026 02:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1777629441; x=1778234241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1xTN6OsAVuW3jnezW6FjJSAEG6gFeBXpHPEFbG0OKV4=; b=wBDXD0uV35huVdD1wM1fFaUo3/JXJQuZ/MXEeyXa44aStTGI/am5hzYZA+PKmW/WeK KxSj6Iym+6hMnvn2tyY7aHwkySlkYtxGDWMdlI0ygH76JqXA1LPbu6NPx4flhBEHsbob v6XqInW59UwHPaUgPOIoLLNzKS9jGqoKlXhy75rogcezANwzoK54qunUd/ZyNspCr6HV QEoqpUhOxfBEz9MHeay+a5j2R79yCMgRZV+bjChEDxYwLKY5/zEx3NaFOmLOQJHBLjFa BUhwkpyx8jqQoUZ9NNRkzSYYtt969Fzf3sCdhmvJrdCkY5g/SKiIrH1lTCjXsj8LtETO fDeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777629441; x=1778234241; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1xTN6OsAVuW3jnezW6FjJSAEG6gFeBXpHPEFbG0OKV4=; b=JUBxMwT7Z65sTAgNGI3yNJqWxGihgTXlPO5pV+jm3xkMZyoAXygmVNExw41WJ1zdYn jhZQkW4wv96aIalk6wzTzeokbxbZJ9iiFUOfpW1ehSQ1Ozvccbg1FtsTCZl1B62VFSLx sAGGmvpNP7JZvJJYPXn10Ia7JX0Pq5k4tDVBaE6y/S0t8naOLfo87iOJJlAyu7c6C6Dg llHOaoX5H5MPi/G78BajdmJw9yOVNxVkHpAE8/62Pty6q1en6YFQUiOStpcIFZalqqnl FmD5EMrVf8guhzXu7sd7aC/kTDhMizvCDhwJ4/QS65KuJI8cpiYhzD7sASbvFQz4hrzV QUzA== X-Forwarded-Encrypted: i=1; AFNElJ+EwFRRsP5Ioq+/vWU40ZO27MYwm0NUOeyDLPPSCodrpHwaAmsIB7pW6fHf8egFNUMPjETYa200wvEWj/o=@vger.kernel.org X-Gm-Message-State: AOJu0YyUIKHZZFwiCst+Kej+kC2QZqqwUrPyFyGIiXh3t2vO7t5YU8mq qJCknTYKCIEVbRx4hp4ifSPKwvOmi5ejUbVp1hicxHG94xZstIy4rrGXTjSHPxwwYrY= X-Gm-Gg: AeBDievqw+NJP0RbKU44Fm4ov/6HbLke3/ezYAJkszUkVQhxyrWAAhv7NsVphfBV+bm TX5ypUT6b0cZEa/u9fJtrtUS3FZ4KS63unpcx1WuSRVxOqZMBjcTq56cPGFfjEmGygzU8tNgTD8 pc91pivhhkbdWQBKTMaFFLZQH9aIk9Lo7sLlQfLmJ7SXk5JK8vcI+EP0Ewqy9kzFsrHe7ZXedtx ixYOgCIpqxY5iDiNtDKrjsSPGVW++6fsL4Rq+LzYOPX0+xqfIpc0u+bHJVzclaCHHtZRPYd/o/W jTDvsn4lL6Zq+beJMVAzZ0yBMlvSzwh8v/lJTiv2WRCwyM/D4lIL4XL+Ezg4LLTFwV7wmKYM0xG grCRmTlqn01PJFoLVBlyofiPhQGo7ZxgjBl5YWfd20w/5PurDvP6gL/XbvjQY+U2vXjvmhiK2Od o7dfghPO8CMDTuuN0p4XKozfdRUcl61wSTmHsY X-Received: by 2002:a05:600c:154d:b0:485:39b2:a47c with SMTP id 5b1f17b1804b1-48a8452db0fmr108898045e9.25.1777629441256; Fri, 01 May 2026 02:57:21 -0700 (PDT) Received: from matt-Precision-5490.. ([2a09:bac6:37a8:26d2::3de:68]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb3427fsm73837315e9.0.2026.05.01.02.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:57:20 -0700 (PDT) From: Matt Fleming To: Tony Nguyen Cc: Aleksandr Loktionov , kernel-team@cloudflare.com, Matt Fleming , stable@vger.kernel.org, Simon Horman , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Eric Joyner , Paul Greenwalt , Alice Michael , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v2] ice: Fix missing 1's complement negation in GCS raw checksum Date: Fri, 1 May 2026 10:57:17 +0100 Message-ID: <20260501095717.1032151-1-matt@readmodwrite.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Matt Fleming Commit 905d1a220e8d ("ice: Add E830 checksum offload support") added Generic Checksum (GCS) support for E830 NICs but omitted the 1's complement negation (~) when converting the hardware raw_csum to skb->csum for CHECKSUM_COMPLETE. Without the negation, every CHECKSUM_COMPLETE packet fails the fast-path validation in nf_ip_checksum() and falls through to software checksumming via __skb_checksum_complete(), which triggers the rate-limited "hw csum failure" warning. Packets are still accepted (the software recheck passes) but hardware checksum offload is effectively disabled and the warning floods dmesg on systems running nf_conntrack on VLAN sub-interfaces. Multiple other drivers (idpf, ehea, iwlwifi, cassini, sunhme, enetc) also apply ~ for CHECKSUM_COMPLETE. The ice driver was the only in-tree user of csum_unfold() for CHECKSUM_COMPLETE that omitted it. Fixes: 905d1a220e8d ("ice: Add E830 checksum offload support") Cc: stable@vger.kernel.org Reviewed-by: Aleksandr Loktionov Reviewed-by: Simon Horman Signed-off-by: Matt Fleming --- v2: - Add Cc: stable@vger.kernel.org (Aleksandr) - Pick up Reviewed-by tags from Aleksandr and Simon - No code changes v1: https://lore.kernel.org/netdev/20260408190214.1287708-1-matt@readmodwrite.com/ drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c index e695a664e53d..c177579e0114 100644 --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c @@ -92,7 +92,7 @@ static void ice_rx_gcs(struct sk_buff *skb, desc = (struct ice_32b_rx_flex_desc_nic *)rx_desc; skb->ip_summed = CHECKSUM_COMPLETE; csum = (__force u16)desc->raw_csum; - skb->csum = csum_unfold((__force __sum16)swab16(csum)); + skb->csum = csum_unfold((__force __sum16)~swab16(csum)); } /** -- 2.43.0