From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB41937DEBB for ; Fri, 1 May 2026 11:02:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777633329; cv=none; b=tYv14mKHh3b5I0SSU7PX7J+EKShOC4kfCC/FyxRvPuEOk064bZ35xQ8OZUrNfGMdP9vBML7ribWBEi5tTJNibTgMzKfBPdTfu/02UbvFIfXa/hIvTPTrOJIjvEScxB+bfwSlpiJrHtR6zJXpje0oIUzdu8zE1nOdaXVuSsHK0xE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777633329; c=relaxed/simple; bh=i9aHcnR3UfI48HD1OS5y0W5JFsKaLanCbnnKA7TqlGk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mrs1dlNUgh8oao5qZOoRgTDoc0pSaLqKS+CNOEXf6Ui23z1MuU8ZyicackKhI2HkUcKN1iGzPUxmT5+RJ63GwjA9i8Ft1FjHf4LVi7+0r1e5XCM0vcKXGT7k/gP4Du3g9CTyEXANLitxPU2tyIm6ZedgF4erpf/qOdVogHM3a4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eh+xpsBK; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eh+xpsBK" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so15061105e9.0 for ; Fri, 01 May 2026 04:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777633325; x=1778238125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vqZidDCn5y4gCrfLbOWYKSzW8HkTpyANFAvcSFhaUEo=; b=eh+xpsBKWMGSQe4n2zDtDjNOmg0sVLound5lvwUGctcIWWXFHTvgHzuv0/uKdDOORR fZ1dNMmLhVeBGLLlnzqalf1NOyn3/pPI8AmjhIZcsaTR8+8jNGD7Eb4igvVWeplG5CQw 1SnN8UYvlvnOpR9y5/9nmE0LDAmglQllmUzu+aTI05w0P6YmHMW0oGOAHMoXedZzIg3j 4H51KFzm0BC3LhzdQgPP4vqi0AKD7L32gpET89tdY7DKuoE/FwfmVLbId0zdCzXrwyT7 G+wt2XcW11zKShxpvqHhYH5tEF6khqeqOelsxOr2zb6yMlSer5sYtKvCm3TsjC74bN+W lpng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777633325; x=1778238125; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vqZidDCn5y4gCrfLbOWYKSzW8HkTpyANFAvcSFhaUEo=; b=J92nhXXBBz/uM85Xoh+WQ1kJ5ctdKqbeDibRlkHkUJwjsw27Gi4f6Tyb+U20dG8nnG WNu4Qa5iby4XxCS1rRfSyX/1j2CTez4Ko5BLUN80vx5Uw/0ospFtaSzs+93oCvGqRXj9 2W7xO6xrmhrUBvi6KZD8+Vdh+KdnuygduZZS3rgUsvwmskeHli0dd6IZD0pAyIsRrCdV I3r3LC5UlVJ7KqSmWcY1DpUCLyHZnBzVmFIfnOswhWvTczDx4OLQjC0G+T0EBetx0Lr0 9hH6PE4z8jnaKFBr/0UYdTEeSsrRGYJRh+xE4dtZDeA/cCZ0U/XIjSA9uHMEqqcOdIKX AfBA== X-Forwarded-Encrypted: i=1; AFNElJ+geDUDshCWd+c64XBBSGEoGdC3AiuvnkpaImI/xv/8ipCtEkYCror5Zt1gVH2RH3xx8ppfHqTENbMQNTM=@vger.kernel.org X-Gm-Message-State: AOJu0YyFsEtqgAv4hnbW2C6CD4pNmZwAOKhwH1bT8LsOIMBh8/sE96yW fSgnSnwwjxtFpS56zmKH3A+uhNmNAJxhffmLPij+WV/vl7hHQSakssc= X-Gm-Gg: AeBDiesd73DqrXEG8+GJdvMHegXEs8UYJVtzbqJ4TLaVB7HsWb9cAh2X2eQWTNAKIG9 h+vo6ZsWs5rgqUjWx9dgzNCDDWqeOqUmjdU+UoAdu4QCi5GfSmqvZyZX8f448k8+sWiJ7DNZRra ALtkIkS8WjX0E9KsHGTI6Nz9Sca4pltx0NciiUdNUf4OK63DGhGv6ogUYiyhdNDazM1hXnT+XKP /QqQrruqFKCc7/Xm/+NXlYCLrXpg9JkIuzYUi9w43LxylONdVVSGSRCGOXe8Qdpi7KGYk9IKhPv qzluFWQ3HW+qUg3OOLo839mVLbCdL7j8UYPx0uATEn8GCFuZ5W4Un0TTsF7r32Bbnt/3zU5ZEPC K8xlM7RMjM9IfOgdp91mkKIogRkk2mJQbLItjOZTqOMaGi7v7+F171LVxYPgmql97CYrPUodwNl f2b14= X-Received: by 2002:a05:600c:4fc5:b0:488:a723:ea53 with SMTP id 5b1f17b1804b1-48a83d77ec9mr115852605e9.7.1777633324796; Fri, 01 May 2026 04:02:04 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fede418sm13928485e9.6.2026.05.01.04.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 04:02:04 -0700 (PDT) From: Tristan Madani To: Andreas Gruenbacher Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tristan Madani , syzbot+42a37bf8045847d8f9d2@syzkaller.appspotmail.com Subject: [PATCH] gfs2: fix use-after-free in gfs2_qd_dealloc Date: Fri, 1 May 2026 11:02:03 +0000 Message-ID: <20260501110203.18771-1-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani gfs2_qd_dealloc(), called as an RCU callback from gfs2_qd_dispose(), accesses the superblock object sdp through qd->qd_sbd after freeing qd. It does so to decrement sd_quota_count and wake up sd_kill_wait. However, by the time the RCU callback runs, gfs2_put_super() may have already freed sdp via free_sbd(). This can happen when gfs2_quota_cleanup() is called during unmount: it disposes of quota objects via call_rcu() and then waits on sd_kill_wait with a 60-second timeout. If the timeout expires, or if gfs2_gl_hash_clear() triggers additional qd_put() calls that schedule more RCU callbacks after the wait completes, gfs2_put_super() will proceed to free the superblock while RCU callbacks referencing it are still pending. Add an rcu_barrier() before free_sbd() in gfs2_put_super() to ensure all pending RCU callbacks (including gfs2_qd_dealloc) have completed before the superblock is freed. Fixes: a475c5dd16e5 ("gfs2: Free quota data objects synchronously") Reported-by: syzbot+42a37bf8045847d8f9d2@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=42a37bf8045847d8f9d2 Tested-by: syzbot+42a37bf8045847d8f9d2@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- fs/gfs2/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index a2ea121331f18..4d854556b5299 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -643,6 +643,7 @@ static void gfs2_put_super(struct super_block *sb) gfs2_delete_debugfs_file(sdp); gfs2_sys_fs_del(sdp); + rcu_barrier(); free_sbd(sdp); } -- 2.47.3