From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C37FD39B494 for ; Fri, 1 May 2026 11:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777633343; cv=none; b=oeA2cVmDwhvB6FzUZoXe7ZzSH6SyCT2JbNcDFuQgoCHUyYuajl21K0sf45RZ6RtFGrfFE0fWF89qmpjsx9F5UAVoKmkB9K9sRju0oC5p0FpXWTuhU8muRfNJSBd1J4uEjTYkhtEcl4Lci8XmAObctimmxZzxQQrOsbtVq6at+h0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777633343; c=relaxed/simple; bh=e96F4VL0FqghnjCcfD5j5AlSChhZ6jZluo6CEFl4jqA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rx3uAWb/ujRL8JVgH/HauKXyXcnbXCBeEkt/8uMswFFDht9Q0CFZh1v1/q5DlJkX3yCDv//ldamWVO4w+ml+0uWx7Pi1kc6DmjJguUJKnvbMvaphvaXcmPdhJHieqjVea/thPVc/kXf31xDMI2Kmr/e3mwpGLTyqab1foYonXaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WnTolhOI; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WnTolhOI" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so17627845e9.0 for ; Fri, 01 May 2026 04:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777633340; x=1778238140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M8YgggC+mPdbH7rnccFGr/mooO19vkDnSnGo0lHMmlI=; b=WnTolhOIWmbDz2RYtAOoRocfSl7akvFcw8CR9SyNd5auy33oaOR7OwiLojc8PokBCU vhnsWpQgXojrgCbZhd24FsWAhgsXhhIe4pz8kaVaEI1bEHMGbQk+DDh5MFqYfamJBunm pAo87wZvrxWStPugMN+kfPqjzzY5r+DeTl1AC5tckoJcUV3lLNihAO0TtvwsNDDbU2Ri DuYW6rWVYnkB7Y+KXOUyf2Jm6g1UK8fn/Ui/16tz2O9J2ZSdOCaIeogfhHSuMX3MEvnj CVIECKGkmz6PC+RWWXm+t12xFStGYcAOER6JSXSwBisVZZhdZaWLelCkhXLyLUnzoelJ 72Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777633340; x=1778238140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M8YgggC+mPdbH7rnccFGr/mooO19vkDnSnGo0lHMmlI=; b=fAKIrkMs0G28GM5neMJtHYstq2y2Z/UXwPRM1PqpE9I60h34QMArCIAxH0C6EPZSVU WiePMA34adgabHJL5qIlKx1s9nol4sSis7XMt2L9mwmnVn6BjN2v1NzvIA/E6xXH4/it Zb+F6ZsGoO+spx2AnuElV2C6K/uZdCCs7NwowIaTXZIWkRewMOEZFZNJDZuJyn15Fq0r otM9lryLhh5ac8WUfiW2NTOOOsrFfsXlfeBh0rJ31cowvyOsIjP+mIYNy27QOMNEO+TN MJ3kl6jt8AwOUpbcPjGeqdPvY9YeoWkm2pwBYvPIvC+psycnsq2zRMtaPmBGpaDOf+RG BPFg== X-Forwarded-Encrypted: i=1; AFNElJ+EIyyyIBMDVGEyRRAs7FYV2EGbHbv7Qm8iBs6No/pU2RsiDcFzrTyUnDY/UaEslSRA8kCC0XYS4gR5Kag=@vger.kernel.org X-Gm-Message-State: AOJu0YyQdZ3nPeHKX1IOcX/y2YxRmSH+vy0fNTZsmLbNEGldouJjzHez Jtg1ueag+ukr0up1z5hufITsfm3KQ/gtau74/djh1eDgvbyARxD9SwU= X-Gm-Gg: AeBDiesUNxj4sCCeSBRNePuT6sCHWdLZbmm7aMaPSJ+qAIwrbOHqmpvG747aMiAgldr 7bnvQmZtycqFrvIgtBD78CYWeA8T6nchoe9M9sAtro8PiFEH4srrer5n+tHhcStkBvcwtltzU5w 5Bhwuve1L9vMUBZ0IrdgvauF/5Xxt9NWe7qjXAysHS5Rlpow5LPwm6c0n6Vp4KKL4PN0FHLZTWV h519BKYXEgErtATF44cxIRj126FGvnLDJaK0zpZ9LdaQpP1G/hvozEMe81laDJl/w13gwci1yD7 9l1BXof+Qfgj7nUrlTowpw9Qjv4MHoQYtYkCvWXjgqt964ieaIt0DXehpsSBD5v2EoU18CIMG11 LTpc/VclKxuDs0f7V0cgP09sP5DdgIbjNtkRi3gULuTGronNDoa4YRKCUZY6ZM0aavQzlgbEFqt V75Mc= X-Received: by 2002:a05:600c:a40e:b0:488:c40b:c8a4 with SMTP id 5b1f17b1804b1-48a83f6e2e9mr85879755e9.1.1777633340022; Fri, 01 May 2026 04:02:20 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a820c8556sm121627405e9.4.2026.05.01.04.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 04:02:19 -0700 (PDT) From: Tristan Madani To: Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tristan Madani , syzbot+217eb327242d08197efb@syzkaller.appspotmail.com Subject: [PATCH 2/3] hfs/hfsplus: initialize data buffer in hfs_bnode_read_u16 and hfs_bnode_read_u8 Date: Fri, 1 May 2026 11:02:16 +0000 Message-ID: <20260501110218.29906-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260501110218.29906-1-tristmd@gmail.com> References: <20260501110218.29906-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani hfs_bnode_read_u16() and hfs_bnode_read_u8() declare local data buffers without initialization, then pass them to hfs_bnode_read(). If is_bnode_offset_valid() fails inside hfs_bnode_read(), the function returns early without writing to the buffer, leaving it uninitialized. The caller then returns the garbage value to its caller. This triggers KMSAN uninit-value reports when a corrupted HFS+ image has a node_size of 1, causing rec_off to underflow in hfs_bnode_find() and the subsequent hfs_bnode_read_u16() to operate on an invalid offset. Zero-initialize both buffers so that callers get a deterministic zero value when the underlying read fails. Reported-by: syzbot+217eb327242d08197efb@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=217eb327242d08197efb Tested-by: syzbot+217eb327242d08197efb@syzkaller.appspotmail.com Fixes: a431930c9bac ("hfs: fix slab-out-of-bounds in hfs_bnode_read()") Cc: stable@vger.kernel.org Signed-off-by: Tristan Madani --- fs/hfs/bnode.c | 4 ++-- fs/hfsplus/bnode.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c index c00645a4a5733..08307faea7a68 100644 --- a/fs/hfs/bnode.c +++ b/fs/hfs/bnode.c @@ -97,7 +97,7 @@ void hfs_bnode_read(struct hfs_bnode *node, void *buf, u32 off, u32 len) u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) { - __be16 data; + __be16 data = 0; // optimize later... hfs_bnode_read(node, &data, off, 2); return be16_to_cpu(data); @@ -105,7 +105,7 @@ u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) u8 hfs_bnode_read_u8(struct hfs_bnode *node, u32 off) { - u8 data; + u8 data = 0; // optimize later... hfs_bnode_read(node, &data, off, 1); return data; diff --git a/fs/hfsplus/bnode.c b/fs/hfsplus/bnode.c index f8b5a8ae58ff5..35790085b5b2e 100644 --- a/fs/hfsplus/bnode.c +++ b/fs/hfsplus/bnode.c @@ -55,7 +55,7 @@ void hfs_bnode_read(struct hfs_bnode *node, void *buf, u32 off, u32 len) u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) { - __be16 data; + __be16 data = 0; /* TODO: optimize later... */ hfs_bnode_read(node, &data, off, 2); return be16_to_cpu(data); @@ -63,7 +63,7 @@ u16 hfs_bnode_read_u16(struct hfs_bnode *node, u32 off) u8 hfs_bnode_read_u8(struct hfs_bnode *node, u32 off) { - u8 data; + u8 data = 0; /* TODO: optimize later... */ hfs_bnode_read(node, &data, off, 1); return data; -- 2.47.3