From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f74.google.com (mail-ed1-f74.google.com [209.85.208.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB11139E166 for ; Fri, 1 May 2026 11:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777634432; cv=none; b=uHjUfyC0dAIk/T8woALA0dGNyxrcQD4Bktyls1WdnPaCgsiWbj7x3CYeMwPkNNCVTzcqM47DQunvdMF8clM5gwfvJflHh1DkrqXEuLrwHJVDZWaF7vsv64qoMsZsypRBNcAl9YNKjO1vulMXkJPPwYfUjm6mtXSpWrsnspS+OhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777634432; c=relaxed/simple; bh=4IbK2AkELhYHNt+kY7TsOF+nTpzv9kfiFGq+yMByoyA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MYbX6Kb552BAiZeVgE5xx5OuHbQ4gGygYprn7ecDfsBbgFROec5PbciMmOxseAb47VpwG1CDQWRY23VAHOCT9t43stCHTlPJ0LtiyQVZllXcyLaF5WLlRyVqzDFKvRzkC7SWQHR2OPJqdFl8N+baS+TpFZRz7K8QSGw/2RjzqDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Z2ls4e0N; arc=none smtp.client-ip=209.85.208.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Z2ls4e0N" Received: by mail-ed1-f74.google.com with SMTP id 4fb4d7f45d1cf-678a526f24aso1967397a12.3 for ; Fri, 01 May 2026 04:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777634429; x=1778239229; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=OvQ7rT8sfpUuWMPN37mpWwK5CZ/GStRVkhZPxjRKMSU=; b=Z2ls4e0NVbWz+dsMMluHhOOePefYvuQFezKYZcjWua8odiholVUnDHXD8B23J6OWX5 nNoUGFUr4No/NZgztnIGl0CN+/1Hz0aCbAEuUZrsG6eMgFBknAQkqXVzgp+WJEdT0bdE OvsPnZyEbjaJpGJiUeEzC8dyuQ4aPIwTKBmFiFbjLnY6hJLdRSx9wTBw5vJ6nG+n1LrX dwW14X/iETUxnEyoTlR3GKJuD7Ldu6uvi4qFBKtcPrLi+5yvbNX9wPgBIAUTzksEPpyQ CPISe0HcV7F4kNYha0UddE70pHDL8BFvfo4iNimdXzUzftTx8LyWoJj4GPk0QQmQwmLm j9Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777634429; x=1778239229; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OvQ7rT8sfpUuWMPN37mpWwK5CZ/GStRVkhZPxjRKMSU=; b=GnZuX897a2Pp/HoBRzubklDvT0cKifqKo26R8W5gylqRvC9eklVtCG2rcQKMCCEm5l KNU8xItRTW45bhYSFwEy6eFspEgfBxtd2sA9t/14K4O9De2qsZmVoGPx0KXFq46efPNU ypqD9wyQdc62RBJXgo8/TAp6EKsZyisDHGb1xOF0vQ2aglPfFY708DcVzu3DUVa3l4MN I6ihEc9fCNgjR0+0cxYiadGLIJSQrxuxZKYLenP21wyjgWOCmyJQs3By1L0ey3uO5imi 9R2WGRm6sdeXmwpHO57Ff7GJukApvg7lGQemmpWTnGf1uUWpenJGxcHxyUuJJD0PO6IY 719g== X-Forwarded-Encrypted: i=1; AFNElJ8NziRBI+G7IBYJbzImNjsYa2swxw+u0mQ+K8gCZ4vNrT21n+owlQoF3U4R74fjID4w9EYT1qu7iaKH4lQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+g8c2KYotqW11h9/nQ2QCy0M2gxDLFNQ84Yq2lSbNjCa6TUc8 ba5e0anThGHtECnVDyyXI6oyDcC8P/A7dyGosvmgxJ6RLrO9otvH5b70QaZmrP41KsvxK+jimQk n9N85SSsBIRBvCg== X-Received: from edbeo10.prod.google.com ([2002:a05:6402:530a:b0:66f:bef2:d9de]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:1588:b0:670:8b38:5717 with SMTP id 4fb4d7f45d1cf-67b5d84910cmr3588586a12.24.1777634428940; Fri, 01 May 2026 04:20:28 -0700 (PDT) Date: Fri, 1 May 2026 11:19:23 +0000 In-Reply-To: <20260501111928.259252-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260501111928.259252-1-smostafa@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260501111928.259252-22-smostafa@google.com> Subject: [PATCH v6 21/25] iommu/arm-smmu-v3-kvm: Emulate GBPA From: Mostafa Saleh To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev Cc: catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, jgg@ziepe.ca, mark.rutland@arm.com, qperret@google.com, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, keirf@google.com, Mostafa Saleh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The last bit of emulation is GBPA. it must be always set to ABORT, as when the SMMU is disabled it=E2=80=99s not allowed for the host to bypas= s the SMMU. That's is done by setting the GBPA to ABORT at init time, and host writes are always ignored and host reads always return ABORT. Signed-off-by: Mostafa Saleh --- .../iommu/arm/arm-smmu-v3/pkvm/arm-smmu-v3.c | 32 +++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/pkvm/arm-smmu-v3.c b/drivers/iom= mu/arm/arm-smmu-v3/pkvm/arm-smmu-v3.c index e258690384f4..1ed5ccce7849 100644 --- a/drivers/iommu/arm/arm-smmu-v3/pkvm/arm-smmu-v3.c +++ b/drivers/iommu/arm/arm-smmu-v3/pkvm/arm-smmu-v3.c @@ -126,6 +126,22 @@ static int smmu_unshare_pages(phys_addr_t addr, size_t= size) return 0; } =20 +static int smmu_abort_gbpa(struct hyp_arm_smmu_v3_device *smmu) +{ + int ret; + u32 reg; + + ret =3D smmu_wait(false, + (readl_relaxed(smmu->base + ARM_SMMU_GBPA) & GBPA_UPDATE) =3D=3D 0); + if (ret) + return ret; + + reg =3D readl_relaxed(smmu->base + ARM_SMMU_GBPA); + writel_relaxed(GBPA_UPDATE | GBPA_ABORT | reg, smmu->base + ARM_SMMU_GBPA= ); + return smmu_wait(false, + (readl_relaxed(smmu->base + ARM_SMMU_GBPA) & GBPA_UPDATE) =3D=3D 0); +} + static bool smmu_cmdq_has_space(struct arm_smmu_queue *cmdq, u32 n) { struct arm_smmu_ll_queue *llq =3D &cmdq->llq; @@ -468,6 +484,10 @@ static int smmu_init_device(struct hyp_arm_smmu_v3_dev= ice *smmu) if (ret) goto out_ret; =20 + ret =3D smmu_abort_gbpa(smmu); + if (ret) + goto out_ret; + return 0; =20 out_ret: @@ -756,10 +776,16 @@ static bool smmu_dabt_device(struct hyp_arm_smmu_v3_d= evice *smmu, val =3D smmu->host_ste_cfg; goto out_update_regs; } - /* Passthrough the register access for bisectiblity, handled later */ case ARM_SMMU_GBPA: - mask =3D read_write; - break; + if (len !=3D sizeof(u32)) + break; + + /* Ignore write, always read to abort. */ + if (!is_write) { + val =3D GBPA_ABORT; + goto out_update_regs; + } + goto out_ret; case ARM_SMMU_CR0: if (len !=3D sizeof(u32)) break; --=20 2.54.0.545.g6539524ca2-goog