Re: [PATCH v6 04/25] iommu/arm-smmu-v3: Move TLB range invalidation into common code

Mostafa Saleh
2026-05-04T12:15:26Z

On Fri, May 01, 2026 at 09:41:43AM -0300, Jason Gunthorpe wrote:
> On Fri, May 01, 2026 at 11:19:06AM +0000, Mostafa Saleh wrote:
> > Range TLB invalidation has a very specific algorithm. Instead of
> > re-writing it for the hypervisor, move it to a function that can
> > be re-used.
>
> I think this is too narrow.
>
> You should start at __arm_smmu_domain_inv_range() and shove all of
> that callchain into a new file "arm-smmuv3-tlbi.c" which you can then
> double compile for pkvm.
>
> pkvm would have to present the tlbi description and the invs array
> which shouldn't be hard for it. Then it will enjoy all the same
> hypervisor optimizations we are working on for the normal driver.
>
> I am about to send a patch series here for iommupt that significantly
> alters this. I think it will help your pkvm effort as the invalidation
> entry point becomes significantly decoupled from the
> iommu subsystem:
>
> static void arm_smmu_domain_tlbi_inv(struct arm_smmu_tlbi *tlbi,
> struct arm_smmu_invs *invs)
>
> struct arm_smmu_tlbi {
> struct arm_smmu_domain *smmu_domain; // Can be removed
> unsigned long start;
> unsigned long last;
> u8 leaf_levels_bitmap;
> u8 table_levels_bitmap;
> };
>

I am not sure if it’s worth it, the hypervisor is much simpler, there
is a single page table, it’s locked (also identity mapped), it’s
updated on VM boot/teardown only, we don’t even use iotlb_gather at
the moment, although possible but I wanted to keep this series as
simple as I can then we can add more features later.
So this patch is the least intrusive change, as whatever the main SMMUv3
driver does, the range tlb invalidation logic is the same.
But I am happy to experiment with that when posted.

Thanks,
Mostafa

> Which pkvm should have no trouble invoking. It has to build an invs,
> but I guess that is pretty simple and done once at boot for pkvm?
>
> Once done all the fiddly bits about building the commands would be
> shared. There is really no reason this should differ anyhow.
>
> https://github.com/jgunthorpe/linux/commits/iommu_pt_arm64/
>
> cover-letter: Organize SMMUv3 the invalidation flow so iommupt can use it
>
> Jason