From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E06E13A5431 for ; Fri, 1 May 2026 12:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777639489; cv=none; b=KmctncYy6FCuYNkoI2A7x5MZCYg5hwWVpN2BMhhlpIgdSWJrWxFQs0iKLbXv1o40DTDqZ605Qx83ED70pfREQCZj/FCQoHCNYegLkAXJnFELUDmqgVqfmT7LZ352hRIohX1w72eS8DbDiToXHyMg7+RmSI2r68pDTcseNLgf+GU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777639489; c=relaxed/simple; bh=6Yymezd7E/UB3QsnyrfM7fDI7+HVN1rOcGdLpyRqtwA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uKAFH/j1fFjFIPnrop0VEHAisUfsD9PfhB0L1ilhxOIU9DPTw3rlHAMImqoItvsFVEdLxmkEkFoENEp+DiBIyC/j1G5lArQ8/s+UIYOJ8WTmBltI9xapoq3NYcBxqEUnMEZsxRFfOPk7rhb+bscU+th0T3mGdIZ5rR+LiXlZIhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=eYMm7dB1; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="eYMm7dB1" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8f231f3b130so130540285a.3 for ; Fri, 01 May 2026 05:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1777639487; x=1778244287; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x+W1ujC/i2sYkXDbzkORn7Jew8iq3dGZCwNInAwZJio=; b=eYMm7dB1sNl93pZ+NDVyOhlUIiAcwJckP3Ci12cB3t+lVPmTGLOqi6tc5Ch195mfkW jix/OCYyMAdJ9wUrGl9i9TSoquuqEIdhiy+bWrTokyukKjF0hPgcQZeShqefL3NWxUnK yVW6007kEHi9xvlc1bTr6UNDpCBiE0YJ2Q//ErXWZ09sESZfixp2ZQWf+hL5LEADHECe r82IMOuR/NGpUrGj9AsosMputHfXH843IaRhUTR0Xi5T+VFOP9K9s8iBeHEauD7Fqzry Oaq28Fy5t6CodP9bHGrvagWWAqJ1IcY1zzXUp1/B0s0P7mOsD1Plq+Nw6lUMKbmZCXHn sMIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777639487; x=1778244287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x+W1ujC/i2sYkXDbzkORn7Jew8iq3dGZCwNInAwZJio=; b=XGTXXfb+21TeCZlaJfJj1DwWMFpmbnP5zMpLP4Aejy9osgVxY7yWxsV9helSI5tcXC xjr0EQreRyHyrG0CBhIwYAbyf/lbHy7j6cuEEt+JG+KwfPta0WAFBuYDujrER43NxMrp dkYGQtOM1YFY1Qoy7fJ6yCY1r+GA71U6TnX+/73FfD5XzcpFrQHAud+SXS4PCrss7AF4 scYqNhl1znrvIePN4jZhh7ldxx54ZRaWYwMfrp55ORBvTk+rm9e3IsGfzIzUm8Donh8e R3hFbC5IXC2Yn080BJAizD3ZJ49z0KFEUkkqnG0FbsQJ0y8E4NeW7arxpB7Ymn00F1eN Hdww== X-Forwarded-Encrypted: i=1; AFNElJ8nX21FaJ74HZvHscxjI8NmlHzep8xu+GxCFgWPWPyJv+doWENov3JlkZZy9W5TSpZV2DTslRdJsqRsP5k=@vger.kernel.org X-Gm-Message-State: AOJu0YzwlywNzEHeaE0yg9RuUbXp7T+f2/ZiIJ+WjnWVKIp7IhnNOy7G pq63+x3iy3PY20LOhAXlNUSeZftdKCPcPafnlmxZnHJdlZ8RbWmWkS4BgvVakwYPQZ4= X-Gm-Gg: AeBDievPRSCLQQP0Ra3gItSzAQ8DK8lO98pNQ70hsVTIeR8j0Pj41B3QY/Cj+LQNpw/ px053epFJB2AwJBeKWAwO5sgJO5GNjRSoC/eTP8UHu3sjrih+FNbN7V68nWF0uFYXGtuKou5gwx JcwwQYv0YJQHz5jlb0CFxQyjNfDc1A/0mj/rFFgZ10wlWCaXdaNMhwjbrcpwcPWWYWf2fDTWaIO P2fpWJfQNPNvxv5DQZxkWdVInBA9+WbvyIvQYmZXgRobtHvmFOI9wVn1M8P1D5tFIQs6s/pGBrh NxnbHFhKeIM8kG6bg5k4e1PJyetat2xgwV7nA7xTm2Yn+CM1kjrQ4wdtzQiundsS5XD/Z4SeGEW oQWzlh6ddP3qetnz4if+8GO6HqSSh5Z85mcyF7zzS0Oh+YAuHdTXeW7iUTOGJpboHzkjSdtE9nm W6vC1G/Tc4CpQWTttASXNJ4pkV4OrYnaeVI4qBkK5OlbaHpque7h8khsq5sU/gS46PsQhYXJYtH +/Yv7J0/G2BusNlNYzxe8rFqKw= X-Received: by 2002:a05:620a:6989:b0:8f0:a3f8:fb2d with SMTP id af79cd13be357-8fa869c827amr1076322085a.2.1777639486728; Fri, 01 May 2026 05:44:46 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2cd06f16sm155809085a.42.2026.05.01.05.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 05:44:46 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wInEb-000000059N4-2gid; Fri, 01 May 2026 09:44:45 -0300 Date: Fri, 1 May 2026 09:44:45 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, mark.rutland@arm.com, qperret@google.com, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 03/25] iommu/arm-smmu-v3: Split code with hyp Message-ID: <20260501124445.GC6912@ziepe.ca> References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-4-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501111928.259252-4-smostafa@google.com> On Fri, May 01, 2026 at 11:19:05AM +0000, Mostafa Saleh wrote: > +int arm_smmu_cmdq_build_cmd(u64 *cmd, struct arm_smmu_cmdq_ent *ent) > +{ > + memset(cmd, 0, 1 << CMDQ_ENT_SZ_SHIFT); > + cmd[0] |= FIELD_PREP(CMDQ_0_OP, ent->opcode); Hopefully I get to it today, but I am going to post a series that will move this logic into the headers while deleting arm_smmu_cmdq_ent. It should be directly usable for pkvm as well to achieve this same split without having to shove a giant inline into a header file. https://github.com/jgunthorpe/linux/commits/iommu_pt_arm64/ cover-letter: Remove SMMUv3 struct arm_smmu_cmdq_ent Jason