From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D35D63CB for ; Fri, 1 May 2026 12:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777639639; cv=none; b=gx+D1wLee2Xa5Uo5Uoo1c/rwsHXdYm5pBloretCTr/k11qir23U1SYLbknSYlYElt2GP7Zr3pp0XvS+GQX0FtwLVWyhG63SAEpdMMVWrnTOhP8BJhFZ2D6jo7fZR0yvFg8pcatNyjgAWBQDUiKnoiC2UN18dkq92trdCSvUOOW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777639639; c=relaxed/simple; bh=GVbC+W+06USeQejyjxxvPv8joUkpomif/D7x44Gf73U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f96Ngwjm5zF4P8Gc3/XonbHMsIkLBGBO6uB97qQf+ENYk20yCSgmPJ0t6SbTDkhVkDOGNoI/z5X4SrjGJciKUUqAhLVr5JJgy68Xbi6G/gbS4cQdLy+kNRVJpxLKQ8T5kYt2ThqJHXbhDI9/cNtTLH9nAgIGlGmjr84uyKPiczc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=LnP98MOp; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="LnP98MOp" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-899d6b7b073so19228226d6.2 for ; Fri, 01 May 2026 05:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1777639637; x=1778244437; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J6VnYrS4OpoYLvnXY1t3ZH4F+GKUvLaqlaowydMT7CM=; b=LnP98MOpV2IKEitcv6M0BrXe8sVApOPkQ0fxg6hg40qR2GmfKgGMxkr03mcrrYjWHB hdx9/gmlZUSl6uN1ZD0IiOrvAz3WX0q8MWL31nU6rA+ucJrtOE80EE1nZkadx9l596rj nOtdbrFFmxMAVUvAHqg+ci77Ag87/VUDyC4/hY8HKHiDOQi2SLKcuhLxgeM0jNPQsKEH bDomge63FtzdkQeKr0OSStIwNvUHyGoL/9BT4PYnG5NhgQIkH01pgQz/aIp7PS118eXp nGeLOl2K48XSO3p7OiPlX9G4EYz34Y1721J4Zy6mthAmB40ehKF5TBjdPUQgn1YyBN1X KJfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777639637; x=1778244437; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J6VnYrS4OpoYLvnXY1t3ZH4F+GKUvLaqlaowydMT7CM=; b=OGmTxnDXqMF2UQUg/Jqr1ZaE5gc4iLkg26RpQWZ/ylkZyCkDMG4xuSOcfvyS8sk3+M as9/YM7ErQGp+BB2Wyl7Pzj+OCz9x96N5Jb/Ua/0LKSqe08F7gv8o/gO1w6L0q04vh1h 9f/OlUQ5S5DJChFFeAKw1UOhHi32Gn4uCuYQ6oE9pWddxGoEhrHyjgi77K9+ihyZB1Bv j1tn5pkBJdilqBCYJ5Q2VEGSFWcSy8WUcIxohxD4J3MXAfli6T/XCLwpLD/9TTEj2RmA pCjwpfpz8Gkq9HxRyAmji4tszNTcoSIBkssseuIavjGw3VaUb98UDkHw7fA9Pc+skJqe q3aA== X-Forwarded-Encrypted: i=1; AFNElJ/gly0ytjjpkeCe36OvAsWIS3DiFpszp5nFvEXTiVnJydf4U2zJi9a6Kmx/seV8L0wNY6eDJ3wnnpchSgo=@vger.kernel.org X-Gm-Message-State: AOJu0YwrJu6UglICcYTuO0Rr3yQKVK0JXesByh3tin0//xQcZGK+f+hX ElYrPcwg+YTiTVwVMT0Z/1srtBW1ICAFDkJgMGs3yemvJZyeov2Qs6tIojs0eR1w0Q8= X-Gm-Gg: AeBDiesERr//HnWF6JFmA4iRcy6KF5RYlO6kPmA7SEUPzQZ9ROt41KXJ0zJ/oui7HW1 dixj6+y1Q7AsdhehLs1Tc4S7RF5gCQ4Mba0T9nSW7PBL/u8D1pzqpGs6HQSjhYwbQo6buwpiBW7 7FxBNSXQPJQ1Qa0hxg2EEL7jA5QBz+srVuujZCKeSXrXI2H/Sksw7E5J1CPMlrH+wCgdFwuSVcp Fqsm1YPq6XFqZw9BTV8kFt3xgJB82yxVgEHZTklbSToiyW2ISWDFIPCei3tp0ZwRIL8V7CGwS3u w1jpwvZXA2KvsxOMKsyjBqoyfeHb8Xapaa75zockbQfN3ZyxzlQa9kapgF9btLybEBjmrl4CCNf hbP7xm1C4uQ4s6oCLzYpdjjWdOVdE2akgoJTvSBxhuNnIJL1fDCwXNmM9sc4yfDkAKa1Ej64nL5 glhyDmcpMHFeUDpckg5axCnOKzigpXtM8jS0G83jRfoEt93tlGJ6nIW/wFNqUWmMjjcRPVNtyCR BgDVIxpGJh95Hye X-Received: by 2002:ad4:5769:0:b0:8a1:34df:bbe3 with SMTP id 6a1803df08f44-8b3fe795fb9mr109078226d6.28.1777639637543; Fri, 01 May 2026 05:47:17 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53c0e6d72sm25671376d6.26.2026.05.01.05.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 05:47:17 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wInH2-000000059zk-2EQo; Fri, 01 May 2026 09:47:16 -0300 Date: Fri, 1 May 2026 09:47:16 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, joro@8bytes.org, jean-philippe@linaro.org, mark.rutland@arm.com, qperret@google.com, tabba@google.com, vdonnefort@google.com, sebastianene@google.com, keirf@google.com Subject: Re: [PATCH v6 05/25] iommu/arm-smmu-v3: Move IDR parsing to common functions Message-ID: <20260501124716.GD6912@ziepe.ca> References: <20260501111928.259252-1-smostafa@google.com> <20260501111928.259252-6-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501111928.259252-6-smostafa@google.com> On Fri, May 01, 2026 at 11:19:07AM +0000, Mostafa Saleh wrote: > Move parsing of IDRs to functions so that it can be re-used > +unsigned long smmu_idr5_to_pgsize(u32 reg) > +{ > + unsigned long pgsize_bitmap = 0; > + > + if (reg & IDR5_GRAN64K) > + pgsize_bitmap |= SZ_64K | SZ_512M; > + if (reg & IDR5_GRAN16K) > + pgsize_bitmap |= SZ_16K | SZ_32M; > + if (reg & IDR5_GRAN4K) > + pgsize_bitmap |= SZ_4K | SZ_2M | SZ_1G; > + return pgsize_bitmap; > +} I think this should include: > + smmu->oas = smmu_idr5_to_oas(reg); > + if (smmu->oas == 52) > smmu->pgsize_bitmap |= 1ULL << 42; /* 4TB */ > - break; ie it should return the supported page sizes by inspecting all the idrs and don't leave this tricky bit to be open coded.. Jason