From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9DB3C0604 for ; Fri, 1 May 2026 14:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777644007; cv=none; b=LUX20AufHg4YJR2pwkv3rmh9oYLTY7IvEFhdt3qv/0dvGTUMI9J4k/7mb0UfHNUqz+DYesANIy1HfwEdP0WR9DioAvFVnbGwo/vFOwqFm/O7MwKwpK9a7mwgK8x30KJC5Mc/6vVkZE/xegry0+5nsyzALMd93IqhmFm4aObiNhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777644007; c=relaxed/simple; bh=wr1OnFxz/Ai5i4NfAvoS0ChTxZI8nshMYVtsLOtw7bM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kJQfEYxQi3yyHf8rfxERyMjq4oXmw9E2bcTO1+utkIo9MXcGXriPm1Of9q6hh57aZ9GrhSy04EBzPu93FJlK+zxz0YZwWMa2LVP5wugAoBuJ0Zr9iQCyqfhPhcPB2O36K4mmzRh2q6KQPBB25IKypS3Dma0bQz8fbej0Nww0ueY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cNsw21jp; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cNsw21jp" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4890d945eb4so17615615e9.0 for ; Fri, 01 May 2026 07:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777644004; x=1778248804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/yRGhlBCY/TW5XKeeufbyghz250gEgHu0HIRBXKkoYQ=; b=cNsw21jpSnOytV59SVtqkExEglKmvBTMvkjf3Lr6djzZHTAVQD7PA7JWMjZ1hYvSv5 sAXqMpleKYEgqhLkmEamXLT67iSD+quHviMNEg2UEseHgWkRcWRAH9HMPR3rSC5B8943 SgSwH/BnuRmAPKdWmex9T/9NEUWbPWlUk3BYgQugJdbE/lWmBuPCRb0dxjKtZCV3sk7J VEjlNubKf4C0+DDPvgkbnDMYcdOKxQrp+fKjaxQ6LnSfS1fb2hUJry9NGEypy8laZInF jQ83niuLHSTDPpObYCf2xlq15s3AFK58Te1PffIDO30VCpDqL/2NxldQ4Q3V+DF8iMkJ SsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777644004; x=1778248804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/yRGhlBCY/TW5XKeeufbyghz250gEgHu0HIRBXKkoYQ=; b=rHwpa4L3rLRj9tF45HlgDuOSdyxTFkq7mKgvEvweHpiJHuNiZHvlD52JguYRUeEK9p 2dMmZebWVfqn4hLBr+ldgNzdMMeBuxLUxpCdRb2afLjUpBV20PNffz8kDafTaQx2WKIo TtVAbRwsGJo21iTLhIlXGWJExjl043z5ypKUYHUdsGQ2mod71XUwULbVfDmNrvBQF3p4 Fb6QiQOBxbs1hnPDtMBGNCuqGyC3kczaq4D1DI1dEGdT8M0WCfHuQfsSZYMecKrUtLzY h6W8UjPKOGbE+VBc2Y+/TKGJNwcbSLSOuw8xaFIuye8g7dPOnAxwVdLgDlXc5RK6dB2x TOJQ== X-Forwarded-Encrypted: i=1; AFNElJ8m7yIiJfnMuP7kEWPrlklYgWhtGI1sLgO2EQxUmdoVzC7Q6InASFDZTJ/p0iZzJ5bDwu1Z54evI9fEc0U=@vger.kernel.org X-Gm-Message-State: AOJu0YwiIVeRhTEFWZz57tfyo2UeAks5sZOkAYhAWt4Qp5LiAZaz0aUJ 7djZbQ8PiX6rfwm6vGazCszrWcWO7nsat4lLDjjhOWtwkDkismiD2Sx6 X-Gm-Gg: AeBDievxAxzxrjgyGeeLVqNNPhLrb+PzQ1sE1WF3E0etekRcEtRbEcZ5FFaXdhAmrtU PmyOb6/XG4kSxDWACl448/yiAdPMxR9miVsB3mr85pR2jgq3/jeS+nOqLVzwz220CdDbv5RWwDp 98eP3sHAQr3ZJEWO8h0YmbvAvzkLiGDeaeaoH6AGRd4uYR12UQE5mQufnOvTMFZak5/caiJKDy0 pvuym96/zzbdior+4ft9Wex2//H643CkRumjRJwPRe9aQVFfUyJwy7KSGsxyY27q/593AIbVmvK tvuRf2S8QSTOWyrEF4GFRzjcy8fjCjsXGwJCSu/6DoBxZCmisfJYcnaZplLnPOXLMVhhbv0eQ3U INPxtiSHnXPwJcC+K89LeOHolmwb3KMrUQAh5mpMydDhuxu8hRZt/2dGXJxI1W8PqjenjNDz1gi 1/iaf+aJWz8WR9Uco31siPwzo9V7+UoyL4zgUueizh30i6W2SUDuwwZfEW5A3WmX813sSpUnh72 S+3 X-Received: by 2002:a05:600c:34c6:b0:48a:761:5816 with SMTP id 5b1f17b1804b1-48a85e7c80amr105322175e9.8.1777644003492; Fri, 01 May 2026 07:00:03 -0700 (PDT) Received: from localhost.localdomain (ns31537009.ip-141-94-163.eu. [141.94.163.193]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a98b768fdsm4823539f8f.33.2026.05.01.07.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 07:00:02 -0700 (PDT) From: John Madieu To: broonie@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, carlos.song@nxp.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, John Madieu Subject: [PATCH 3/3] spi: imx: Propagate prepare_transfer() error from spi_imx_setupxfer() Date: Fri, 1 May 2026 13:59:51 +0000 Message-Id: <20260501135951.2416527-4-john.madieu@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260501135951.2416527-1-john.madieu@gmail.com> References: <20260501135951.2416527-1-john.madieu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit spi_imx_setupxfer() calls the per-variant prepare_transfer() callback and returns 0 unconditionally: spi_imx->devtype_data->prepare_transfer(spi_imx, spi, t); return 0; mx51_ecspi_prepare_transfer() can return -EINVAL when the requested word_delay does not fit in MX51_ECSPI_PERIOD_MASK. The error is detected after a partial set of register writes (CTRL: BL, clkdiv, SMC), so the controller is left in a partially-configured state and the transfer is then submitted as if setup succeeded. Propagate the return value. The other variants' prepare_transfer callbacks all return 0, so this is a no-op for them. Signed-off-by: John Madieu --- drivers/spi/spi-imx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 4e3dbd01d619..480d1e8b281f 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1382,9 +1382,7 @@ static int spi_imx_setupxfer(struct spi_device *spi, spi_imx->target_burst = t->len; } - spi_imx->devtype_data->prepare_transfer(spi_imx, spi, t); - - return 0; + return spi_imx->devtype_data->prepare_transfer(spi_imx, spi, t); } static void spi_imx_sdma_exit(struct spi_imx_data *spi_imx) -- 2.25.1