From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB790366DB5 for ; Fri, 1 May 2026 09:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777626725; cv=none; b=ohAT8EY8WJA3RbNhOKbA7hIdPNKaaWi6cOAnrsFbFGT4aC5KVbmqbc6tlP2elz3T6jJ83x82M3VHYTWXW38T1ffgle+gpBBePE7IIUMPjWHnl3EqnxuwQ/SnBauQhQCXYAhYRQjX90m5Y/sFoBwiJlfKL2iuo/guM7jRt10dRcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777626725; c=relaxed/simple; bh=tv6gO2sKkDzFZ+AnUu08+UvNMCj4XOGqQLe9r4F5Ag8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bUeiSkX/GI82XJD5tW0VxTbJUkqPHG7r4hBC71+0SVrAKDg0inIyUo6Bp9KmU03dFwwgdHS4tzBdAnP/ptMe4V89UUhH0g2PDKj2qHHQzGHZTD1QlOEZSYejKTGAn7rVuhJJ8P5dThAMi54lzxn/8HzVDiMoF4QjAs6jZlF29Lo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jN8yhnf/; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jN8yhnf/" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-449e96a8a80so761109f8f.3 for ; Fri, 01 May 2026 02:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777626722; x=1778231522; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=pcgbMr8730ZfrhMoIH0vuIIFReC/Ooz9fhLzTLVg0mA=; b=jN8yhnf/+G+bv9BjdSnxDhvhgVOaLZpSLuq06OTVQ3URQSne/qMLrouykm5Rb4xot7 aE8IL7WvWtL4PZ5iL8yrShGKqESUmaWFg/Lrs4G3Qfna1Pl4KxFbajIpdItySfmRF+9R BEd6Bneirs75RgkcMxKDEUthb9Xi4PEpab1gCRX5UCMcH1leoMhiYZ+aa0jopJKVhfGc yvbMG8L3MkWE8A6TVl+yavvPqR2PvStLJNmB+jChPN586ONF4L3NnetlVz9AeJ5G/WpP wpy4iWDR8gs81NDrbDcWYzP8UdFMeaWwt0v3NlsPFHTKMyCY3rocAuOawF32VtyLz/nh oU0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777626722; x=1778231522; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pcgbMr8730ZfrhMoIH0vuIIFReC/Ooz9fhLzTLVg0mA=; b=mM6rncK4fu8tbJ5TSFjqCM/mAoLzzmsFf+S6ZCVNVmR0nERZpS79l4B8rhAT0esuVb NoNCJ8XHTM+hH37zCPLwUyg6VfWSmHIz4T/Ib5cNCw5dRLD3Gl3saDrvMNm+y8MvgGbC yFtmS8qt06Iv2K19aiQJuTwAWkf33ZXWzxj4tuksdun1VKaEyrYKBtE+sQ4WH97HnDZE DzWy/Dvi7iClMg0sKmowZrhk9zSJpcfD2uO8evFPGeEjLficKbDU++vwWDVSWIeB0nJi cS8hKTEMSc3S8Obd5MPrmZaN+oWq0xYNOCsv+bl/SIhsRk7cHbI/1LAEIF6lyO3V+jVk qs+A== X-Forwarded-Encrypted: i=1; AFNElJ98iu6qr9oZsmfFhqunLI5W2d/nPO3Voi32X3mpgTLpE/zGro0BPoBi51FhmipAsGv2HlpZrJLtNRWoMQc=@vger.kernel.org X-Gm-Message-State: AOJu0YwtEPZQr0rTCGeo2BxN/F9WjNX2LH+64bx2rkkUtFyFCjXzbRQo qiSF/Vg0fVTw/zsV8ZkZibYBh40fyZXUTXxUfReo+LqL9kjOZwkkRBHg X-Gm-Gg: AeBDievzdfhio+xJp7MkU9IPIuvnLFKGLKuVzpRb0oAUc/Iwhm3Wf2x4rSqv6LKZygz 9JT6jbawN6ozWnC0IQekVbw1poCkWwhAgBEtBcIIFwaEOjAHuNb+lAyUwA6qU0T3PcypwMK+HgM ScXpr/8jws0f+wktMyAqStLRDJlXj6RBV1k6wOZVD8S6+2j1RGnIfQx6EgDPgGXT/fLri4Fvjqa rGAuSks2qv9bOksavRbJ5qBn46ZlITv4YKi3WD/q+EW/HddNjY4a5Gt/8l9n7j3IW6FqMk/V1DA imngQnv70ZAifFMM8fGOtOtxiphFc8khD4TjxjVj8lvgCHoh4Q7mmTwfTWDztJA8KnJ04KQthPH b5fT/6F+05jCLT9eAtNvUI6nDbkVZDLl4cwe/zV29IKGl0enGPHQjzhrHRuPkWUcWiuAQlhw046 B8rsxeWX4VnPHg3+KNiXjk1aTqj1/uag== X-Received: by 2002:a05:6000:2002:b0:43c:f66e:f24 with SMTP id ffacd0b85a97d-4493fa018fcmr10085402f8f.35.1777626721968; Fri, 01 May 2026 02:12:01 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a8f51bac8sm3861853f8f.16.2026.05.01.02.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:12:01 -0700 (PDT) Date: Fri, 1 May 2026 12:11:57 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Namjae Jeon Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Amir Goldstein , Christoph Hellwig Subject: fs/ntfs/attrlist.c:126 ntfs_attrlist_entry_add() warn: variable dereferenced before check 'ni' (see line 122) Message-ID: <202605011540.0FJWFGIn-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 26fd6bff2c050196005312d1d306889220952a99 commit: 47503f989736d6c4c9f8bfca1c28d267473ccd4b ntfs: add Kconfig and Makefile config: x86_64-randconfig-161-20260501 (https://download.01.org/0day-ci/archive/20260501/202605011540.0FJWFGIn-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9065-ge9cc34fd If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: 47503f989736 ("ntfs: add Kconfig and Makefile") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202605011540.0FJWFGIn-lkp@intel.com/ New smatch warnings: fs/ntfs/attrlist.c:126 ntfs_attrlist_entry_add() warn: variable dereferenced before check 'ni' (see line 122) fs/ntfs/attrlist.c:126 ntfs_attrlist_entry_add() warn: variable dereferenced before check 'attr' (see line 122) fs/ntfs/attrib.c:2807 ntfs_attr_open() warn: variable dereferenced before check 'ni' (see line 2804) Old smatch warnings: fs/ntfs/attrib.c:2115 ntfs_resident_attr_record_add() warn: variable dereferenced before check 'ni' (see line 2111) fs/ntfs/attrib.c:2237 ntfs_non_resident_attr_record_add() warn: variable dereferenced before check 'ni' (see line 2232) fs/ntfs/attrib.c:4951 ntfs_attr_remove() warn: variable dereferenced before check 'ni' (see line 4950) vim +/ni +126 fs/ntfs/attrlist.c 495e90fa334828d Namjae Jeon 2026-02-13 112 int ntfs_attrlist_entry_add(struct ntfs_inode *ni, struct attr_record *attr) 495e90fa334828d Namjae Jeon 2026-02-13 113 { 495e90fa334828d Namjae Jeon 2026-02-13 114 struct attr_list_entry *ale; 495e90fa334828d Namjae Jeon 2026-02-13 115 __le64 mref; 495e90fa334828d Namjae Jeon 2026-02-13 116 struct ntfs_attr_search_ctx *ctx; 495e90fa334828d Namjae Jeon 2026-02-13 117 u8 *new_al; 495e90fa334828d Namjae Jeon 2026-02-13 118 int entry_len, entry_offset, err; 495e90fa334828d Namjae Jeon 2026-02-13 119 struct mft_record *ni_mrec; 495e90fa334828d Namjae Jeon 2026-02-13 120 u8 *old_al; 495e90fa334828d Namjae Jeon 2026-02-13 121 495e90fa334828d Namjae Jeon 2026-02-13 @122 ntfs_debug("Entering for inode 0x%llx, attr 0x%x.\n", 495e90fa334828d Namjae Jeon 2026-02-13 123 (long long) ni->mft_no, ^^^^^^^^^^ 495e90fa334828d Namjae Jeon 2026-02-13 124 (unsigned int) le32_to_cpu(attr->type)); 495e90fa334828d Namjae Jeon 2026-02-13 125 495e90fa334828d Namjae Jeon 2026-02-13 @126 if (!ni || !attr) { ^^^ Checked too late. 495e90fa334828d Namjae Jeon 2026-02-13 127 ntfs_debug("Invalid arguments.\n"); 495e90fa334828d Namjae Jeon 2026-02-13 128 return -EINVAL; 495e90fa334828d Namjae Jeon 2026-02-13 129 } 495e90fa334828d Namjae Jeon 2026-02-13 130 495e90fa334828d Namjae Jeon 2026-02-13 131 ni_mrec = map_mft_record(ni); 495e90fa334828d Namjae Jeon 2026-02-13 132 if (IS_ERR(ni_mrec)) { 495e90fa334828d Namjae Jeon 2026-02-13 133 ntfs_debug("Invalid arguments.\n"); 495e90fa334828d Namjae Jeon 2026-02-13 134 return -EIO; 495e90fa334828d Namjae Jeon 2026-02-13 135 } 495e90fa334828d Namjae Jeon 2026-02-13 136 495e90fa334828d Namjae Jeon 2026-02-13 137 mref = MK_LE_MREF(ni->mft_no, le16_to_cpu(ni_mrec->sequence_number)); 495e90fa334828d Namjae Jeon 2026-02-13 138 unmap_mft_record(ni); 495e90fa334828d Namjae Jeon 2026-02-13 139 495e90fa334828d Namjae Jeon 2026-02-13 140 if (ni->nr_extents == -1) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki