From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 097C3423142 for ; Fri, 1 May 2026 21:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777670000; cv=none; b=Hp2j3aBloqK1oOmBkrmwOC/6UNUzzTSh2HTlf7XNwlAoScmlN64ay9j6PaCNA03+me1oKjF3OsTDqXEgf6HsmWHa0pv3lcWaU3i/yjbftaX/HBBQQ7UX/aesUYpT52V3sL3sTeXJaNp+T4lHxlDZBxagwegua/02Cz3+NitqnRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777670000; c=relaxed/simple; bh=NvbUB9w6sa+4Wu7Si19/S3bep7cng1nAYKPLebrqTyI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OOVBx33olTay3FDXdaXL+abaDcerSLtdQIzs4N8O1Ak5o8d2fxs0jJeBiO+PqZVi75lMQ5TPg1jUE2LE1Ek8jjyYZ/pww0GVBoHSeVvz6PSicq92MF6Tv8BLL/a4D3EVisGEXxJUUzNShXXjxbfYbT74f2GOocSHOK2AMKeeMUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c26QGOFp; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c26QGOFp" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so18531805e9.0 for ; Fri, 01 May 2026 14:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777669997; x=1778274797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Yg5m7oNPpPp+73S0JR0V2pwRtY170K+LXcVuROlxjE4=; b=c26QGOFp9StWg4mOBgWstMfOYhSVuqyIXj8gjhXDKTF+IeusP73OJK4Ty15yadNNco cjSf0R74llTAPt135L/1uSQ6p4RSTm4FLCsHtGLC89qYX8MFH/0lI1qotpctPjOMHD6v cbzfoQ8X4yivIjc4RHApNzuLwImsNCVHUhEPz/tu87r1fI3Iikm8AhDOhtA5fYtVN/v8 tfQ+AklYERgL3lrw/nIC3qpfNlJWuDgU/EdEUFse/qeaJ1WmLWU8Oeft5jH8vi2H1tQE 7dXxnOHrU+2k+qCZ2XttzC1YhYMQOm4htsMb8oQCqs3iGrtnyhpg4Sd390GAgJBxFTar lFLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777669997; x=1778274797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Yg5m7oNPpPp+73S0JR0V2pwRtY170K+LXcVuROlxjE4=; b=MKXvUtDFKsjib5g/ULg9x7eTB94moflHsQ8HxHjIYo2LvJU4rfpNGUtTtpTKhs8p9E fvyYMeurD3T/5YHLJD2dLulMy1bGOvoNAQbcB0POehjthT22pmrFkpL37BmKe1q47qnk yvkIogsnqXeENbpUtW4UDBvhnMM4Gdlhud9nxyjnwBNkDsKegHUXEIBgvj0QMF5JZHXr agZSwE0GwUxLgKcL9AKnAJWIfYRwcJdk0AtOD2cUUOJGuOdViaz5rH91dF0yNGdCXc2v uSNf6RB0DQSgBV411kvgz0WweM1bhSlvSOfufP5HTQztJdg5+INk5DPwvYReLssaT9qj /PmQ== X-Forwarded-Encrypted: i=1; AFNElJ83wpoCFO3Ouc/c9MrrWEdzimtVptvtjy0PWJ+9Adx+uyhAFzver06OdxnQYqw0X7HSafL85VQrE2CfbdU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd7GeoEXqmfeCdFwUba6rZH+aFjh1rPrql0SUrQsvZD+H1BZpk 3hGxXZzzUlt8ZX4LaXaPQ/3yCPHhkewSBy0LY6+1SWE3/AqAnd4e7B94K75VzOgB X-Gm-Gg: AeBDieuzNIgSt2RiarWpY2L6XxG8RE0LXW2/kQsNm9sRpHz+M7Ldpl88tWXGdGhH2Nl S4jxDj4OqC/zZ3YnS4zDVWa9kmEYc87qSMv8GyHKAWUqb63dzf7/UCBpJGU2TRvyeioCBnznyo9 jvlV0CFLkshoIlZARMZeTAqefVlw5/7mm+GiWZCkQoZuZT71ZuXHLaaBbJD5VxK5Hjz/79Kq94h yMpRfbHpY8sd90hcXdF96Lfsqjkly8WERFgJQ3dLD2SQ68FYRVI2+0N3WKbry8YcjDrZAe/kgjb v9PLAQWFIWdVoCvUQoqA8CCe+SKAa2IRCLyefcKBotM9jM3iHxhNjsjM3/1dO8qJ/q1XAlJPOfZ FtsaUPe3PnSh66JEi3SzFPIsxCFu79t75I+cYHEolPQ1HCFqRDslA+81YcPUR3VdNqjsyFuiRFr 2m5NXqMhgaCjRzVMpZKejskjtmji/mejvKeRnuyoxplSKnSNS8JN+DJL+lsyLD3sgsoY0PucDGN /Q= X-Received: by 2002:a05:600c:c058:b0:488:ac01:72b6 with SMTP id 5b1f17b1804b1-48a9866a998mr8312805e9.21.1777669997185; Fri, 01 May 2026 14:13:17 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fea704asm19701415e9.11.2026.05.01.14.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 14:13:16 -0700 (PDT) Date: Fri, 1 May 2026 22:13:15 +0100 From: David Laight To: Qian-Yu Lin Cc: Steven Rostedt , mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] trace_printk: replace _______STR with __UNIQUE_ID(STR) Message-ID: <20260501221315.1f709d6d@pumpkin> In-Reply-To: References: <20260429165707.7020-1-tiffany019230@gmail.com> <20260429134226.49e95e9d@robin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 1 May 2026 22:40:17 +0800 Qian-Yu Lin wrote: ... > Yes. I measured compile time of kernel/trace/ring_buffer_benchmark.o > after make clean on an x86_64 machine running Ubuntu 24.04 LTS: > > - Original _______STR: 49.8s > - v1 with __UNIQUE_ID (compiler.h): 53.5s > - compound literal (no extra include): 33.2s That difference looks far to big to me. And the times are far too large to be measuring the actual compile time. > > I propose using a compound literal in v2, which eliminates the local > variable entirely and requires no extra include: > > #define trace_printk(fmt, ...) \ > do { \ > if (sizeof((char[]) \ > {__stringify((__VA_ARGS__))}) > 3) \ > do_trace_printk(fmt, ##__VA_ARGS__); \ There has to be a better way to align that code. Although you should be able to use: if (sizeof __stringify((__VA_ARGS__)) > 3) (I've omitted one set of parenthesis for clarity) You could change __stringify() to work with __VA_ARGS__ the you don't need the extra (); this works fine: #define _x(...) #__VA_ARGS__ #define x(...) _x(__VA_ARGS__) #define z abcd int a = sizeof x(z, v); /* 8 */ See: https://godbolt.org/z/zo4h4nr9b -- David > else \ > trace_puts(fmt); \ > } while (0) > > This fully eliminates the shadowing risk without any compile overhead. > > Qian-Yu > > > > > > > > #include > > > #include > > > #include > > > @@ -84,15 +85,18 @@ do { \ > > > * let gcc optimize the rest. > > > */ > > > > > > -#define trace_printk(fmt, ...) \ > > > +#define ___trace_printk(fmt, str, ...) \ > > > do { \ > > > - char _______STR[] = __stringify((__VA_ARGS__)); \ > > > - if (sizeof(_______STR) > 3) \ > > > + char str[] = __stringify((__VA_ARGS__)); \ > > > + if (sizeof(str) > 3) \ > > > do_trace_printk(fmt, ##__VA_ARGS__); \ > > > else \ > > > trace_puts(fmt); \ > > > } while (0) > > > > > > +#define trace_printk(fmt, ...) \ > > > + ___trace_printk(fmt, __UNIQUE_ID(str), ##__VA_ARGS__) > > > + > > > #define do_trace_printk(fmt, args...) \ > > > do { \ > > > static const char *trace_printk_fmt __used \ > >