From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCD0037F8CF for ; Fri, 1 May 2026 23:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777679080; cv=none; b=mhAMj+e9cAFLhG0u0i/agpmNjwl3/sr3htoDfbqu3xWGKs2KNGnyPH9Hip7+OT+/LRUkL2IJklTo23ZyWa7xeuCqK2bJ2y/Dlr4YBIMdB5dH81EEdIJpFThcnaxuR20jfKvg84KRaf5PCqBkrckFQPSw7VHjHT5eNJa0kFocKGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777679080; c=relaxed/simple; bh=6JvE1f7EmX/ZPGkZQ/CgU6ldSErkDjEHW6Wy6v3sUvw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bi3z+06qyIXxEnJb8Z7/UQrJxIyPKEXGf0piXtVxtBHI5XuY/d24inquCgHuR59upr8JWqjmzCIfXkx94u5dWYaJ0gU4H8x/SnbcrxoKVqAM/PIdNnEKbuf3Ql4JrIMacyLwWGQLO6uOuhE5n6oUHk/xuWXWBE4jYY3cVSJBnl8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuJ+lX8/; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuJ+lX8/" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35fb16e56efso1591228a91.2 for ; Fri, 01 May 2026 16:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777679077; x=1778283877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0cMvZy0EdvXdtjZIbYJP2hPzOnX4/VXPNfSPuv9FZzE=; b=OuJ+lX8/2gKlLpXylTo6vSMZXBo4LZ8wJE4sO6YpGZ6D2PpwWi4SmAoe3+X2x2wdCm uItBpANy57v6l9JG5WQaHJPhlQpL9o7XI17B4LTkV/GXwQGymPblfiyeNzy5o+PyACnH lJp8f3AWiALK+cBfQv0glC8yYoL5Oc9INOKHBO/nBokwyGikMyi1ttywOIYMj60EM/10 dq9qVnorzoOrmXspgi5pp6F/9LCaMtSHy3AY6bDOgR98fu4O12FaDyDfB11Y9KkbLgkC JkE3SmJ8FKs5l+d2aFnTt/88aCzgQyfEzs2cl0l723viYGYcOWDZviUaNGXLx1n+RdFp /LcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777679077; x=1778283877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0cMvZy0EdvXdtjZIbYJP2hPzOnX4/VXPNfSPuv9FZzE=; b=Oiam+AYSVl4rQs/LvW1KRhWo5CaDXEofAm25O2bXc6zUWg2J3y3i90LsfTfG2T9MZk FW8qnYHr9dVITYDY3O1cv/+wJKZNwR+P5fFgNA/RqFdZ5LqA5dGzH3i1NwjSR/7jZm1z S02ZtXd0KimXNnr/AVRPfUZC12iyLtak84GHabJAcjzIW2VUTor3Txj+kfnb+KnWZnsd g/VoVcG/W1JNAKnu+kJ0Vj/jZwnREk74Q1P4vx8o5sUWqn3DlSlgTcvFmdgtiWz6mIIc oovQg7fRPT8l3gbqnpThYp/Gn18UPTUzJkfUu2Dx6VqdVIvaX16sTJCC1VH9MaulJtma y6fw== X-Forwarded-Encrypted: i=1; AFNElJ8yceIXJXotHHItd/1oK1pfRZTfxxRpRKHvBPKqX3wxdzU8ts4y0M5M6+VnJZ5ytdEMOn0wbjbmdTwHB9w=@vger.kernel.org X-Gm-Message-State: AOJu0YzayDnOmH07H88ZUeQswQyigpPRv9k8co9Uhfw3BxlNTQYsTnCU pIW35xw6EjEzYHhombemjxL55Am0OTv0I1oyycHB5KpOXOif0C2Bscai X-Gm-Gg: AeBDiet9thzfu+AeVMFYjiAGbEVCU6iuY0A8x0jLm/NEmrmnjYJuVif2k/kwjbqVaS0 ztjgCYNHVdMxjk2Jw1xaqjLCP5702PfliBfEuw+xcQ0vmP0HzZhIH1qtGb2kofiYWzWQ3tlss9v hX7MJ+Qjee0hoMhmd2UXeAucPam2uPS9Uqx6hSoBJ7kod2FXJy4xM69p9UnHcgnHT8Qhi+E7X+6 Avsx4fgDZns7ypqMx1fRFDx9Y2U0LCtnFH292kw2xziNev8Ao3l+fch20sub8mol0ReBmPmBNbS ip3gjtKBkCyfRwj6fb5SelCjHZK7uJwRgowZuXK26jtjSRH9YoKiRFmQxLTU9061rAm5IKYG2DD bpKgFIu9/GRPUPoYhJXUEMC/bvuvwNguRuBxRKkxw3vcWD1uSlNkoNgKmlkhkWqbeDxrgMfdaIx tV2Z4+TPYBW0QxRY7GVmBS2A4iMS/AMg== X-Received: by 2002:a17:90b:530b:b0:35d:a3b4:2f00 with SMTP id 98e67ed59e1d1-3650cdd0ab3mr1204489a91.8.1777679076659; Fri, 01 May 2026 16:44:36 -0700 (PDT) Received: from localhost ([121.237.249.41]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364d1c70d8csm10098961a91.13.2026.05.01.16.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 16:44:36 -0700 (PDT) From: Coiby Xu To: kexec@lists.infradead.org Cc: Andrew Morton , Sourabh Jain , Baoquan He , Dave Young , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Coiby Xu , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 5/9] crash_dump: Free temporary dm-crypt keys_header buffer in kdump kernel Date: Sat, 2 May 2026 07:43:34 +0800 Message-ID: <20260501234342.2518281-6-coiby.xu@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260501234342.2518281-1-coiby.xu@gmail.com> References: <20260501234342.2518281-1-coiby.xu@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Although we expect the system to reboot immediately after vmcore dumping is finished, it's still good to free the temporary keys_header buffer. Fixes: 62f17d9df692 ("crash_dump: retrieve dm crypt keys in kdump kernel") Reported-by: Sourabh Jain Signed-off-by: Coiby Xu --- kernel/crash_dump_dm_crypt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c index a3e460714d23..72ae2dffb077 100644 --- a/kernel/crash_dump_dm_crypt.c +++ b/kernel/crash_dump_dm_crypt.c @@ -117,6 +117,7 @@ static int get_keys_from_kdump_reserved_memory(void) static int restore_dm_crypt_keys_to_thread_keyring(void) { + struct keys_header *keys_header __free(kfree_sensitive) = NULL; struct dm_crypt_key *key; size_t keys_header_size; key_ref_t keyring_ref; -- 2.54.0