From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA8CA20E023 for ; Sat, 2 May 2026 00:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777681134; cv=none; b=raW/3erHtC8i/3oajvzaBw618qfRV0zkP2nB5FvFcshAHNzxwy7HMenfSTta/314woBbfPoGyp5DB8QZytzGL5uWW7IhwXs1qeK3OR1Ww0rsNMj5WwXaqgV6YepE8fIrJhpWpG8e5+uGMTaoq7VqCUXUOdZED7niXrvPwsDlCmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777681134; c=relaxed/simple; bh=y1+1PgBpg/ncxoTXj6GazTBqlwA61vlKg3PHbzBD0Nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tiwK/rYpnIZEvFOgetHNl6X0NCLbOUSUZ4CGUzVS8zESc9if60UfreSxmnuO2TI2Y8BNRoWaVCHW6hDi0/l6oPYLBaWB2FN/I1W6qTUehOG3IY1vCf13IEKvTxVuk4soSc+mBCVl1brT2ttrg44gL58lXdYGMZxxm97axgpzbDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=J7as3Jis; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="J7as3Jis" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so3079490eec.1 for ; Fri, 01 May 2026 17:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1777681132; x=1778285932; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/j0dQzsRSy6gRqEH0V0qrvXR4yldNaPgWZDBeR7Lu5c=; b=J7as3JisKmfr/xOQ+W7N2RRGmWE9MmLJZ3TY+/WkPx5ij5HoKvDtkjt4Tx2KOQYUtx 04Oq0hP1GqNvsqcaLdSnZOgMGmuyGrnMwYjpijB/ruUyUSga7TUxu8RAylycQYlhMgcE GK8OfRMleUEZ723klKlQLRei2QlgWgsljcEzZ2f9W2WVwOddEtLrXbw9g/INCfsaWHoE J1iCuFS5Sm1cDofMMv4gOCR7JD/sZtqkdWPzVXo2xBbx2MAtHlFdSapm4XA64vWtPs8k GQjTgKCJCffer7hRdN3bEkPEPzTHIbqDlf5Jb+6yQ3knb66YN4k1kvXAtK5Kv2tXPpqi EImw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777681132; x=1778285932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/j0dQzsRSy6gRqEH0V0qrvXR4yldNaPgWZDBeR7Lu5c=; b=LFMbH1s0a41tTqaE4MO9kUHF0Nwn1nGHmxlwOWuztIoD5iYPoTtuC3hTaH0+dHl9vP MyCjweWz1JTSgjKvdBT1aZJbCeAwcrtO9fM0KHhocQz+gEfnOCUblRIH9R87NQyzODuo c6rQguKHVHXwyqQAnWjFwpLu2qvzGd5SWrL01BR2s7h+UjZg5p/laZUTsL3owWYLDrW3 HwcccIPnLLLr0kqLHMCUJtg6R5V76VCTpig2YJ/AuJToZqNBfylt/ZpNKurnlbLcFAd/ 7U4tESKFFhWoWsX5X3TxUn0Dn1A/eVvp5Bc3cOOT/sfDFiPknYexGedEpiLc8TNtthPR x4ZA== X-Forwarded-Encrypted: i=1; AFNElJ9is7Sy02d82RCBnek9i6CQf3IDZfcwNPAjwerXY2B2RnsXNlQy5L4zPBD0zQHfSZWkCibWTkUHm5dgMvE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywswet/Qh6N/OK3gpNZNGabPzwoM7/NnGrM7SW8mzUMYAZz8IuB TxXMTGCCthpGmyYf1b+u4va5sFAnVL//XF3tM5m7Dg9rgYl0rbNIRLnq4ODQyyrlrEc= X-Gm-Gg: AeBDiesfM5lBypAKIVG0z4d4p9gyrwFDVxoglv6P1D8lFuOIpNmqa9P3gnLrAxOxYxs ngmmNsb+nn/z6UD9Xkx4GhWkHh1s190fkS3AGClfD2VOo77Y3qLCXcqAIrD/GnpmjxADR+S7e+J rgk7w96F48QVOQGtJ1eZiINL7uLMi5yCFs8uSqdlUgkQaGlxOT3p551bts9GmOeF3jUKR/OH2gi xOcbcM2TyY/xdterbNeRmq4oD7NH6BcZYP0kB08VTnYzbJRKJOWeko/G54snq+j97p8kt+FG2Qq iuFFzJ+yt8r+XjAiZNSbYOdBqSyJG8F6dLCQzzpJqhQC/E64l7PxqMw4BGj14Dw6bKv31nmT3PO 3e5+8BcTGqWUZo24AowXdmil8sbZil+Ub83ssWEeQB2VFIABLcGBvefZCj1BcfU7MixH4Gt67lB ltqwmJ//FAWHDok0L9akVGG4F4XQeouEId4IdAdHVTYXZRhL7nNrUVDg== X-Received: by 2002:a05:7301:9f05:b0:2d9:5cd9:b8ff with SMTP id 5a478bee46e88-2efb8aa1da1mr640154eec.6.1777681131741; Fri, 01 May 2026 17:18:51 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3b29b2e0sm6419484eec.16.2026.05.01.17.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 17:18:51 -0700 (PDT) From: Stephen Hemminger To: netdev@kernel.org Cc: jhs@mojatatu.com, jiri@resnulli.us, Stephen Hemminger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org (open list:NETEM NETWORK EMULATOR), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 3/4] net/sched: netem: replace pr_info with netlink extack error messages Date: Fri, 1 May 2026 17:17:11 -0700 Message-ID: <20260502001844.19107-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260502001844.19107-1-stephen@networkplumber.org> References: <20260502001844.19107-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit netem predates the netlink extended ack mechanism and uses pr_info() to report configuration errors. These messages go to the kernel log where the user running tc may never see them, and in unprivileged user namespace contexts they can be used for log spam. Replace pr_info() with NL_SET_ERR_MSG() and NL_SET_ERR_MSG_FMT() which return error details to the caller via netlink. Thread the extack pointer through parse_attr() and get_loss_clg(). Remove the uninformative "netem: change failed" message from netem_init() since the error is already propagated. Signed-off-by: Stephen Hemminger --- net/sched/sch_netem.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 9ce75d9b8c54..116e96d79ddf 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -918,7 +918,8 @@ static void get_rate(struct netem_sched_data *q, const struct nlattr *attr) q->cell_size_reciprocal = (struct reciprocal_value) { 0 }; } -static int get_loss_clg(struct netem_sched_data *q, const struct nlattr *attr) +static int get_loss_clg(struct netem_sched_data *q, const struct nlattr *attr, + struct netlink_ext_ack *extack) { const struct nlattr *la; int rem; @@ -931,7 +932,8 @@ static int get_loss_clg(struct netem_sched_data *q, const struct nlattr *attr) const struct tc_netem_gimodel *gi = nla_data(la); if (nla_len(la) < sizeof(struct tc_netem_gimodel)) { - pr_info("netem: incorrect gi model size\n"); + NL_SET_ERR_MSG(extack, + "netem: incorrect gi model size"); return -EINVAL; } @@ -950,7 +952,8 @@ static int get_loss_clg(struct netem_sched_data *q, const struct nlattr *attr) const struct tc_netem_gemodel *ge = nla_data(la); if (nla_len(la) < sizeof(struct tc_netem_gemodel)) { - pr_info("netem: incorrect ge model size\n"); + NL_SET_ERR_MSG(extack, + "netem: incorrect ge model size"); return -EINVAL; } @@ -964,7 +967,7 @@ static int get_loss_clg(struct netem_sched_data *q, const struct nlattr *attr) } default: - pr_info("netem: unknown loss type %u\n", type); + NL_SET_ERR_MSG_FMT(extack, "netem: unknown loss type %u", type); return -EINVAL; } } @@ -987,12 +990,14 @@ static const struct nla_policy netem_policy[TCA_NETEM_MAX + 1] = { }; static int parse_attr(struct nlattr *tb[], int maxtype, struct nlattr *nla, - const struct nla_policy *policy, int len) + const struct nla_policy *policy, size_t len, + struct netlink_ext_ack *extack) { int nested_len = nla_len(nla) - NLA_ALIGN(len); if (nested_len < 0) { - pr_info("netem: invalid attributes len %d\n", nested_len); + NL_SET_ERR_MSG_FMT(extack, "netem: invalid attributes len %u < %zu", + nla_len(nla), NLA_ALIGN(len)); return -EINVAL; } @@ -1041,8 +1046,7 @@ static int check_netem_in_tree(struct Qdisc *sch, bool duplicates, } /* Parse netlink message to set options */ -static int netem_change(struct Qdisc *sch, struct nlattr *opt, - struct netlink_ext_ack *extack) +static int netem_change(struct Qdisc *sch, struct nlattr *opt, struct netlink_ext_ack *extack) { struct netem_sched_data *q = qdisc_priv(sch); struct nlattr *tb[TCA_NETEM_MAX + 1]; @@ -1054,7 +1058,7 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt, int ret; qopt = nla_data(opt); - ret = parse_attr(tb, TCA_NETEM_MAX, opt, netem_policy, sizeof(*qopt)); + ret = parse_attr(tb, TCA_NETEM_MAX, opt, netem_policy, sizeof(*qopt), extack); if (ret < 0) return ret; @@ -1094,7 +1098,7 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt, old_loss_model = q->loss_model; if (tb[TCA_NETEM_LOSS]) { - ret = get_loss_clg(q, tb[TCA_NETEM_LOSS]); + ret = get_loss_clg(q, tb[TCA_NETEM_LOSS], extack); if (ret) { q->loss_model = old_loss_model; q->clg = old_clg; @@ -1190,8 +1194,6 @@ static int netem_init(struct Qdisc *sch, struct nlattr *opt, prandom_seed_state(&q->prng.prng_state, q->prng.seed); ret = netem_change(sch, opt, extack); - if (ret) - pr_info("netem: change failed\n"); return ret; } -- 2.53.0