From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DDC301468 for ; Sat, 2 May 2026 07:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777705213; cv=none; b=qpOk/ofEdDgkc7HD9wxOIj2703/TFVETGWqOmlm3pXhUOJ5MTKpxSiyMLmsdBQ59waz//xnEbHvjTBZWJ2Nj8NO/BcKnfo9dfJ09FN+BzqonY51j1jMtucdGymP0p9WZ4B5+u6prC6bD6NcF1n1zLmdseYiQ6DfzCwGCMmkWtdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777705213; c=relaxed/simple; bh=DL0FkAdJqRHCqRP3d1NRnpycL7mImdH6HLMS8H+qh7A=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=CPSOGuNRH3dLzu0efgS0yBYrXiJsjBVKmrzgOTyhQzu91XnZMEOlTC59eSugFqlEFwUtl8Xm/8eEEc7XQAnpCB0zuQ47YWM6Xi3nb3pACruYu1zKQ6mWN2I5RnX5c/dFWYsKs0GkWuJPN/9UV3xBuuU+cxMdZzZARr53KKZEdiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UHOFXF0d; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UHOFXF0d" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b630753cc38so3742186a12.1 for ; Sat, 02 May 2026 00:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777705210; x=1778310010; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=C4fl8atXwJsXGN4qhUfGPrxc+n6KtD9kAzXZ7gC0fcA=; b=UHOFXF0d80IURHSfj4Sf6cmv+aA4OjHzaZuF84pD70dhn0txoQhpcFul0asBT3bG56 VwLZsHZvQTRfcjyFLdHLzz0KMRpzzZK9rI6i5rDfJ7UtGGTiGFopYNqQ1sLE070x02NM 8nmB5TucD5mkB14c2C4ySakbQ2nBjYWbJGl24GkJka2Gey0JWTPp3801JRf0q5Wqo9aV sbKLwaeMWmJDZUNTMqTTHoYJNfOlvrdTyGFShtHhqQJNtDUOeCJLNywFiiWIrxdCrhum mjgVEDntPnx4YzEgqVNBlNYAPKQl9qTjHz8gxyoa0ewyxp20vOh6AOemw9NecF68uuBU iWZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777705210; x=1778310010; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C4fl8atXwJsXGN4qhUfGPrxc+n6KtD9kAzXZ7gC0fcA=; b=eMN7T5Vw/YBkAjjInHPhNgvXyxGgOZ44Pwz0cGXKq15nY4fF64ZxXZp/4pNxtBYrbG FSO9xlex+6N+zQgufaCi+daXyBSwJIpDI2a8ObIETfEAZHsAcyV80q/XeTEtfvCd7Qhx Q7iiSUe/GiHUJOg23Ue5YmoOo/vtqI/1ReutYO8uAvvRaGKiMJ2dTc++HJKzMedqNjsR myk/uKKRXEK1wSqB+fJVZan+MqIU8Z7TiGLVO5vH+LVv7vKUG0KfCT3tKbQYSFP3/awi n+vIhyp7NgdC8ZqHHuiHgX/PSmZHJ9+ZApi1DujPHTn1GF8Ka/sktL0lRK8XrEm3BqeW 7Jjw== X-Forwarded-Encrypted: i=1; AFNElJ8ZrN94/DKUBoVNgIsWaq5aWbuPSxHeNcNJ6Qts/I7juBO4m2+mqQYgsqI+itMvdRcJURxuAf+cJubBrCo=@vger.kernel.org X-Gm-Message-State: AOJu0YzQJ+cCX9MBsY/K8Z7onyo2KkhONHTTwgsL0blo65eFq1MgzH2Q qyI0xIZ5fWZzbu2MHdgSCP6Y4XI+GMCpKrCTPbPNFVThXBU2cD9COmWpBC2lqAJ5jrUX6x7oyF6 OjSkzpTDR8w== X-Received: from pgbl22.prod.google.com ([2002:a63:5716:0:b0:c79:97ca:668b]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:9188:b0:398:90e5:a9b9 with SMTP id adf61e73a8af0-3a7f1c392ccmr2264086637.27.1777705210076; Sat, 02 May 2026 00:00:10 -0700 (PDT) Date: Fri, 1 May 2026 23:59:27 -0700 In-Reply-To: <20260502065935.291960-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260409230620.4176210-2-irogers@google.com> <20260502065935.291960-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260502065935.291960-10-irogers@google.com> Subject: [PATCH v8 09/17] perf arch common: Use perf_env e_machine rather than arch From: Ian Rogers To: irogers@google.com, acme@kernel.org, namhyung@kernel.org, tmricht@linux.ibm.com Cc: agordeev@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, jameshongleiwang@126.com, japo@linux.ibm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org, sumanthk@linux.ibm.com Content-Type: text/plain; charset="UTF-8" Use the e_machine rather than arch string matching. Signed-off-by: Ian Rogers --- tools/perf/arch/common.c | 55 +++++++++++++++++++++++++--------------- 1 file changed, 35 insertions(+), 20 deletions(-) diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c index 21836f70f231..e9b5b61feffe 100644 --- a/tools/perf/arch/common.c +++ b/tools/perf/arch/common.c @@ -1,12 +1,14 @@ // SPDX-License-Identifier: GPL-2.0 +#include "common.h" + #include #include #include #include #include -#include "common.h" #include "../util/env.h" #include "../util/debug.h" +#include #include static const char *const arc_triplets[] = { @@ -145,7 +147,8 @@ static int perf_env__lookup_binutils_path(struct perf_env *env, const char *name, char **path) { int idx; - const char *arch = perf_env__arch(env), *cross_env; + uint16_t e_machine = perf_env__e_machine(env, /*e_flags=*/NULL); + const char *cross_env; const char *const *path_list; char *buf = NULL; @@ -153,7 +156,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env, * We don't need to try to find objdump path for native system. * Just use default binutils path (e.g.: "objdump"). */ - if (!strcmp(perf_env__arch(NULL), arch)) + if (e_machine == EM_HOST) goto out; cross_env = getenv("CROSS_COMPILE"); @@ -170,30 +173,42 @@ static int perf_env__lookup_binutils_path(struct perf_env *env, zfree(&buf); } - if (!strcmp(arch, "arc")) + switch(e_machine) { + case EM_ARC: path_list = arc_triplets; - else if (!strcmp(arch, "arm")) + break; + case EM_ARM: path_list = arm_triplets; - else if (!strcmp(arch, "arm64")) + break; + case EM_AARCH64: path_list = arm64_triplets; - else if (!strcmp(arch, "powerpc")) + break; + case EM_PPC: + case EM_PPC64: path_list = powerpc_triplets; - else if (!strcmp(arch, "riscv32")) - path_list = riscv32_triplets; - else if (!strcmp(arch, "riscv64")) - path_list = riscv64_triplets; - else if (!strcmp(arch, "sh")) + break; + case EM_RISCV: + path_list = perf_env__kernel_is_64_bit(env) ? riscv64_triplets : riscv32_triplets; + break; + case EM_SH: path_list = sh_triplets; - else if (!strcmp(arch, "s390")) + break; + case EM_S390: path_list = s390_triplets; - else if (!strcmp(arch, "sparc")) + break; + case EM_SPARC: + case EM_SPARCV9: path_list = sparc_triplets; - else if (!strcmp(arch, "x86")) + break; + case EM_X86_64: + case EM_386: path_list = x86_triplets; - else if (!strcmp(arch, "mips")) + break; + case EM_MIPS: path_list = mips_triplets; - else { - ui__error("binutils for %s not supported.\n", arch); + break; + default: + ui__error("binutils for %s not supported.\n", perf_env__arch(env)); goto out_error; } @@ -202,7 +217,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env, ui__error("Please install %s for %s.\n" "You can add it to PATH, set CROSS_COMPILE or " "override the default using --%s.\n", - name, arch, name); + name, perf_env__arch(env), name); goto out_error; } @@ -237,5 +252,5 @@ int perf_env__lookup_objdump(struct perf_env *env, char **path) */ bool perf_env__single_address_space(struct perf_env *env) { - return strcmp(perf_env__arch(env), "sparc"); + return perf_env__e_machine(env, /*e_flags=*/NULL) == EM_SPARC; } -- 2.54.0.545.g6539524ca2-goog