RE: [PATCH v3] scsi: ufs: core: call hibern8 notify when hibern8 cmd failed

Fang Hongjie(方洪杰)
2026-05-01T12:54:06Z

> From: Bart Van Assche [mailto:bvanassche@acm.org]
> Sent: Friday, May 1, 2026 1:31 AM
> To: Fang Hongjie <hongjiefang@asrmicro.com>;
> alim.akhtar@samsung.com; avri.altman@wdc.com;
> James.Bottomley@HansenPartnership.com; martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] scsi: ufs: core: call hibern8 notify when hibern8 cmd
> failed
>
> On 4/29/26 9:22 PM, Hongjie Fang wrote:
> > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> > index 8563b6648976..4f7c619db324 100644
> > --- a/include/ufs/ufshcd.h
> > +++ b/include/ufs/ufshcd.h
> > @@ -270,6 +270,7 @@ struct ufs_clk_info {
> > enum ufs_notify_change_status {
> > PRE_CHANGE,
> > POST_CHANGE,
> > + ROLLBACK_CHANGE,
> > };
> >
> > struct ufs_pa_layer_attr {
>
> This looks better to me but triggers compiler warnings:
>
> drivers/ufs/host/ufs-exynos.c:1614:10: error: enumeration value
> 'ROLLBACK_CHANGE' not handled in switch [-Werror,-Wswitch]
> 1614 | switch (status) {
> | ^~~~~~
> drivers/ufs/host/ufs-exynos.c:1654:10: error: enumeration value
> 'ROLLBACK_CHANGE' not handled in switch [-Werror,-Wswitch]
> 1654 | switch (status) {
> | ^~~~~~
> drivers/ufs/host/ufs-exynos.c:1687:10: error: enumeration value
> 'ROLLBACK_CHANGE' not handled in switch [-Werror,-Wswitch]
> 1687 | switch (status) {
> | ^~~~~~
>
> These warnings can be reproduced on any Linux development system by
> installing Clang and by running the following command:
>
> build-scsi-drivers -c
>
> See also https://github.com/bvanassche/build-scsi-drivers
>

Okay, I will fix and update it.

> Thanks,
>
> Bart.

Best.