From: Michal Pecio <michal.pecio@gmail.com>
To: Desnes Nunes <desnesn@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, mathias.nyman@intel.com,
stable@vger.kernel.org
Subject: Re: [PATCH RFT RFC] usb: xhci: Kill hosts with HCE or HSE on command timeout
Date: Sun, 3 May 2026 07:17:49 +0200 [thread overview]
Message-ID: <20260503071749.6abda137.michal.pecio@gmail.com> (raw)
In-Reply-To: <CACaw+ewOTVh49tnkz+cRr0SD_Z-LmYrMWhFUrsik6YF83mPBtA@mail.gmail.com>
On Sun, 3 May 2026 00:36:27 -0300, Desnes Nunes wrote:
> On Sat, May 2, 2026 at 6:55 PM Michal Pecio <michal.pecio@gmail.com> wrote:
> > On Sat, 2 May 2026 08:38:34 -0300, Desnes Nunes wrote:
> > > Kdump doesn't run and no vmcore is produced:
> > Is the kdump kernel not launched, or does it crash during boot?
> > The latter would make sense if there is some problem with the code.
>
> Kdump kernel didn't launch at all, thus no vmcore was produced.
Well, that's weird. But it seems you have serial console enabled so
I guess you should know whether it fails to start or crashes.
> > But I don't understand how patching xhci-hcd could possibly have
> > any effect on the former. Does this new code execute at all? Does
> > "kill the damn thing" ever appear in dmesg?
>
> Both kernels booted normally: the first one checking HSE after USBSTS
> was logged on xhci_handle_command_timeout(), as well as this new code
> checking for ring state or the HSE and HCE bits.
> Since kdump didn't start, the message "kill the damn thing" never got
> a chance to appear on crashkernel's dmesg.
It could show on the main kernel before the panic is triggered, if the
main kernel was patched too. Maybe they are the same kernel binary?
I'm trying to come up with any conceivable theory how patching xhci-hcd
could prevent the kdump kernel from loading. Still no idea...
Regards,
Michal
next prev parent reply other threads:[~2026-05-03 5:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 1:48 [PATCH] usb: xhci: bound wait command completion to avoid kdump deadlock Desnes Nunes
2026-04-30 8:48 ` Michal Pecio
2026-04-30 17:27 ` Desnes Nunes
2026-04-30 21:54 ` Michal Pecio
2026-05-01 14:09 ` Desnes Nunes
2026-05-02 9:46 ` [PATCH RFT RFC] usb: xhci: Kill hosts with HCE or HSE on command timeout Michal Pecio
2026-05-02 11:38 ` Desnes Nunes
2026-05-02 21:55 ` Michal Pecio
2026-05-03 3:36 ` Desnes Nunes
2026-05-03 5:17 ` Michal Pecio [this message]
2026-05-03 16:20 ` Desnes Nunes
2026-05-03 19:31 ` Michal Pecio
2026-05-04 7:31 ` Michal Pecio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260503071749.6abda137.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=desnesn@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox