From: James Ye <jye836@gmail.com>
To: jikos@kernel.org, bentiss@kernel.org, lee@kernel.org, pavel@kernel.org
Cc: linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, denis.benato@linux.dev,
James Ye <jye836@gmail.com>
Subject: [PATCH 6/6] leds: led-class: mark classdev as unregistering early
Date: Sun, 3 May 2026 17:26:43 +1000 [thread overview]
Message-ID: <20260503072643.2774762-7-jye836@gmail.com> (raw)
In-Reply-To: <20260503072643.2774762-1-jye836@gmail.com>
The classdev was marked as unregistering after disabling the trigger.
Disabling the trigger attempts to turn the LED off, and the device may
already be inaccessible. This generates a "Setting an LED's brightness
failed" log, which is avoided by changing this order.
Signed-off-by: James Ye <jye836@gmail.com>
---
drivers/leds/led-class.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 9e14ae588f78..a00986ffd9f6 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -601,6 +601,8 @@ void led_classdev_unregister(struct led_classdev *led_cdev)
if (IS_ERR_OR_NULL(led_cdev->dev))
return;
+ led_cdev->flags |= LED_UNREGISTERING;
+
#ifdef CONFIG_LEDS_TRIGGERS
down_write(&led_cdev->trigger_lock);
if (led_cdev->trigger)
@@ -608,8 +610,6 @@ void led_classdev_unregister(struct led_classdev *led_cdev)
up_write(&led_cdev->trigger_lock);
#endif
- led_cdev->flags |= LED_UNREGISTERING;
-
/* Stop blinking */
led_stop_software_blink(led_cdev);
--
2.54.0
next prev parent reply other threads:[~2026-05-03 7:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 7:26 [PATCH 0/6] HID: asus: add support for T3304 keyboard James Ye
2026-05-03 7:26 ` [PATCH 1/6] HID: input: delete hid_battery on disconnect James Ye
2026-05-03 7:26 ` [PATCH 2/6] HID: asus: check feature reports when determining is_vendor James Ye
2026-05-03 7:26 ` [PATCH 3/6] HID: asus: add support for T3304 detachable keyboard James Ye
2026-05-03 22:23 ` Denis Benato
2026-05-03 7:26 ` [PATCH 4/6] HID: multitouch: add support for ASUS T3304 media keys James Ye
2026-05-03 7:26 ` [PATCH 5/6] HID: asus: add microphone mute LED support for T3304 James Ye
2026-05-03 22:45 ` Denis Benato
2026-05-04 1:27 ` James Ye
2026-05-03 7:26 ` James Ye [this message]
2026-05-04 21:49 ` [PATCH 6/6] leds: led-class: mark classdev as unregistering early kernel test robot
2026-05-05 2:24 ` kernel test robot
2026-05-05 14:16 ` James Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260503072643.2774762-7-jye836@gmail.com \
--to=jye836@gmail.com \
--cc=bentiss@kernel.org \
--cc=denis.benato@linux.dev \
--cc=jikos@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox