From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72D73AD524 for ; Sun, 3 May 2026 12:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777810246; cv=none; b=eeAa7UyZtl7TDaaFbkco3yCJbm6AzUwGT24aTIeOFniSBQOeZ3/HPIkU7ETUh+jnjJxAmRYAscJhwR+jGHdVM4GdM6hrelZOQwYM4sqPM3YpmozooiCEIosYloePzFId3kDnDtba98eqU9Mojkvh9EP/tMxaOGq3Yf2YkEYMtNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777810246; c=relaxed/simple; bh=5i023lPUKhimKsYF9M78AvT6vY5pZfCNtFZKwv6bJVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WGprr3l02pNbRLG1XTs8WgEcq0qdef1yBEEbpCtcXfEw7buuacicsAP7NCFTsj6wdiMH4zvJSXHG+sgvS4eFrYOvpDjVZGIdMvxXOKgLeQISiWGvwAqFdiLM5NEe8P7JATGZ7dEaOnF3svBYhRRK8E/s5tTbqdVhICwt8SeS1Ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XBNxEyo+; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XBNxEyo+" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-8354461da74so166802b3a.1 for ; Sun, 03 May 2026 05:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777810244; x=1778415044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/eXI08ZZvBOZRhVvTrMA+ciVmwUlugzbu9mfoWqF/18=; b=XBNxEyo+3IHLC+MKHKhJx65Tltwsdi3YiabT1lR3GqPBfGV7Zq88BrTtGTEXKO6hnF IvohGbUnuWApjrAlJdC6sDi9n/O+JDZO30yRdfw773EXHSjzu67T1hkZgbvWg2Ksh2kH cJfBljznW6WZwkDYR6OPCriZut8VDfnodrSzf+0CXUdiz7Opo9x1NFpB4q5/OMx1mk7Q IEm2NxvwkwHINnFQSayhDB73W9+lMj3nqw/WuLt5Fw7T1Z8oLWeImwuC/oI93C9ggsWb 34URMaz3VlJ53aeA9I+rBq93lr4QvHrSUe+P8l36N3YJlilVMv5eteV0QmsCILEmEEkY 7H8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777810244; x=1778415044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/eXI08ZZvBOZRhVvTrMA+ciVmwUlugzbu9mfoWqF/18=; b=Sj5cjYkLf/vWBdv10a/u4WR7RiQ4xQAvWeCAU6WXBtZWk0xHNvVyZ+8b9g3ZQgrT/j olsNh0LHNf5WGBFmoCo0wYf3oczKp0htXLkbQiWwgDixPoZLncU5ledeORSyVfImi+U4 NeCTL+f4iuvSCHiHIzU9uAcV6th4JXOtiNtklkU9ZvCPwF8b71HZHJJlCN3qCgfBqQZX BK+82ti/mP7YylZzSKVE2zf6KSB+u70iJZUfFqPNy/xD/LQBZclXwfGsL8k8GzKIeJYx 2jioaN5hBRiwFzKrXtf+cQh1gzWRLCGPPLZNwWvd6gkDtbjsSjtYJdFUN4FWgzqKImQQ lzKg== X-Forwarded-Encrypted: i=1; AFNElJ/9F9VTP05hRmjJX/zH5xI7At6IaJQrQ0z+BfAxAbOB7NBdE5jPt7NFfrAebW5R6QtBB2JvK1wlWb1MJpc=@vger.kernel.org X-Gm-Message-State: AOJu0YxtDmr9CQVbUuF7jjqUfOJQOo5FDMzP4nA5S+ZEJBVtOTGP7pVP teseH47xoZCAv01eX8BC044Nzn+ZmGTOBwmdEHFmkRIf9cJriEmNcN6P X-Gm-Gg: AeBDiesCulUNlRamks+HYgVlyTL2At11TY9C56lGe36fFQsmg2P8m6RMY8+GMFq9bQf zZtpxvfKvv4EDGYyuR7kwWuby8byUqVPxSfTIDeyJ9O58ZJaCB8j2l7lfbLdnVuST3D39M1atyN TMpcRPeDrJt4Y81RUpzmxXlj0Xed9tenmjHhra/EOCBWcF2HacMln+0Ir579XQzcL2f3kQ6Mdlq H32DsEcq/XCPwQ3MVflcmwbwtBEJ3omEPsBWQ34zO8mrVTV1/Z1hbOQyDFoa3/D288YknAIzxfG Bdy67EYGPuRvgP1vMfR7zmUuzMUby1HzWpKsiHXToPSrFVinAuvGplK8WKhW42APL9+HODrkEg6 dCXp54R80Np8aXjErZjnJhURGfLwHC4Rg4Xz20PpNb4d1NjtKdxvkVi84zTCmjq0SppW40pnLwT xQwxqnuUi3+xOU/9N+mxOAE4fh0KK+o6gk2Pypk5ttSKqKTzUAPYzwDRtHPtBpCTJUBueRLwqJB jG/3tGED4lN12+StPsg/IXICM5Bu4MVUuDYzE1U1V20zSPIUNf02Jgoea45ZVmQL+jNeQezqlPH CmgRLA== X-Received: by 2002:a05:6a00:2d8b:b0:82f:776f:a78d with SMTP id d2e1a72fcca58-8352d1a68admr5782544b3a.19.1777810244142; Sun, 03 May 2026 05:10:44 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.www.tendawifi.com ([14.139.108.62]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8357c4f4530sm1474364b3a.9.2026.05.03.05.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 05:10:43 -0700 (PDT) From: Piyush Patle To: Andreas Klinger , Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Date: Sun, 3 May 2026 17:39:36 +0530 Message-ID: <20260503120949.80292-8-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260503120949.80292-1-piyushpatle228@gmail.com> References: <20260503120949.80292-1-piyushpatle228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the trailing-pulse selection out of hx711_read() and into its callers. This is a preparatory change so later variant-specific code can pass the per-channel pulse count without adding a separate read path. No functional change. Signed-off-by: Piyush Patle --- drivers/iio/adc/hx711.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 534b73fcaab8..637114635867 100644 --- a/drivers/iio/adc/hx711.c +++ b/drivers/iio/adc/hx711.c @@ -155,7 +155,7 @@ static int hx711_cycle(struct hx711_data *hx711_data) return gpiod_get_value(hx711_data->gpiod_dout); } -static int hx711_read(struct hx711_data *hx711_data) +static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) { int i, ret; int value = 0; @@ -174,7 +174,7 @@ static int hx711_read(struct hx711_data *hx711_data) value ^= 0x800000; - for (i = 0; i < hx711_get_gain_to_pulse(hx711_data->gain_set); i++) + for (i = 0; i < trailing_pulses; i++) hx711_cycle(hx711_data); return value; @@ -237,7 +237,8 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) if (hx711_data->gain_set == 32) { hx711_data->gain_set = hx711_data->gain_chan_a; - ret = hx711_read(hx711_data); + ret = hx711_read(hx711_data, + hx711_get_gain_to_pulse(hx711_data->gain_set)); if (ret < 0) return ret; @@ -249,7 +250,8 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) if (hx711_data->gain_set != 32) { hx711_data->gain_set = 32; - ret = hx711_read(hx711_data); + ret = hx711_read(hx711_data, + hx711_get_gain_to_pulse(hx711_data->gain_set)); if (ret < 0) return ret; @@ -264,8 +266,8 @@ static int hx711_set_gain_for_channel(struct hx711_data *hx711_data, int chan) static int hx711_reset_read(struct hx711_data *hx711_data, int chan) { + int trailing_pulses; int ret; - int val; /* * hx711_reset() must be called from here @@ -280,9 +282,8 @@ static int hx711_reset_read(struct hx711_data *hx711_data, int chan) if (ret < 0) return ret; - val = hx711_read(hx711_data); - - return val; + trailing_pulses = hx711_get_gain_to_pulse(hx711_data->gain_set); + return hx711_read(hx711_data, trailing_pulses); } static int hx711_read_raw(struct iio_dev *indio_dev, @@ -349,7 +350,8 @@ static int hx711_write_raw(struct iio_dev *indio_dev, if (gain != 32) hx711_data->gain_chan_a = gain; - ret = hx711_read(hx711_data); + ret = hx711_read(hx711_data, + hx711_get_gain_to_pulse(hx711_data->gain_set)); if (ret < 0) { mutex_unlock(&hx711_data->lock); return ret; -- 2.43.0