From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4C561F3BA4 for ; Sun, 3 May 2026 16:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777824380; cv=none; b=GFElG2s2s8kogbY0gm7iixGwLFJ4Rpmf34Tr2oAJw1QEArtsqJ97tj8t5UPuVyGAZG/p23Sd1O7Ewe73w2yerD0USTHIBKULSj6EfNgWfY3/PjMXFQPaHcNx1fB3WuS0C+XEvQgb/tVab0GI7XQ3HiTHLwHTzYI2vBgSGC1me6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777824380; c=relaxed/simple; bh=SMl3eAm07Ime46SBvrt7gdHa1Bo6x/GCvKmgyXZwkwU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oaV0Eakq7FItwMT1JXJeL1xRhIoF7m+3tqnG3j+vNxMf1lq6OnHRt2nC3T8XUFZkvB5lHzsZb8BdFLskhsiGr6FiiEZpk3u9Dd6klqmRSIPD3oI2xGO6lZpEr6D4AxL22ThoN1i7m8Gw5gcn4RbrUhzvKL0EldpceYwJ8QLS9k0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DHVkj+Kd; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DHVkj+Kd" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b24fcc2b5dso19099455ad.1 for ; Sun, 03 May 2026 09:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777824378; x=1778429178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zdx5oBv4v023zE1PghukVZYtoUnqRi2HHulg5TcW1xM=; b=DHVkj+Kd6Lfz++0L1ad+1hlStuXiEaihJlM0LICCKQ4kgBXeruL6bGmgkRLNyNjc6o UIR1GqiboCSiCAuReXIYc+MB+KfdMEU3ZEp/OABYmUeNOLuwNJHEdXd94mdAcgNPnjnS zPDb5Zk8YlBZAxXG4S3eIvbq5iIalXYB5AYVROjJGazsrJojgat/d7Zvwdv1AyLy5UAY T8Ta0tZqee9Y1CrcYZnwG6DeNoI4lwBxhRuz/60H5NCpxZVgL5XHqrGLflkAMI6dyZyW UF4GCl2uY+99ZMX8FTZPkQa9jucPejG2QZSD4Qan/oGPoDtRQSyIvvMO54YcyXTTuuzi ff2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777824378; x=1778429178; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zdx5oBv4v023zE1PghukVZYtoUnqRi2HHulg5TcW1xM=; b=XTzq5kDtzXulg2X0slB4xUzCu4sFfsBf5WRQZDBPSF40gykevmusfnHpV3ju1jstGw jB/Tl2t5h/Oipn7et6VLM4pDAoxkUoVpG0pjUjetoL8bbKzDJWJQy49NNAKLrX/OXe2/ BP81Q6mN4xJZ3AmydbT2R/hwl047ujPXcCEAp1jnuYwcSX+W5Tzyzs2o/4ZTGE2wLcDE mBo1xR67cIAorn4a4xwtlAJY5icM30dSiVAuSU+xcNEdeeLwZDY7L8UIyabKOxdOj+yL /rQ53LpSYMwhuR2LwllJOgHHeWCssd6hBR+3C47Tr3E9zhev7/Vozja0yeYMWS28Hc5J Bcdw== X-Forwarded-Encrypted: i=1; AFNElJ+YL4C8jI4RGSpG421Jv26NS7/WNzh/k0bf3+NzE0OWmx4uIW7NFpfve2u8jW+YIe7OnEssRKbWAdmM1+o=@vger.kernel.org X-Gm-Message-State: AOJu0YxnAAHMURXKsooT4ZOmX+kUzQSuBudW+AzJbRp0MMInfEkqBCql yX39nklstjdk1EnTIXBzNFTShlFAuxMlxplcAcZA6EErwsI2oojLInlO X-Gm-Gg: AeBDievrM6EWvr7tvhKFAvDkVkvuncZ1Zzoer5foS+RUI7Yutnw5chOe7k4QzXMOnc2 fZ1hzWqM5mi82jhs9RGhTtrOPIf0ztxrdlozFiVsajoT83A5GvWDSbDyw0ShgilXP/Z/Tc1pC1i OTK28XcPszvMrUn1gko5rR42B1sN9DJTqxae3Jf3eLMa/p3BG6FwFu9Hse0OxumnKj+2Zqm24YG bcl1BlAaBmDMqoDgX7MJh5Qls76dHgvX9cFs1hhL34/4RlKylhIbzgvGNTcyKXreC4sfXQBYD9p dAerBSILtLu+052V03ZfYUkMsg1OUZ4KzJJ5NhfwGPZcYDmpdeduGBPzufyPSfTZWCxzm6c9Yef nc00hZwpQ/dBy/HiyinIy+goWT9aEtQGeGVVOwLXReZc4RM/tTLG52doV+dQuvQpa5WJWgM3GpA JnbB74yivCln4AJgLwIcxAteloMxbcgZH5u5hvksCq9lf8cjpeASyasTVmFhpAfVw= X-Received: by 2002:a17:902:ce05:b0:2a9:e8b:5326 with SMTP id d9443c01a7336-2b9f2808c9dmr63827135ad.23.1777824378046; Sun, 03 May 2026 09:06:18 -0700 (PDT) Received: from crewmobile-Dell-G15-5520.. ([2409:40d7:e:c40c:33c3:4ace:eabf:e5ae]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba0551185bsm36569085ad.71.2026.05.03.09.06.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 09:06:17 -0700 (PDT) From: Arnav Sharma To: ojeda@kernel.org Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Arnav Sharma Subject: [PATCH v2] rust: error: implement Display for Error Date: Sun, 3 May 2026 21:36:10 +0530 Message-ID: <20260503160610.8431-1-arnav4324@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement the fmt::Display trait for the kernel Error type. Unlike the existing Debug implementation which outputs 'EPERM()', Display produces cleaner user-facing output like 'EPERM', which is the idiomatic Rust way to present errors. This enables using {e} instead of {e:?} in format strings throughout the kernel's Rust code. Signed-off-by: Arnav Sharma --- rust/kernel/error.rs | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index 05cf869ac090..d1b48a4ebd90 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -216,6 +216,31 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { } } +impl fmt::Display for Error { + /// Displays the error name if available, otherwise the numeric error code. + /// + /// # Examples + /// + /// ``` + /// # use kernel::prelude::*; + /// # use kernel::str::CString; + /// let err = EPERM; + /// let s = CString::try_from_fmt(fmt!("{err}"))?; + /// assert_eq!(s.to_bytes(), "EPERM".as_bytes()); + /// # Ok::<(), Error>(()) + /// ``` + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + match self.name() { + // Print out the numeric error code if no name can be found. + None => write!(f, "Unknown error {}", -self.0.get()), + // SAFETY: These strings are ASCII-only. + Some(name) => f.pad(unsafe { + core::str::from_utf8_unchecked(name.to_bytes()) + }), + } + } +} + impl From for Error { #[inline] fn from(_: AllocError) -> Error { -- 2.43.0