From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE4E428725F for ; Sun, 3 May 2026 16:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777825181; cv=none; b=uTykEkGl8XhE7yPYic1H5ZAyi7t/l1A9qpKlXHTwqk9e6XFxy9zMsjQm7O+EmVIGc5kF9wxXrnPiE/sKWKZLStTzKCNNuyUcIDxpGbd9Tx25Ox2+M4ptPuR/fDdoptQGIPIE0LkL4yJw0EgVBLmeZwtDasuT6UMebj6/L+DRER4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777825181; c=relaxed/simple; bh=pmerjokD0oeSxWalrW+fG+sbepo7Vq6LdAjyjOtSOpw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bUn29awrXC2ChGBsHRRoyY7gD2f/OjdRgFJzJ11DNFX2JyxpyVczLkzYygFygWu4+N3fhMAWaKmtzvK4DKMCGYSQShQLbO54CLftTf0uF6InxSxGaqU2M0hW9QpTANH406edu8dt9Vz5msJ7lm1YKSXAGLqL3zXTP8JyiECq/es= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SyVIMCTl; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SyVIMCTl" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44a786a9a35so1340116f8f.3 for ; Sun, 03 May 2026 09:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777825178; x=1778429978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I77XqBnNzy6Xd0uVg7MWgMWJtzfrTV1o+kCHDHq3zPc=; b=SyVIMCTlWJCB9Vh6ym+tKjeMKBE5IpwHIOj+SC+9n+DcMZDJ+ITNZKX7mlHd/QLTkd 9LcVa0WuxyHnl/LVRjCNoHE7ZpX+CBbJCy1UWDZhfEnuLoqnzLmdgBXnq8SukIxaDFz7 1gZRA7+Fm7bHyQSCc/SEoAR11zOfMRgBjzUB28P8dYjiVARP9xEe3crILhxVAr/M+0Uw Uq4Sd1aBkCraoBSASR6r+KTV5elWM8pbioGPTsSkmykn0xfihxgtTuV3FR31nWmMXnX+ ZOQRehBLGeVN28L0Xwej9nIZZQNWqzLYMzM0KGbcOJWwJGIu1go6xoV4pOmFzsSVMSJd nAmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777825178; x=1778429978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I77XqBnNzy6Xd0uVg7MWgMWJtzfrTV1o+kCHDHq3zPc=; b=jVqC4QINk1St/YGDmFfbPuUqYWQkV/8KnHTBG3zLx2haH3FAcdTljTvjxhXfPu9kGE aXufOI/9ns6ZKSUrf2ab1msXFeFwE6YAZ3RO9OLqv/ALh9zu5D+mB/exx2wSYncD4jyF XjTBLRzjr5tUXMXKnS9HBdWEe+/YI1M8Hm8DmLhnNcsIamxJDdOIp0n6YORpWm4m2v31 tbeQeLhJ86tzigRMtPutyA/C9mfX9r/8TgQCgzv2adot05B3hcJRNvWm79TEaEPkLpbE 357xpww6kKN7qJv7oOQzvXTZcqz837uExkCr0II0z07ImwL1ccCcKr9AAVOOQMLujPko 47NA== X-Forwarded-Encrypted: i=1; AFNElJ8hZCH6AMUue0L31iGK/Z2HBIRROA1AAqSBh24oR0FKSQqq9TU/0HTzgSMStT+b/yu9nq9lw+Dz0fLCfsA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbh5JiIXaT1TX7ExXuHr8WGvW5i/ioGTF8I+tEAzLGZZ7XF88o mYcBmPGamh5hGAa/0H5sY5QVlDeDPgfoUBk9F7hRNdoPe7tHyjLzmMGG X-Gm-Gg: AeBDieutzx0T4Qm3RCEX8D4D6RRLGydVP3EfNb+z/rYdKiGam9pfslApYlZC7ITAJuG K/I3vvPgMxEb/vqXLxRzZwgjznftujNCuHBJyrEVQ3y8h+LVOm9AydlL8ioQMD6rMQCf2B1KeQI TjYdzgQmDKZe9+cSxsDf+Ft3q5COZTrtrynPbCtD1qmaQi8yedcF6XD9hlrco0H4YGVxzo+xWDb 8LKTDZjMHbKqtkfXAuZk8iCqkkea8Yj6w4IYy4A5BF+kPCbf1srPuooRpdPjo+KfEwkk2PcyjhV SJxhEwIKutMUUhkBJ0a3nyOmVN8rz9fFFxuXhb32biVGG/4PAWuDf7av1xuX+JU0WApENTOEkRw FfT2X08T+Iwz9hZUn29fqBpi6V9GNvnhYNdwI4skmj3BaVCGWU3pOQ9FXiSNDuO07psS5uWSBRW DfwObCdcHOfV+ruLH9PwxC9ak/vlxTjhx0dnY9JZ1R9qi7MI5OGuwIL4ykaoMWBMM+6RNQWRjV X-Received: by 2002:a05:6000:2081:b0:43d:77e1:6a69 with SMTP id ffacd0b85a97d-44bb6ab16fdmr11218016f8f.38.1777825178134; Sun, 03 May 2026 09:19:38 -0700 (PDT) Received: from ST.. ([196.221.137.242]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a981dee7asm20072901f8f.21.2026.05.03.09.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 09:19:37 -0700 (PDT) From: Mohamed Ayman To: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Ayman Subject: [PATCH v3] riscv: Replace non-standard -1 return with -ENODEV in riscv_of_parent_hartid() Date: Sun, 3 May 2026 19:19:31 +0300 Message-Id: <20260503161931.688010-1-mohamedaymanworkspace@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260502161802.515547-1-mohamedaymanworkspace@gmail.com> References: <20260502161802.515547-1-mohamedaymanworkspace@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit riscv_of_parent_hartid() returns -1 when no valid hart ID is found among the parent nodes. This is non-standard; Linux kernel convention for a "not found" condition is -ENODEV. Additionally, since several callers propagate this return value up the call chain, a raw -1 could be misinterpreted as -EPERM by code inspecting errno values. Replace the -1 with -ENODEV for clarity and consistency with the rest of the RISC-V CPU handling code. Signed-off-by: Mohamed Ayman --- arch/riscv/kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c index 3dbc8cc55..414cd55df 100644 --- a/arch/riscv/kernel/cpu.c +++ b/arch/riscv/kernel/cpu.c @@ -135,7 +135,7 @@ int riscv_of_parent_hartid(struct device_node *node, unsigned long *hartid) } } - return -1; + return -ENODEV; } unsigned long __init riscv_get_marchid(void) -- 2.34.1