From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838AA374186 for ; Sun, 3 May 2026 16:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777826835; cv=none; b=IvgpCsuKMmN91sLcTeDUH5kIRgzCyJgkDk0iSjpeaIQq8h+NU6pVt4YBh5HXcKoSgBvEuPYFTKqUXKSDfhgw0eljFDNl4kqUtwuwG1Qm2NSPlExbdSsQXZvPRxNnkx7mtJcFgr2T5ZInxCr76UzTveBUOkaqmgoNHXa49AISeVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777826835; c=relaxed/simple; bh=ebx9DytCjEe5hkX4lMtfi5pzQvgPYCMmi4NGe2LpsWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ndq6hUajZ6jdFg2FAD6BmIF9ivxxt+3eMcWQhcnYpgU3yX221cjaSDUfRs6FNDAxg5JdiI2cJK8a9XG+fMSZXcqnmSUUmgpvJlDGkLbn1mnHXVGIxMsXfFYJ9zfMOhJDPtXpOs0cg9IElTRtfeFWtxtrfovsb/m16/pSBfEeadg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ATPjrw10; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ATPjrw10" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-38dd9f11a09so27044151fa.2 for ; Sun, 03 May 2026 09:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777826832; x=1778431632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ebx9DytCjEe5hkX4lMtfi5pzQvgPYCMmi4NGe2LpsWw=; b=ATPjrw10h1EqCjqyBDFmFmTj42m+UPelzagG60oKl8aoaXllRLR+UKCV5CGZ0r9ZJY 6ts3iCFXIOwLceciqZ2VNGskSoACul1ce+u757TzkEm7PmAk04AfTSECOmZ78jbfQQA9 9USvWXdb9x0DTcF0wXCtPpnzT0//gpsX6xrK8oVzFHP5qpxdVOcx+NyHAncUFkS839hP 3y6jCU5I808hXXIrQ+/eF2UH5VRuMQe4Zym2GFor4mS8HezxRQyRSgz+ZPNz2QrIdEvF AlKttAWACApdH96SNEzHYvt2GmVdgLBASR7Apc+UfxB9ssj3OSmY/c2VobeZ74QYIEmh ZwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777826832; x=1778431632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ebx9DytCjEe5hkX4lMtfi5pzQvgPYCMmi4NGe2LpsWw=; b=NY3EKV2BcqRfMe61SuyY7DIJA9ckzBFbK/7Jv8dPDYcGijEnZh59Ii2Emb9T2EXIex 53+xQGu70GdG9LfZlKJVikJ7mjAj4KeNLyUYPuAk+wtgUsl5fE7p7ndKd+RMnZVpPtF0 nLHB9Y1Hfs5kPmyLdRmPjnDoUj/361+b2dXHmEtH942XtdEnVgPfTP8n8MsmWpg/BMo5 OaMb/oqVvUCwiXjiL/bPrQiQ1O66CB8rcsfhUQzqg8KtY4rv5/fMiiIQhTG0XwahJKvX LKw/xegxCBAa72a4YxOsF5bkUuSnK9ccBo352EjSRfo57FW0W7h6gOnAyZoTYDJOcmCn r8Ig== X-Forwarded-Encrypted: i=1; AFNElJ/4AoKbAuDEtU/EAZNRcFifPUyDUX5us/ImvW4flLW/9vepf6ZPwKAzEpxg4z5QsTJN8StcX6NBPE36VGw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2NCa/gHQrewIB18zUHR4XqH8CfEAYspJlE5nVEJDfD5p+rP3Q 7yW/P+GeGjWAZlL5w/R70YlmxNz5bsGXlh02GpjXapodJP3dgxeV23WtXXXuuBPMy2biHr3nSDU = X-Gm-Gg: AeBDieuYgr1me7ScDiJ8iKpdIRH9OLzov/Oc4RKEzndc8BtUSVq1+Nk5C6kDIBOOajZ P7sZT5KmxpQ7xberuMUUVUmU1Q2HJiKNWzDf+BUe7EfIcmNSVJ8VVUZx1Qyg4gChC1BGI2RXE7u fdYUobyslmULssO0CL7FhIi9rz4yB8GaYSyWHKS7ynhCU7V8b0Ms/dCU7ZjkyfemT4pqffmO6FA vTMrbNwj5JMyVX1xGTuZypOBRD4dVKoiFbqB2xKGsnnVvlDbUJd+hZkIyB/FEM279cu1ZyjPyER 4gFlONL4eT3XcufLF8yGp/6qSYqWHoA+W/p2gypM2CWDAwD1ykGo59gCcYgQYNzucTXhR2Q/Bj1 k8rl0ep3OKVwJn5F9ZNb5O8mrZQqyGfbA+7JUxZlUPZx86QTLt5tFuzu8UUiokkO4toxw8B6lVL 9Eu6GMqCv41gMHO4t1UQSptBuBDFQp3lqTgh7YNxKVgbv1HBFC95R+rx2ETIrCmUcLbGIgXhg= X-Received: by 2002:a05:651c:1501:b0:38a:aba:9bf9 with SMTP id 38308e7fff4ca-3937849422fmr21458861fa.8.1777826831339; Sun, 03 May 2026 09:47:11 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39361323f4csm23033091fa.32.2026.05.03.09.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 09:47:10 -0700 (PDT) From: Vastargazing To: idosch@nvidia.com Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, David Ahern , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: net: fib_nexthops: detect kernel splats from torture tests Date: Sun, 3 May 2026 19:47:08 +0300 Message-ID: <20260503164708.348543-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260503061740.GA98182@shredder> References: <20260502122219.262611-1-vebohr@gmail.com> <20260503061740.GA98182@shredder> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sat, May 03, 2026 at 06:17:40AM +0000, Ido Schimmel wrote: > Do you have a trace? No. I did not run a KASAN-enabled kernel before the fix; the commit message stated "would have been visible to a KASAN run" as a fact when I had only inferred it from the code. That was wrong. > The netdev CI and our internal CI run the test and look at the kernel > log for splats. Both did not flag it, most likely because per-CPU > allocations are not covered by KASAN. I did not check what the netdev CI already does, so the second claim in that paragraph ("the torture loop just did not bother to look") was also wrong. Combined with the percpu/KASAN gap you point out, the patch does not close anything. > I prefer to avoid such random markers and rely on the system running the > tests to catch these issues. Understood. Please drop v1.