From: Armandas Kvietkus <armundunelis@gmail.com>
To: luke@ljones.dev, denis.benato@linux.dev
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Armandas Kvietkus <armundunelis@gmail.com>,
fxzxaxon@outlook.com,
Armandas Kvietkus <armandas.kvietkus@proton.me>
Subject: [PATCH] platform/x86: asus-wmi: suppress -ENODEV warning in fan_curve_get_factory_default()
Date: Sun, 3 May 2026 19:47:52 +0200 [thread overview]
Message-ID: <20260503174752.26288-1-armundunelis@gmail.com> (raw)
When the firmware does not support the fan curve WMI method,
asus_wmi_evaluate_method_buf() returns -ENODEV. The caller
fan_curve_check_present() already handles this gracefully by
treating it as a non-error, but fan_curve_get_factory_default()
still emits a pr_warn() before returning, producing spurious
boot noise on unsupported hardware.
Suppress the warning for -ENODEV only, consistent with how
this error is handled elsewhere in asus-wmi.c.
Reported-by: fxzxaxon@outlook.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
Signed-off-by: Armandas Kvietkus <armandas.kvietkus@proton.me>
---
drivers/platform/x86/asus-wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 80144c412..9b12a9e1e 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -3538,7 +3538,8 @@ static int fan_curve_get_factory_default(struct asus_wmi *asus, u32 fan_dev)
err = asus_wmi_evaluate_method_buf(asus->dsts_id, fan_dev, mode, buf,
FAN_CURVE_BUF_LEN);
if (err) {
- pr_warn("%s (0x%08x) failed: %d\n", __func__, fan_dev, err);
+ if (err != -ENODEV)
+ pr_warn("%s (0x%08x) failed: %d\n", __func__, fan_dev, err);
return err;
}
--
2.54.0
reply other threads:[~2026-05-03 17:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260503174752.26288-1-armundunelis@gmail.com \
--to=armundunelis@gmail.com \
--cc=armandas.kvietkus@proton.me \
--cc=denis.benato@linux.dev \
--cc=fxzxaxon@outlook.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox