From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D83963A6417 for ; Sun, 3 May 2026 20:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777840264; cv=none; b=lEiBwXY5bn2ESlandyxSpsb5OweTzQUFXDWuULmfonB/bzwBp7I+LzSEExjCg9wchi+QzeKrDBtW1ZtSgEQ8ElWRe5DlXkFRnn/jt93NLCzUxiZOaREyKWUIzZZi4CHmyZJFucj4dTo4XEtBwF05K25ZOU2hRAAem1ZUqHtuDvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777840264; c=relaxed/simple; bh=eLHoF/wGA3aZI/LpYSfur0tsW8EtC8WgaiqHaVUKpq0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mLPgFkY1TPfDSgMIUYJeVkrOxY7QhFDw7DmEdTGNXfKtyHqwzYLD+3ajBefZIHY6v6YebXNZUV95qYf3uOxTqVXawYQK7/O+Gxfju+W9L81aMrY52zKFhxJvekbpSAlgO27SRbbJ+92H0feeoaoGYE0ALAYbvrqdK7SccwhPpII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-835c98b659eso293984b3a.0 for ; Sun, 03 May 2026 13:31:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777840262; x=1778445062; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YtwuqB0hoMSKpHnfRml5OeZrZRHAiuCYySfGsA2RQlQ=; b=CeCNorMp+SCSNf/UTCrWvV+cyWbMJXh+cB+O3+QRkWWvkbn2iUcrvTb6ywcLNxYZwH HBELLSxrVRzP8u+pOHIGgTGJZewF1r47q51vgroynziDBt5zQ+/h/4xZk6Kno6/B6J19 QHMtOo9PPY8hxPic+0h4q4i42IwjM7chLzTTRUvpg7TJtEBuFH1C5ADOOdW0MGsKyCW4 xF64pN+EDOjRxmygN9dn3Ph4tsSnHjPYnd3KTvvW7B3khmcKy9Xnj0y2NTMJE6gMKrPF /Ibiys7PaUGQtdHtLRj1uRS6bqjvSGMj4pW2InwEUykL3tgepDICr92aAFGL3PD1nwpZ 5Ing== X-Forwarded-Encrypted: i=1; AFNElJ+vCiI+/s3PAUoIkwFlEOqzFTKQlox88n860wHi/9oMID/lpNp2g4tk2q6GY5q+NzKa0y3f5fLMmfgPW7A=@vger.kernel.org X-Gm-Message-State: AOJu0YwZaWP1zgO8/mWmjHm2ZsHEL8sHfHKjKYeNp83Y8iqBAzxyHSa/ zmRZOqc35SBCWs/3PXg+uSev8XKes5lotKFvkWu3S3vhQvPHHgsoQ3fC X-Gm-Gg: AeBDiev8GdFS51NWgDZJwDMf/5B28jgrKb9FWF5ZGMN2rkNH7SL6XZinKTtrptzO5uK yWZ8qyr18Rb/dUFwxOCHYLvDM+92OLfmPyz9efdNdGYDaMmdbwXKwHWMdyOAM47BGb5LdjoUR/+ VGMRXqxpX+mu7q3u8WCqa4sjyawtBLntIAs9FpkBXzl0MTU8Kh+0VbbSVa02OwpwBgjIp8z07Pv VvLk8tETrUEyqDAlwivA7M5sV9yuQF59vsfa3Uek+eiZiO3WHQEu+TyAMU8G6n8XNFe0AhuUMZT x6gSUa7IEl9d5ApCOyXzVNDMcMXfp0fAe2F22yQDlFSfizVhuBULuuZleW/gMBPyyMS83pteAP+ eRxOgmCWJjmbUJqLRO4zklWWP5Mvl6COlXPNkE+flSCtluw2Li6pINBISUH5IXvTkX1O53hQ44N jePcZl+LkEnKR2QMA8+ZKxwn20kPRe8furvzAhnPOWtFIQPUE/FrOlhlFLYBRvfA7kPXn5T3F+r 73EXKV2dYX5rEBins+acVIhhQLV9gpKH2bLJGDkSwfBtUlXZuXuC8Jpzj2vNoKn6xfn9gs3qZGU HQfZkHPymstTIjVoD7e98FKHLdwUdtAOtzkBlf/SpVtF6HpOEAMT X-Received: by 2002:aa7:8b4d:0:b0:835:388c:9753 with SMTP id d2e1a72fcca58-835388ca015mr3357386b3a.39.1777840262201; Sun, 03 May 2026 13:31:02 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83515ad8770sm10048786b3a.32.2026.05.03.13.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 13:31:01 -0700 (PDT) Date: Mon, 4 May 2026 05:31:00 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Ziming Du Cc: bhelgaas@google.com, alex@shazbot.org, chrisw@redhat.com, jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, liuyongqiang13@huawei.com Subject: Re: [PATCH] PCI/sysfs: Prohibit unaligned access to I/O port Message-ID: <20260503200256.GA1393215@rocinante> References: <20260408095532.1192625-1-duziming2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260408095532.1192625-1-duziming2@huawei.com> Hello, > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index 16eaaf749ba97..c88910bcad262 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > #include "pci.h" The "pci.h" header includes "linux/align.h" already. > #ifndef ARCH_PCI_DEV_GROUPS > @@ -1157,6 +1158,9 @@ static ssize_t pci_resource_io(struct file *filp, struct kobject *kobj, > if (port + count - 1 > pci_resource_end(pdev, bar)) > return -EINVAL; > > + if (!IS_ALIGNED(port, count)) > + return -EINVAL; > + > switch (count) { > case 1: > if (write) Otherwise: Reviewed-by: Krzysztof Wilczyński Thank you! Krzysztof