From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D352830276A for ; Sun, 3 May 2026 20:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777839161; cv=none; b=TR3PMQOkALnmq/C8Y4P3VkiJ5wmCF4LXCIoMANpao2/84qLH+lEIlWla8chudywFNSvnUF2ATPB6j/0af99b1rqRDYtfU3KMtEdnsPH6pDnufFxklX4Y+iMKbt8O8kPYuNTFrdbEgmrMlzuQYoRbAaNsZouF8JyT++/oxS0TpBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777839161; c=relaxed/simple; bh=rtrhar0vhABpDRekh8JqIicW/Rn0iSfrma3TyS52bL4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QK37efXEWp0x3zL4HL3pX+1kruABvmGEZUvx6h7gED9yEEwKgZphZZXS23L4OzDd+dZ1viaCOH7mVrlSL2ADykGVAveGqGm25j6CLFz53ddhdDXNF7LJ0QoTHkb3GZzNVvDsyyxVQ0eKL69A+oVV39CIGHrR5my5ep1r337xe3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MOpC/qF6; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MOpC/qF6" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7de4be15125so3137354a34.0 for ; Sun, 03 May 2026 13:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777839158; x=1778443958; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RbGHm08BxGQD7aCQOyLWw7aVLNNFoqSYxYwfTxucUlU=; b=MOpC/qF6iIFji1TeBUEZmOBBp56bV0lXdvBb0oUm4nFDGK5n5+rQbwGnJAWPiuhGal 0PsaojAn9YMV6WI5bO37sQuvZh4K7E1F80cnwhfGSzNN+0Rv12QOpIlcKJGpunQio9Hr 1ppSNiTdzCs2kgNlvp33Wq04kOLWYftaS1n1yW+is2IEZN2usW8VB1qsMQTeryUwyEVL YPDUN+IQr875eqwHajB6WEUtmvoPZx8cTenMXfvBGFBE4tC8B/tzrIxzen1Lju708ySs WbHtmRYNvsOU77TM59XsPT1twFhDo545dDaQDQ3xhQ4UZ07tqoKy9fG5qod6RmhY4sJ0 AQJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777839158; x=1778443958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RbGHm08BxGQD7aCQOyLWw7aVLNNFoqSYxYwfTxucUlU=; b=n3mxsUpnZDx2Sqd9I1zEKYzos5ieOgCwSDzvh8Rho208MTHM8u+1VDXztQXdE8ukcp NriTh+7whxD8AWD6WITEoxbQJ4M6qCAPAAu/2uinDeAMGs/zRdDrZrtxo7wA5mnUxTMh JhrUP+s45up7SGra1jXovclHmdsr5Dn8ds3boYA9sGSlS4GlLy0qEwqUs7T6OY6S0/d8 yGpOeO/bgC6lsI5I9tfhhSQIGpr2het4YPZqPjEOi2nih0RBwopYRL4U6amdD7Q40Ix1 rGLSozGMuWkiRzKGTQPiCp7ODZZKHkvkkQqwqQu141/i/ndYBIrmDrc1UHYnCzUgOG37 xLsQ== X-Forwarded-Encrypted: i=1; AFNElJ86fb9bIYmXO/1YfyDn6iVjmYGeVBC8aAXclDhMRrRtS8VKiV4xGfRKLKMzz+fmQAdyNOynkJw2CBxF4PQ=@vger.kernel.org X-Gm-Message-State: AOJu0YztRMym7EEPbcZ8f+gTa9P9w2mvh4RLjJDIIjha9KAZEE93yqbK LXrlOXWNhan2bgVKswy26xgF6X9BIW/Imo7dSj7SOXIiUyj/5jx+2K9T X-Gm-Gg: AeBDiesx8R/rlzFl+e54r6OhEsJKdIBo609aBNDyqpQVYZpI7ozmPeb6KbYBExUgQnF OtrVvs76sZ+JLs0TwW6fxp/vNZqnOM4OE6mQAe0szQ8SmgTjq7z2gxI82fWSia5gq5RPSfiTeva WbuCDMievt9+me2IsJu20Kjv5W0sW29lruiYZL+JwHxqobVMN3r+GQwS/QsJq65x+s8d+ah3y1d lP5Q2vf/HYPkyVDEJzRzhG7AdqQfyAMtm6ctC/0Fy04NG+22iOAC9M8KK7I02eOSIpvjJADeN+H FS/N1fMA+x9hKN0eiZraPR3uL7KosIFTik22/fqZtyARCedLUzCyON3FhNztRTgcHgacsQcQKKj Ub+NdajYTDpgCBoHKM7Ai/aqLUwOqlZCLQKws8kkxjkG8b0567gVb6EnkMnjJWxISdc+ATM5csS ifoVjajCsEq4UfB8ZecDnFsATmbr/hwo8iga+v5xbM+/ANvJUficlhfPzWMDzNiRFxZzlv X-Received: by 2002:a4a:e90b:0:b0:68a:af54:cb61 with SMTP id 006d021491bc7-69697e1852cmr3063891eaf.60.1777839158605; Sun, 03 May 2026 13:12:38 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6968947934esm5194328eaf.8.2026.05.03.13.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 13:12:38 -0700 (PDT) From: Maxwell Doose To: linusw@kernel.org, alexandre.belloni@bootlin.com Cc: linux-arm-kernel@lists.infradead.org (moderated list:ARM/NOMADIK/Ux500 ARCHITECTURES), linux-rtc@vger.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH RESEND] rtc: ab8500: replace sprintf() with sysfs_emit() Date: Sun, 3 May 2026 15:12:36 -0500 Message-ID: <20260503201236.29685-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch replaces sprintf() with sysfs_emit() to ensure proper bounds checking. It also simplifies the return logic by directly returning the error after logging, instead of logging, calling sprintf(), then returning. Reviewed-by: Linus Walleij Signed-off-by: Maxwell Doose --- note 1: original patch can be found here: https://lore.kernel.org/linux-rtc/CAD++jLkQD_ZSFPGrx4uL+ezrR1Ai2ddUF9_PpesDG+AEwiDrag@mail.gmail.com/T/#t note 2: I rebased this on to v7.1-rc1 to make sure there wouldn't be any merge conflicts. drivers/rtc/rtc-ab8500.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index ed2b6b8bb3bf..c6147837f957 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -284,11 +284,10 @@ static ssize_t ab8500_sysfs_show_rtc_calibration(struct device *dev, retval = ab8500_rtc_get_calibration(dev, &calibration); if (retval < 0) { dev_err(dev, "Failed to read RTC calibration attribute\n"); - sprintf(buf, "0\n"); return retval; } - return sprintf(buf, "%d\n", calibration); + return sysfs_emit(buf, "%d\n", calibration); } static DEVICE_ATTR(rtc_calibration, S_IRUGO | S_IWUSR, base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 -- 2.54.0